Received-SPF: pass (google.com: domain of linux-kernel+bounces-166995-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <a88f34f36ef5ad8fbcb1343a9ce79823.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <dba8658a-f13f-4fde-b610-57a391b0a1c2@moroto.mountain>
References: <53c31752-c8a2-4098-837e-2f84f03c8748@moroto.mountain> <0d26a80d9b595954aabd8f6c6e18c710.sboyd@kernel.org> <dba8658a-f13f-4fde-b610-57a391b0a1c2@moroto.mountain>
Subject: Re: [PATCH] spmi: pmic-arb: Fix of_irq_get_byname() error checking
From: Stephen Boyd <sboyd@kernel.org>
Cc: Abel Vesa <abel.vesa@linaro.org>, Neil Armstrong <neil.armstrong@linaro.org>, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
To: Dan Carpenter <dan.carpenter@linaro.org>
Date: Thu, 02 May 2024 15:24:31 -0700
User-Agent: alot/0.10

Quoting Dan Carpenter (2024-05-02 00:08:29)
> On Wed, May 01, 2024 at 05:55:03PM -0700, Stephen Boyd wrote:
> > Quoting Dan Carpenter (2024-04-24 04:42:46)
> > > There are two bugs in this code:
> > > 1)  The "irq" variable needs to be signed for the error handling to
> > >     work.
> > > 2) The of_irq_get_byname() also returns zero on error so change the
> > >    comparison from < 0 to <=3D 0.
> > >=20
> > > Fixes: 932282f154ac ("spmi: pmic-arb: Register controller for bus ins=
tead of arbiter")
> >=20
> > Sadly this isn't stable because I just send patches over email.
> >=20
>=20
> If you're going to send these as email then you should fold it into the
> original commit or otherwise people will be confused.

I removed the fixes tag. I will fold it in with your SoB, thanks!