Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1465873lqm; Thu, 2 May 2024 16:23:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUlXCiBtouWy7uXqt2FfPKMzij4zJoFch796VlKQHwhrVbLpe3hYxoMFNZtbHok1KSLYKxRz+MCJRyeqW9Fwh1w8+3JnXNPp/CYqJCejg== X-Google-Smtp-Source: AGHT+IHjcsgkYLb2w3qWbQL4dX8RdixrZwhu/+pVGx0oaomnf3Rarfw9gJM1zSOx/fq2FIN0NrJL X-Received: by 2002:a05:622a:296:b0:43a:bfae:39a4 with SMTP id z22-20020a05622a029600b0043abfae39a4mr796530qtw.35.1714692228394; Thu, 02 May 2024 16:23:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714692228; cv=pass; d=google.com; s=arc-20160816; b=NhSTgqxPkzpCku3Brcw/u2I4cwJ7teQUjCSKW6r5tOBQLoQ4kPFtfQVSNZj3va6lit CpXdAcV4OwKPNL7tVO5qS9lM2ukhyVcL81RC2yLEZX3p5fYdyFRWgp7FHJSFSsdfGQcs 6fChFfgVkw+9/jpURsHm8O7ptUREgakkdL+eLSUvB4wH19T0Fa6ch3KHcugOd9HIYy04 CEcgDYI6Y+6dgMi8csfVk1cd7kA/e1S6NPSkQCR7v+4PdUwGeuTg0EAHbl9zzXran8GB /WT6OL4Z7iMTPpzFu443XmMQ2aCcWBvfNHxHdOnKb03D4mg3YLBuX6GGqew55tC/Ft6g uksA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=uvixW0mPSuPmhpZZELn/Ux4g5wbobFuxszZqtmZPzh4=; fh=gzadkegjx508sSOZfdJST5aQ/5ZGTUK+lD8dsy4bD+E=; b=o1BXy667ne5sZG8pQXZu5L0KAc32jKVd5WATKhGx4gOE4ZGTTn2DNysHc8UrYZ0wIN KBYtjaZXOz3oowMw7GNuYn7S+QWcFM6Q6dUkEqz5pGaplVaBUoNKqsle4bE8VtusYsIS qFqqSj5kDZGnbOp2ituH+s5w+5KPjwjv+j8RClMQFOcUoO8GxNj6jY3qYAYREGn9wqbR 9z5zxaFmwUlme05GqQyAdTtowr3NySFC2DdBCyFoy6q8useINr90eplhQwwF2aBHFV0S u5G64EPovXituZFSI7wA1xOys8wI7lZimjbBOrrY7OQ5o5d31fCbDOJOBI9WOwJUNl2l LLyg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-167056-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-167056-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id f6-20020ac85d06000000b0043a74aa9cacsi2107648qtx.457.2024.05.02.16.23.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 16:23:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-167056-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-167056-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-167056-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id ED3661C20DEB for ; Thu, 2 May 2024 23:23:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8993D1CF8D; Thu, 2 May 2024 23:23:43 +0000 (UTC) Received: from mail115-76.sinamail.sina.com.cn (mail115-76.sinamail.sina.com.cn [218.30.115.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D3DE1C2AD for ; Thu, 2 May 2024 23:23:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=218.30.115.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714692223; cv=none; b=LJbsmUuGx+oD+rS7AlfHsgWinb94XqxKifA84xsuOkTTrDCsnOPSskBuLQEALUcoTOtGOzbUx1gY+19OtuUbIcfJqwKIZtLstmZbmHHWiHl2xUNfDS9aszpzZkf17ZTgPL3GptHD2YbSOP25vnwXzLViZyO6MyGJusz8MUTN6H0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714692223; c=relaxed/simple; bh=qxv6eLTXJ08RHAn4M74hEmlNHmGTF7pZkSb0aNw1mBI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dQulmHqTWjH5Z6IXb39wIMavdQc35odwlu3vDq+khQhg5NfCkgzXePIrDCGiYI8ytCj6lSkTkYZDuNgOqo3expyEZSxkCRWPaT5qhaTg2pWaMEwe89yCEJM5B4ObP8qwrG5fBBBs02Kt4SBCzp93gVvhqGh8b/engnQzFMvKthU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; arc=none smtp.client-ip=218.30.115.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([113.118.64.31]) by sina.com (10.75.12.45) with ESMTP id 6634205100005E4F; Thu, 3 May 2024 07:22:59 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 65011531457717 X-SMAIL-UIID: D436D9FE715F47DC8A982E0EA16D3A41-20240503-072259-1 From: Hillf Danton To: syzbot Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [btrfs?] kernel BUG in folio_unlock (2) Date: Fri, 3 May 2024 07:22:47 +0800 Message-Id: <20240502232247.1845-1-hdanton@sina.com> In-Reply-To: <0000000000009e614206177b0968@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 02 May 2024 09:24:30 -0700 > syzbot found the following issue on: > > HEAD commit: 9c6ecb3cb6e2 Add linux-next specific files for 20240502 > git tree: linux-next > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10efe5f8980000 #syz test https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 9c6ecb3cb6e2 --- x/fs/btrfs/extent_io.c +++ y/fs/btrfs/extent_io.c @@ -1516,7 +1516,8 @@ done: PAGE_SIZE, !ret); mapping_set_error(page->mapping, ret); } - unlock_page(page); + if (PageLocked(page)) + unlock_page(page); ASSERT(ret <= 0); return ret; } --