Received-SPF: pass (google.com: domain of linux-kernel+bounces-167060-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240502185307.3942173-1-usamaarif642@gmail.com> <20240502185307.3942173-2-usamaarif642@gmail.com>
In-Reply-To: <20240502185307.3942173-2-usamaarif642@gmail.com>
From: Nhat Pham <nphamcs@gmail.com>
Date: Thu, 2 May 2024 16:28:46 -0700
Message-ID: <CAKEwX=OUf6Rd2aEwcEYdO_D3ALrSMCTdO4fdpiqhO-F-ygyLfw@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] cgroup: Add documentation for missing zswap memory.stat
To: Usama Arif <usamaarif642@gmail.com>
Cc: hannes@cmpxchg.org, tj@kernel.org, lizefan.x@bytedance.com, corbet@lwn.net, 
	linux-mm@kvack.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, 
	linux-kernel@vger.kernel.org, kernel-team@meta.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 2, 2024 at 11:53=E2=80=AFAM Usama Arif <usamaarif642@gmail.com>=
 wrote:
>
> This includes zswpin, zswpout and zswpwb.
>
> Signed-off-by: Usama Arif <usamaarif642@gmail.com>
> ---
>  Documentation/admin-guide/cgroup-v2.rst | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admi=
n-guide/cgroup-v2.rst
> index 17e6e9565156..eaf9e66e472a 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1572,6 +1572,15 @@ PAGE_SIZE multiple when read back.
>           pglazyfreed (npn)
>                 Amount of reclaimed lazyfree pages
>
> +         zswpin
> +               Number of pages moved in to memory from zswap.

nit: into?

> +
> +         zswpout
> +               Number of pages moved out of memory to zswap.
> +
> +         zswpwb
> +               Number of pages written from zswap to swap.
> +
>           thp_fault_alloc (npn)
>                 Number of transparent hugepages which were allocated to s=
atisfy
>                 a page fault. This counter is not present when CONFIG_TRA=
NSPARENT_HUGEPAGE
> --
> 2.43.0
>

That very small nit aside, LGTM. Thanks for completing the documentation.
Acked-by: Nhat Pham <nphamcs@gmail.com>