Received-SPF: pass (google.com: domain of linux-kernel+bounces-167095-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <6d173173-97de-42a9-85f7-20c5b6a2e6fe@intel.com>
Date: Fri, 3 May 2024 12:18:32 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/5] x86/virt/tdx: Move TDMR metadata fields map table to
 local variable
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: "Hansen, Dave" <dave.hansen@intel.com>, "seanjc@google.com"
	<seanjc@google.com>, "bp@alien8.de" <bp@alien8.de>, "x86@kernel.org"
	<x86@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>,
	"hpa@zytor.com" <hpa@zytor.com>, "mingo@redhat.com" <mingo@redhat.com>,
	"kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>, "pbonzini@redhat.com"
	<pbonzini@redhat.com>, "jgross@suse.com" <jgross@suse.com>, "Yamahata, Isaku"
	<isaku.yamahata@intel.com>
References: <cover.1709288433.git.kai.huang@intel.com>
 <41cd371d8a9caadf183e3ab464c57f9f715184d3.1709288433.git.kai.huang@intel.com>
 <21310a611d652f14b39da4a88a75ded1d155672e.camel@intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <21310a611d652f14b39da4a88a75ded1d155672e.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWlCR291L0FOejVnNjhVZjlzblRqYVdSMStYOFFOc29DdUkzQ1hnYzNFay85?=
 =?utf-8?B?SGtnb3A0dDhyV0s5YWZDeXd5YmNuaXc3VFQ1VVJYR01xb1B6dUh2TUduT3VB?=
 =?utf-8?B?YURUWUZXL2s5YUFUWjRZZW5xZHhjQWRiVVl4OWF4OGVMK3hMRUFUc0QzSUlX?=
 =?utf-8?B?WUJ2ZnVBeDJ0M1JNTzl4TFBZZWxqUFZrd1JFUEpMQzY2Q3dXWmNqak5rZkpm?=
 =?utf-8?B?c2diUURzYStJSllSb0pSaGkrOXlVMWZiSC9zUjdFYVU4eUs1S1VDTy9VZEV2?=
 =?utf-8?B?dDcrTW1rekJXRXNSSVBKRWFUZDRmY3dxUk1ZN1phNDJDMlNVVEExdWp5UGlK?=
 =?utf-8?B?ckp4bnlSc2hJSENoa2grdEJINlUwamNFaGpnV0dKNDg0UkpxMWU0TE5KNWRM?=
 =?utf-8?B?V2FJVGdydHRLdFdHaWVKRjI4NWtta3dHRHVJK2krcGcvbkxIaTVXcFdpUVF0?=
 =?utf-8?B?SGtoOUFlNTJGWUxpODFPRnJkdXBVYnJiRUJPbnE4bjVYamIxdThVZXJMUmlo?=
 =?utf-8?B?bmFEdkZ0czBDNExUSllOYUNzZXNmb0xGZFE0VFRYWlJyOUUzVkM5b1pKbmlS?=
 =?utf-8?B?Sm5xZWN3WG1Uc0JoK3hBMzdOZGlaSm5pcThIY0VXYURvRWIzSEQvT0RnTkhw?=
 =?utf-8?B?NzUvRy9sdUF6eU50eC9XT3BpZStnN215Q0ozRktURDBXd041UWVOMFdlamw4?=
 =?utf-8?B?WTFQVVpQZHFvZU1zZ2QrTWt2dzlScER1WklZbC9oamlzSDBSSlZSYTl3V3Vr?=
 =?utf-8?B?VlRjUmFNN0ttclZGWVltVU8wSGpja3RGbDhRNG1XaXJVck94R1gxbDd3QVU0?=
 =?utf-8?B?YXRPUy8zeUNuS0pXa2M5MUpjV1ovY2xuVDFXY2xkWHFpK043dC9sZWZERmZE?=
 =?utf-8?B?dmU2K25aNjJuTUNMcitZQmE4d1ZEWWpTMC80d2ZKMWVKbGJoK1pQKzdwMzYw?=
 =?utf-8?B?eFYrbmxHakhBcTVicmJLOG5SUjVwNGV6akhRM05RT2NHTUZocytlVGFIdENq?=
 =?utf-8?B?ZWNIVzJqOGFaRC93RzdGd3dsQmZoOVhUM0pOamNwZEpuWTBTbW5YS1VIWlNS?=
 =?utf-8?B?TmF0RjA2WFFsKzdBS2dVdmRDMmZZTEFWSzAxT2VBa3VUNHRkMlA1VUhjcldJ?=
 =?utf-8?B?WDkwek1Pb3ZWSG94QXNURmg4WExGZWZOcFMrdTJ1MXVWUTFjaTBuL1AvM1VF?=
 =?utf-8?B?TFNsWHdzMVVoUm1JVXhMcU1tQlUyanI0T3d6dEZSTzdYSE90Ty94d0dSTmpR?=
 =?utf-8?B?akRDNFJONlZLV1NkKzJIalZPMG03aWNXSDB4U0pTZ2dKQlgvZEtiaVJ4QjVx?=
 =?utf-8?B?WUNmTExtOGhlM1VkNXRrN09oVTBIMURyV2VVQkdCLzA5eFF3OGFOaFZMWTNu?=
 =?utf-8?B?STI4OWR4SDJqZDZoTjBXc21oSVo2czQ1QWVsTzVQSFJIVktlNFBsakJ0YkxP?=
 =?utf-8?B?czYvSUV6b2Nicm1IeTNrcENNRldMbWJFNTFyUWRnMGVDR1AwSFRkOWROa1g3?=
 =?utf-8?B?a3Q5cWc4Y00vTDRIZ1FIMEFtSG9sVjU1OU5jWm1zbWVxbFRDQXlXaTF5UzRo?=
 =?utf-8?B?dkUvQ1lzNlVaaEFsbVlPWVk4emtmOG03emRRTUVLcVUra0Q4RXl6ZTZuUjln?=
 =?utf-8?B?TXpNc3VTTUVIK3luSFpzb3VrNnFldTNTU3FvZGFZR1JIREJsWE9GTmlYWE4z?=
 =?utf-8?B?ampQQzBVMlFJQ01KQzA1emxIbWxyL3J2RndRN0tNTzFPY0VRd0xGZHdjQkpy?=
 =?utf-8?B?dEhmYXlUUy9lQ2Rsdk5oU0sxMTNYMUJiRlV2aHVQaVNkTUc4Ung0U3llSExF?=
 =?utf-8?B?NXBIamU0ZE9rdStETkFZQVF1bHVaa3FLYVh5SkIvN2tMMngwdDRmSUlUcm8z?=
 =?utf-8?B?ZkloaldEeFk2Vy9RZmZkY0ZjZ3hhZVYweEtBdXVCTFBsU0NqMVBEVU5tWVQ0?=
 =?utf-8?B?eVE2VnQ3NVU5Zm5EcVZGM21wTHNWbUh6K2FkWVRncndxeGlQUnBUZUlkcHl1?=
 =?utf-8?B?S1l1emI0TUpiUGl6YXo1alNIQndBZVBOQkNOeTBHZWtNemlUZk9yMnFzY1Zt?=
 =?utf-8?B?clF1R3BvN0F0OUZVazRpam9EQ1R6akgxcU1nOXA0ekhtZVMvdnJocXkvZUQ4?=
 =?utf-8?Q?GaZQCcfGsoqh/g0EUMHZ5/NDL?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d1c26141-c04e-4a27-0f99-08dc6b069768
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 00:18:43.5595
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8lxS3dDQWQhMxVHuPoZUuf+3D2rX/KrzZSXaUEU0e7JdPax5ssiEOoV4xytJwyB5KTtKfZfdwjqxkWX7F3mlVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6389
X-OriginatorOrg: intel.com


On 3/05/2024 12:09 pm, Edgecombe, Rick P wrote:
> On Sat, 2024-03-02 at 00:20 +1300, Kai Huang wrote:
>> The kernel reads all TDMR related global metadata fields based on a
>> table which maps the metadata fields to the corresponding members of
>> 'struct tdx_tdmr_sysinfo'.
>>
>> Currently this table is a static variable.  But this table is only used
>> by the function which reads these metadata fields and becomes useless
>> after reading is done.
>>
>> Change the table to function local variable.  This also saves the
>> storage of the table from the kernel image.
> 
> It seems like a reasonable change, but I don't see how it helps the purpose of
> this series. It seems more like generic cleanup. Can you explain?

It doesn't help KVM from exporting API's perspective.

I just uses this series for some small improvement (that I believe) of 
the current code too.

I can certainly drop this if you don't want it, but it's just a small 
change and I don't see the benefit of sending it out separately.