Received-SPF: pass (google.com: domain of linux-kernel+bounces-167135-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <45eb11ba-8868-4a92-9d02-a33f4279d705@intel.com>
Date: Fri, 3 May 2024 13:14:22 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/5] x86/virt/tdx: Support global metadata read for all
 element sizes
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: "Hansen, Dave" <dave.hansen@intel.com>, "seanjc@google.com"
	<seanjc@google.com>, "bp@alien8.de" <bp@alien8.de>, "x86@kernel.org"
	<x86@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>,
	"hpa@zytor.com" <hpa@zytor.com>, "mingo@redhat.com" <mingo@redhat.com>,
	"kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>, "pbonzini@redhat.com"
	<pbonzini@redhat.com>, "jgross@suse.com" <jgross@suse.com>, "Yamahata, Isaku"
	<isaku.yamahata@intel.com>
References: <cover.1709288433.git.kai.huang@intel.com>
 <17f1c66ae6360b14f175c45aa486f4bdcf6e0a20.1709288433.git.kai.huang@intel.com>
 <c4f63ccb75dea5f8d62ec0fef928c08e5d4d632e.camel@intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <c4f63ccb75dea5f8d62ec0fef928c08e5d4d632e.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHlRQjNjQkJFajdRTXc3KzhCc2xST0s2dHJsMVZCWWpFMVY0YW1lRWNmMFEy?=
 =?utf-8?B?YkR3THFxYmQ5R0RDVGlHUVlJYU1VR0NBYVFHeHVIOCt6ZXBsTkVJN2Y1cVF5?=
 =?utf-8?B?N25vbThFRmtQcldQUDdpdUlzQ2w2TytKM29aaE0wZUJnMjVENDhZd3MrWUNH?=
 =?utf-8?B?alU2dFB3L2IrTTAyUmFvbndlKzdhby9mUmcyRW5hTFhRcmM1UEYxd1d6SlpB?=
 =?utf-8?B?UlpPblNTcnpNb1gybUFwNll5ZlNzYlNXTGNTdkV1Skt4RG5zd3VNK2JVR2I2?=
 =?utf-8?B?ejI2VnQxUE9YTFVkU0ZLbUo5VDR6UXp5Y3BTeTNVYjVZOTU5T0hjNGg0SlRI?=
 =?utf-8?B?ZXY1ZGlYL0ppeDVNLzRiWFB5OXRXSVhpUlpZWkhOSU55NkxpcmFMcDBKZDMx?=
 =?utf-8?B?Ky85cnF5QytTT25YRW04Y01VbGllV3JKWUdWQ3dEakl1cVcxMTU3SnNLNkU1?=
 =?utf-8?B?ZEIvRThaRm9RMi9yY2tBdDBMbFYvSWlIeTNsWksxYm1uKzlNYzlKQ2orY3hv?=
 =?utf-8?B?VVkwbE4yMHcwbEIxMFB0elFtRUwwRm02dXVhb0FZQ244dnVNSlZIRXMvOHN0?=
 =?utf-8?B?RDIzcGNLeFdMUTlxSTdPeDhOZ0FzaGVXc0NZM1VaUmlsZTgyRm5oMERGODlP?=
 =?utf-8?B?SlBJZExscjlTTktUSzArb2xZUlorNWJIMmdvVFJ6Zm1VbVZqMlBrc2x5Ky9x?=
 =?utf-8?B?U0xONUZLcnI4Y096cjdFM0ZYcXFRVGx1ZTJ2bnNwVHk5SnM0Z3pZNWJGRGh0?=
 =?utf-8?B?MzVoWTR5dXVuRWJDQWJCSmxzWlVRYkY5b05rN1NyNGF0RFZFdml2VW00cFkw?=
 =?utf-8?B?Q2MyTG9aUWs2UFBLRGZTT2Y2OWZjeE1hWlQ2azZVemtIZTN5eDNRK0NaM1JQ?=
 =?utf-8?B?ZG14MHMvcW4wT1VOUkZxRGNCZFd5Q0pNZllPVkpraWJvNU5CV0xjKzI5UWo3?=
 =?utf-8?B?aWxERTZmbmk5bmdVM09ONnRyUXZpTDZ2K3BwcWYzOGRJS0xheFc5U1U5cnUv?=
 =?utf-8?B?M1haQWJ5bGptalI0T3JjTFQ1Z2wrdmN0dXF5VktoRllVZzd0a1Zra0VaZ2xu?=
 =?utf-8?B?VkZUZXpqOXNGdUUyUHpqWHFaU0creWxlbG10Y29rcDlrUzYvejkxYnNGbGJU?=
 =?utf-8?B?S2lkUlFoZkJva3pwZmJZSjBxZWVjdE45U3JCVGc1UldCaWNIaTBjVHZIWnV5?=
 =?utf-8?B?YjVmOUFQeUJ3d2kwdHBxQWdwTURsb2dsL3QxYlE2ZGpNNk01dDliUjlyR0NC?=
 =?utf-8?B?RGhPOXV4VUZWOEtoK0xmbXJSVzNGc2tHNExKNHNmM2xvMTA2RkNKL1NKTW9s?=
 =?utf-8?B?dE9xTWNxY2U5TXFwamRuQjJ6bUNWQ2x3Q1NMYjAwS3Yzelc1aVBhU2VJUEI2?=
 =?utf-8?B?aitReTFTYWVZYmxGNWZZOGZET2R3S1FSd2FWeGRGZ09kanZDanhGcy9mTW82?=
 =?utf-8?B?VmtqcHcxK0NIRUN3ckpFNW9iWFJiN0JpZCt4SUgvOW0xTTdabGE1M0Z5VTVq?=
 =?utf-8?B?R29ZWitnZmtaUnFNNlBFVzdNUVhEK1FrcFc5aHJFSlJMZUMxdDJuellQNm1s?=
 =?utf-8?B?TUpJelNYaFgrd2RrNEptUW5Ka0FXS2ludmxCaHErQTVUVERrQWpyMWM1SVZp?=
 =?utf-8?B?V09wVFB6S2NUTng4TzRwV0dBTCtDR01qaWRkcTFPNGdaeGRjdS9EandSRjRr?=
 =?utf-8?B?Z1ZSVzJMUXJEclZKelFKUUJvYzExdUVOcHNvZURYeWl5bG9EKzhMSHBleVFQ?=
 =?utf-8?B?YWI5TTJMT1NGYmRWQis0K2N5UHNIRDVJRTJ4d2I4M1JTYXovblh6bjlzSDc3?=
 =?utf-8?B?Y2JmaXRpdFZtMkMvZjdUSFRWWFd2YjNFMkxwYmxkOGx2OE16TEY5MHp3QkRO?=
 =?utf-8?B?VEc2czJTRmpHYll4ZHhVRHVHT0ZZMHpZeTlQbXUzR2g4VjUwOGZhYWwwVER1?=
 =?utf-8?B?RHEvRkhnbklOZUdDOWdmSHdQNlVuc0xheDN6allqa3oxYVNqWmtMY1c3SldQ?=
 =?utf-8?B?V0VDSldNR1JCRmNGajd6cnBZNnVncUNMZGxSMURnVFpkUnFod3NNMVFYMXZq?=
 =?utf-8?B?Y3publZZK3RBWmgzOEYybkJkMm1pdFJpYTBBbDBUbEVvZzY1SU41WHZET2xY?=
 =?utf-8?Q?p31xcXRiO6tVU9rCWgGtgQbaj?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c1e135b-6a1b-4b42-aee3-08dc6b0e6427
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 01:14:33.5411
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VN9eWcEL/tIOvIDSx9AQzFk9BcZ2KTy/VWzS9kqmag/LRz98wfv5Ye1Wp/0GsKNMMM7xLqP4E2IEKA2/JmGBYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7430
X-OriginatorOrg: intel.com


On 3/05/2024 12:19 pm, Edgecombe, Rick P wrote:
> On Sat, 2024-03-02 at 00:20 +1300, Kai Huang wrote:
>> For now the kernel only reads TDMR related global metadata fields for
>> module initialization.  All these fields are 16-bits, and the kernel
>> only supports reading 16-bits fields.
>>
>> KVM will need to read a bunch of non-TDMR related metadata to create and
>> run TDX guests.  It's essential to provide a generic metadata read
>> infrastructure which supports reading all 8/16/32/64 bits element sizes.
>>
>> Extend the metadata read to support reading all these element sizes.
> 
> It makes it sound like KVM needs 8 bit fields. I think it only needs 16 and 64.
> (need to verify fully) But the code to support those can be smaller if it's
> generic to all sizes.
> 
> It might be worth mentioning which fields and why to make it generic. To make
> sure it doesn't come off as a premature implementation.

How about:

For now the kernel only reads TDMR related global metadata fields for
module initialization.  All these fields are 16-bits, and the kernel
only supports reading 16-bits fields.

KVM will need to read a bunch of non-TDMR related metadata to create and
run TDX guests, and KVM will at least need to additionally be able to 
read 64-bit metadata fields.

For example, the KVM will need to read the 64-bit ATTRIBUTES_FIXED{0|1} 
fields to determine whether a particular attribute is legal when 
creating a TDX guest.  Please see 'global_metadata.json in [1] for more 
information.

To resolve this once for all, extend the existing metadata reading code 
to provide a generic metadata read infrastructure which supports reading 
all 8/16/32/64 bits element sizes.

[1] https://cdrdv2.intel.com/v1/dl/getContent/795381