Received-SPF: pass (google.com: domain of linux-kernel+bounces-167152-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 3 May 2024 10:41:04 +0900
From: Mark Brown <broonie@kernel.org>
To: Alina Yu <alina_yu@richtek.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	johnny_lai@richtek.com, cy_huang@richtek.com
Subject: Re: [PATCH v2 2/4] regulator: rtq2208: Fix LDO to be compatible with
 both fixed and adjustable vout
Message-ID: <ZjRAsJHn57pZy5UH@finisterre.sirena.org.uk>
References: <cover.1714467553.git.alina_yu@richtek.com>
 <ffeecd61c194df1f7f049bd50cb2bbbad3cf1025.1714467553.git.alina_yu@richtek.com>
 <ZjGmmYWHu-ZQQdIh@finisterre.sirena.org.uk>
 <20240502073029.GA4055@linuxcarl2.richtek.com>
 <20240502092614.GA31518@linuxcarl2.richtek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="v3Pbxy3XR/i3izJR"
Content-Disposition: inline
In-Reply-To: <20240502092614.GA31518@linuxcarl2.richtek.com>


--v3Pbxy3XR/i3izJR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, May 02, 2024 at 05:26:14PM +0800, Alina Yu wrote:

> For the fixed LDO Vout, it will be set to either 0.9V or 1.2V, which are outside the range of 1.8V to 3.3V.
> The determination of whether it is fixed or adjustable lies solely with the user.
> This modification aims to ensure compatibility with the user's application.

That's a substantail reconfiguration of the regulator, it would be
better to have an explicit property for these non-standard fixed
voltages rather than trying to do this using constraints, or at the very
least have validation that the values being set are supported by the
hardware.  The code should also be very clear about what is going on.

--v3Pbxy3XR/i3izJR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmY0QK8ACgkQJNaLcl1U
h9AG+ggAgPDHwSBgOVlPGTgUQMeT5eYCmBzi9FIfmdiPaU88tF2UzX5hGzI0RuvB
ntbNtCdIrgaF9Z8n4V+xIYoUhBK53+8+rNXR9YtAjJvK8DPhKLfH0dyEYzUl+Akt
i38SGrUUfHcS6ZCWFCeK7Gvm3eE5yEIkhkG+rwhivnWiJOpx1HgUGO8Rz1gZbeyc
0/W6upAeHiSJkwwTYeWS2OBcS1aE/JV/+4BsW+gEmY49QZ83BeV2+00q9M/JInr5
mugnyUEc9aMaaTOkLZu8F3jzx4ys9nj3i+B7O/aXDDqjOqFFgxOC2t2Bg0bd6AKE
0/J8trkNef+nN15GAWLn0MQGepvTUA==
=E/Hq
-----END PGP SIGNATURE-----

--v3Pbxy3XR/i3izJR--