Received-SPF: pass (google.com: domain of linux-kernel+bounces-167167-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240502200529.4193651-1-usamaarif642@gmail.com> <20240502200529.4193651-2-usamaarif642@gmail.com>
In-Reply-To: <20240502200529.4193651-2-usamaarif642@gmail.com>
From: Yosry Ahmed <yosryahmed@google.com>
Date: Thu, 2 May 2024 19:06:50 -0700
Message-ID: <CAJD7tkbgknhot8Kz9jpF=0z1OHiLH5s3PfmbHd=TetrK7PtC6w@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] selftests: cgroup: remove redundant addition of
 memory controller
To: Usama Arif <usamaarif642@gmail.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, nphamcs@gmail.com, 
	chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, 
	kernel-team@meta.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 2, 2024 at 1:05=E2=80=AFPM Usama Arif <usamaarif642@gmail.com> =
wrote:
>
> Memory controller is already added in main which invokes
> the test, hence this does not need to be done in test_no_kmem_bypass.

nit: The memory controller is "enabled", not added. Same for the subject li=
ne.

>
> Signed-off-by: Usama Arif <usamaarif642@gmail.com>

Acked-by: Yosry Ahmed <yosryahmed@google.com>

> ---
>  tools/testing/selftests/cgroup/test_zswap.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/=
selftests/cgroup/test_zswap.c
> index cd864ab825d0..19ac29c533e0 100644
> --- a/tools/testing/selftests/cgroup/test_zswap.c
> +++ b/tools/testing/selftests/cgroup/test_zswap.c
> @@ -485,8 +485,6 @@ static int test_no_kmem_bypass(const char *root)
>         trigger_allocation_size =3D sys_info.totalram / 20;
>
>         /* Set up test memcg */
> -       if (cg_write(root, "cgroup.subtree_control", "+memory"))
> -               goto out;
>         test_group =3D cg_name(root, "kmem_bypass_test");
>         if (!test_group)
>                 goto out;
> --
> 2.43.0
>