Received-SPF: pass (google.com: domain of linux-kernel+bounces-167174-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Wang, Wei W" <wei.w.wang@intel.com>
To: Sean Christopherson <seanjc@google.com>
CC: "pbonzini@redhat.com" <pbonzini@redhat.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 3/3] KVM: x86/pmu: Add KVM_PMU_CALL() to simplify
 static calls of kvm_pmu_ops
Thread-Topic: [PATCH v3 3/3] KVM: x86/pmu: Add KVM_PMU_CALL() to simplify
 static calls of kvm_pmu_ops
Thread-Index: AQHalw+NriuTQtnWX0+9HT1Q2NE/m7GEpN0AgAArYgA=
Date: Fri, 3 May 2024 02:15:38 +0000
Message-ID: <DS0PR11MB6373EA67C70B8579A194089EDC1F2@DS0PR11MB6373.namprd11.prod.outlook.com>
References: <20240425125252.48963-1-wei.w.wang@intel.com>
 <20240425125252.48963-4-wei.w.wang@intel.com> <ZjQjYiwBg1jGmdUq@google.com>
In-Reply-To: <ZjQjYiwBg1jGmdUq@google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o4krxRYCQqvKM8wZ2fElz7FaN1C6hO/W/bnG9kbCU2rTcWcaytfSRIk0XWFK?=
 =?us-ascii?Q?zqrbydNWh2U8F9SX6p39KBY7LHsYd/ZjFDz6CTlT52yrPKABcSkKQhEXvStb?=
 =?us-ascii?Q?llYl9TeJR8AzDvXgvJlmqJieS2Sg+WA9eO6J7bhFgMBwm3eo2wsRlzGJxnQY?=
 =?us-ascii?Q?KW9gFycrmVzHSgaoYwvQVKG5RgwR9BesBM1AuZ6kZ8dpbQqbIQAdU+X/9kxK?=
 =?us-ascii?Q?u3f00u8i5TcbtCGePiP3U3kLsZoZrR2FtR0LApBoDl99epigcPmZxfBY8YYt?=
 =?us-ascii?Q?ldpkI7My9+VCa9TMbOk5gvrkYzMy6VYIIrhAZtGPaW39BC/ln5EnKBaQzpvC?=
 =?us-ascii?Q?z2u63+yABS73uabvdpPuNxkdGix2grFIcG3KPrdsu1qZ3CxyxYgCQEYNSdGS?=
 =?us-ascii?Q?+ManDanOsDQymKQdbdyCknEFfYyWrPyP5abm8vHY/3FunwoDbcj3CvBnBf0V?=
 =?us-ascii?Q?eJh5pl/ouOa1GX3EVKeVHb0NEa06x0GBoKnwVx4cn10Gr0SMLsExy62cuQmb?=
 =?us-ascii?Q?wejFbkCZUlYBty/Tkx6UrqAq8yTK/tPbghhyvBv5q2LNNvYfFcQKq8D/X7Ht?=
 =?us-ascii?Q?4DNIbG92dKNhOB+MZmZapJ89egYBqt0EokGtcXwQ+tJO5bwg71HS6T7IKjQn?=
 =?us-ascii?Q?CdcKy3MTq988R+qmpjvMQkWUHnGE1cBEWx3Kiz2mX2/QlQz1dKa0xKvUStV/?=
 =?us-ascii?Q?6vnyLfuaLpWZWcZ9WGapjqDlnNz2DABrfxKyHeHQa87ycAIoRvTLFymYInng?=
 =?us-ascii?Q?Mij9Ty++mj1Rfj8DUSM1UZOI7fhm3AdqJe6Bgyb9vmKiRE6tsIy6c7JmTqsH?=
 =?us-ascii?Q?OdW5LVVAx1JCnyAGeoW9IzKL+Ln7Ot1kH3R35Cc9Ntb6z1iNqNyUt1Ay/J9s?=
 =?us-ascii?Q?TKYTEt2kaMrtHiSQ8vDGmE87NdUoYcU+8LYzIJMdmfzIu39S6sQA0CvwqHF9?=
 =?us-ascii?Q?AVA3Bx9yTajB0A8YnDwmXYdnVjFjwOMgVRYxeVHBeIfqZWKY5PicpJSKXOQm?=
 =?us-ascii?Q?e5drIuzwoZkOQkwAU8xd+2yZs3i/TdI+BVlLVjbilYDWo3sQNnh6LTne4HLo?=
 =?us-ascii?Q?c+dAkyJ5V7KOwBnDYPgaoclLpCjmynCDKMyk96oHWxwTDzsb7s31hzN5rzd2?=
 =?us-ascii?Q?VrfTOKc6ld75/OPzmv0fau1Zma5y4zApDw4UpFAUXC+Wp5kC+BOMx7zBgiKY?=
 =?us-ascii?Q?hhGxbtO3gs87Pa8LgectdWuzgpAssp/QkVKH0hUW6Bei2+LF7jlPrJE6DxsI?=
 =?us-ascii?Q?7L6SVgTgv2LN/5CbmaRGhymSoKoLmrYtCB5FPdU6Lt8GcEPNr3ko3pcVk2qT?=
 =?us-ascii?Q?/qhd3r3sM5AqdiENdfdv8MEP+IJj0pglAWCLdR6mf9t3YiNVWCYeeyTvi56+?=
 =?us-ascii?Q?WeWnc7iKnDpT7nQ0MZ7xHBl9xV0b22b+hME9glJJMZc/+ujKLPz8J70BNaw9?=
 =?us-ascii?Q?jEqinhY8cXKp89J3oNT86UD3fnwnkWDQ0WLj0jmipDfHPoAmZ3RapMO2T03L?=
 =?us-ascii?Q?90Vu5As9rXGi7bcH7L0OpL2WVpSYe+OH21p4XDLzmXc7SiNgT5ax6SKuUY3f?=
 =?us-ascii?Q?jBOAbnXS9HeHnGS9zaC3IovJg3srKCjlFk+p4kGr?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6373.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91511715-b1f6-4567-be88-08dc6b16ec7e
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2024 02:15:38.0711
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nJGZCVdBUb4kl6TI1UnifqlSuEtEp7OLpWWUK6L0y1/xjRZ+VRM87WQxMfHCpgAdBoJMqq19+cgL7DyEFynozQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8604
X-OriginatorOrg: intel.com

On Friday, May 3, 2024 7:36 AM, Sean Christopherson wrote:
> On Thu, Apr 25, 2024, Wei Wang wrote:
> >  #define KVM_X86_CALL(func) static_call(kvm_x86_##func)
> > +#define KVM_PMU_CALL(func) static_call(kvm_x86_pmu_##func)
>=20
> ...
>=20
> > @@ -796,7 +796,7 @@ void kvm_pmu_init(struct kvm_vcpu *vcpu)
> >  	struct kvm_pmu *pmu =3D vcpu_to_pmu(vcpu);
> >
> >  	memset(pmu, 0, sizeof(*pmu));
> > -	static_call(kvm_x86_pmu_init)(vcpu);
> > +	KVM_PMU_CALL(init)(vcpu);
> >  	kvm_pmu_refresh(vcpu);
>=20
> I usually like macros to use CAPS so that they're clearly macros, but in =
this case
> I find the code a bit jarring.  Essentially, I *want* my to be fooled int=
o thinking
> it's a function call, because that's really what it is.
>=20
> So rather than all caps, what if we follow function naming style?  E.g.

Yep, it looks good to me, and the coding-style doc mentions that "CAPITALIZ=
ED
macro names are appreciated but macros resembling functions may be named in
lower case".

To maintain consistency, maybe apply the same lower-case style for KVM_X86_=
CALL()?