Received-SPF: pass (google.com: domain of linux-kernel+bounces-167176-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <330c909a-4b96-4960-9cad-fd10e86c67b8@intel.com>
Date: Fri, 3 May 2024 14:17:26 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 5/5] x86/virt/tdx: Export global metadata read
 infrastructure
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: "Hansen, Dave" <dave.hansen@intel.com>, "seanjc@google.com"
	<seanjc@google.com>, "bp@alien8.de" <bp@alien8.de>, "x86@kernel.org"
	<x86@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>,
	"hpa@zytor.com" <hpa@zytor.com>, "mingo@redhat.com" <mingo@redhat.com>,
	"kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>, "pbonzini@redhat.com"
	<pbonzini@redhat.com>, "jgross@suse.com" <jgross@suse.com>, "Yamahata, Isaku"
	<isaku.yamahata@intel.com>
References: <cover.1709288433.git.kai.huang@intel.com>
 <ec9fc9f1d45348ddfc73362ddfb310cc5f129646.1709288433.git.kai.huang@intel.com>
 <affad906c557f251ab189770f5a45cd2087aca19.camel@intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <affad906c557f251ab189770f5a45cd2087aca19.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2RWWURSSmhCeVNSK0R5NGV0RWNUWiswbmlqZlpIVWt1WmFiOXk2enZtMVBx?=
 =?utf-8?B?aExQcnV0eHNmUFNrVnBqVVViakczSTRCajgwS1kvSE01L1ZNSXQzNk9mVVZx?=
 =?utf-8?B?S0c0bXk5YUxtSzJDaWtXU2tRdktqYS9FVTN5OUZlRUhZaElEWitQL0F2dnFh?=
 =?utf-8?B?TUV1N21ZNlVwMzdtZlhjc2lHazk5ZWp3c0VNTWFvcWZEQjRQdDNoK291ZkRt?=
 =?utf-8?B?NWZUTEx5bHVhN1d5ZkFMVnkya3dZUlZ2aUhyaUFPbVVBVlpqdUNwdEdOaytk?=
 =?utf-8?B?Y0I5cmlmaXFOWWJvN0JSUi82dEU1Rm00YzJnbUx5OGU0UVVaSjhIcm9GQU9V?=
 =?utf-8?B?Q2hJenliZFpMY0RoblJJVjR3Vk9uMlBkcTNtWU96SWN6bzhaU09BdGRnVE9n?=
 =?utf-8?B?Mk1CSGloM1U2a0VIM1k3bmRsaml5WGVtczNaK0h4cGN1RUt3ZG1zT3pKangy?=
 =?utf-8?B?TWUwTzZ5Z0x5NE5iZ29YRnNGYUdsdVhEYkE0U0dMTDdUMXFQNE9IeWU3RERu?=
 =?utf-8?B?WVNjQUYvWTI5N1JFL1FJSThjU0VnZGEzOFM2czZaVFQ4bGpTNXJpZWJuTHR1?=
 =?utf-8?B?bG1Oall2bEQ2ZmhqcG5nK3hCdnJrbm9TM0ZUaXRIZVhkSS9oeEJmR0J6TDZ4?=
 =?utf-8?B?SlFSRFhKRWNXcTBEcTJJU3lyak5maUFuRWVJTGFocHcyTnRsRmRzcnRlbnYr?=
 =?utf-8?B?c0hjWDFiOGhKTThUakJHd09haHBPdVFScjVEVU5Qai8rU2RDT3pPdEE3Y3JR?=
 =?utf-8?B?NEdPVmFYY3Z5Z1M2WEREOW5sWmZ0UHpMeUJ0SFRRVjhtRTZ5dWowYmI3enVw?=
 =?utf-8?B?OEpGVjhHT0VNRlYrZlRXSWhSYWcvVElwQmJ1a003S2U1VGZEeHVyMDhZR3g0?=
 =?utf-8?B?ay9hS2gxbzJHbjUzUXl3QXBUMmdXRGh0dytYdHA2SENCN3UrZmhuLzZ5OFRm?=
 =?utf-8?B?L1JRMSt5YVZoemUzaEtzVXVSWjJQck8remcxYUVhekhRSExoQUUxWEdxb1A2?=
 =?utf-8?B?SnRhMFMzYXlSTlZkbkMzTXZFRVBzZVNEWVJHQVp4MzZoRUxhUFRSOHNuNDdV?=
 =?utf-8?B?UFpyQzZBTTNvOEVZOVYvQk1NTVJDTEcvamxIM0lSR1BuQXRWalVrY2VzVjVr?=
 =?utf-8?B?dzZSNFV2eDZXdXpGQytkRnYrN3RoMk9LbnhCcEljT0tONXY2K2I3OE5xS2VP?=
 =?utf-8?B?WExZQlNFMk5mMFY1MWxaMEpxWVV6azlmQjNCSXhQODJ0SkxxRUlWbzdYK0xR?=
 =?utf-8?B?SnFldjBKTzZ4c3c5K3V3L0hpczkrM3p3VS9SMm1XNTM5Wmt6N3l1enJYdno5?=
 =?utf-8?B?Z0hXZGpGRkw1aGY5VXNwVE1MZG9YNWJQY3lUaGFUN2RoZXQzekM1THkrNHMw?=
 =?utf-8?B?Q09mZ0pMQTJvL3FTMWg0TkU3SWw5dDV3d1VuWEtidnRQSjdtRFo0SENQQzJx?=
 =?utf-8?B?cWZ4cW9qaUNqeDQ0aGlmTGlOVWFxRGo5YXZYVXhodG1LYnM1eGl5Y3c0VFRY?=
 =?utf-8?B?UjM0Sk5HcGY3VGQ0K0FJUXAxNFU2UVJ5NGJOVFkwQkU5TkJYZ2l1cXl6SG1Y?=
 =?utf-8?B?Z1NJQzFVbVVlNUt2OVBFaUppYWM4MTBxVUxLbGdibVNRMGxGWDdJQ3lBUVRL?=
 =?utf-8?B?ZkhJK3JKMFhaSFVOUkZKcVRNem8vY1B0R0FPMGJiYWVoU2RQTEVFdmtYdis5?=
 =?utf-8?B?SVJPaEVCUVY0Z2FMYXlXem1LQ3JlZWVYcEUxZWp4aDYyOFZ6WDNDUHdST0tP?=
 =?utf-8?B?cmlGYnZadE5kZndhRjBuRHBGUlpyOXQzYmpMeVRPYnRVSTFMd1RZc25YL1hV?=
 =?utf-8?B?MEtWOGlSTGhocCtZL2lxWTBVSllRVTQ4L0VwbnljSnpKRmVzT3gwWEZFY1B3?=
 =?utf-8?B?K1RSaE80VzdEK2lxeGNqeW9sN2JrSUpBRTFCRlBaMEFGN2pqMFM1NFJsazhZ?=
 =?utf-8?B?QW1NMUp3blU2TDRmcDNkT0tWaldGYXQ4OGxSWGxxKzRWY3ZQdy9XZGR1b2No?=
 =?utf-8?B?UTJhQzdYcFRVdTkxMlQyaWJQNUV0NXRYK3UyQnpkeDV0QmJmSmgrUFpvS2NI?=
 =?utf-8?B?a3hoTmx3K0lyem90aUN3Mjl4YnNVSVZ1YlZ2ZkdXUUNJMTA0eHllU0RWYlpz?=
 =?utf-8?Q?ug3esT8c0qL4uC55AsUSWj8wX?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c6f5e67-1932-494e-3291-08dc6b1732c7
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 02:17:36.1501
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4ug5lCEQmDkhXM1qga2HQAk1+RBA8b/E+a7ghwiv5dV2Y/BKoPLvCi5EJVcdsBP2xxqgAmx0vhXXHTV2txfFpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6179
X-OriginatorOrg: intel.com


On 3/05/2024 12:21 pm, Edgecombe, Rick P wrote:
> On Sat, 2024-03-02 at 00:20 +1300, Kai Huang wrote:
>> KVM will need to read a bunch of non-TDMR related metadata to create and
>> run TDX guests.  Export the metadata read infrastructure for KVM to use.
>>
>> Specifically, export two helpers:
>>
>> 1) The helper which reads multiple metadata fields to a buffer of a
>>     structure based on the "field ID -> structure member" mapping table.
>>
>> 2) The low level helper which just reads a given field ID.
>>
> Could 2 be a static inline in a helper, and then only have one export?

I assume you were thinking about making 2) call the 1), so we don't need 
to export 2).

This is not feasible due to:

a). 1) must 'struct tdx_metadata_field_mapping' table as input, and for 
that we need to ues the TDX_SYSINFO_MAP() macro to define a structure 
for just one 'u64' and define a 'struct tdx_metadata_field_mapping' 
table which only has one element for that.

b). TDX_SYSINFO_MAP() macro actually doesn't support taking a metadata 
field "variable", but can only support using the name of the metadata field.

However we can try to make 1) as a wrapper of 2).  But this would 
require some change to the patch 4.

I'll reply separately to patch 4 and you can take a look whether that is 
better.