Received-SPF: pass (google.com: domain of linux-kernel+bounces-167203-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 2 May 2024 23:05:39 -0400
From: Frank Li <Frank.li@nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Christian Gmeiner <christian.gmeiner@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Christian Gmeiner <cgmeiner@igalia.com>, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8qm: Add GPU nodes
Message-ID: <ZjRUgze4iC5O0Iy9@lizhi-Precision-Tower-5810>
References: <20240502215747.2832126-1-christian.gmeiner@gmail.com>
 <CAOMZO5CY8PQN7b01N+oNO=92CVtPPfWzuzxphs49gh+4H+58Mw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAOMZO5CY8PQN7b01N+oNO=92CVtPPfWzuzxphs49gh+4H+58Mw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SjVVMU1mQjFDd29PdkNPendkYzRzZVNmVms4QmY4WVRvTTUwdTJtMUtLYW5M?=
 =?utf-8?B?NndxS2hyd1hLUEVJSGlmL2dZTGFkeEdQVHpKVGEvMDk0ajFwUG1yS3lxbGUy?=
 =?utf-8?B?cDhRZVN6Vkc2UWFvcmkvUFpRbENMeGthSVlGanBFelJ6bjQ4ZEdKWmsyQ0k0?=
 =?utf-8?B?M2FFQ1NYaVY5K0pJVnVwSEtqQm1LeVg0UnA1VlV5RmxqR0tLdU8wMytRZ3FC?=
 =?utf-8?B?UHJZM2p4ZGtpWjRxeFduVlFBd3BWbDdPMGZUdDNoZEZXMWs0QmRiS0dKZE9C?=
 =?utf-8?B?UjJ1ek9RMkpmcmFJakFsblpWUG1iT1dKYUNzalFxS2ZhbDlrSUNiTlV2aVBV?=
 =?utf-8?B?aUM4eEtrbGpTUWtuemZrazMyeVhBOXByUHBka1dJelFLTENpbC9rY2RveGNN?=
 =?utf-8?B?eTFXblZjU3BNZnA1N1NjZ05xWXN4WXB0ZnlVT0IzOHR0d0tWNUFrNS9EWGVB?=
 =?utf-8?B?ZHVQNktLeWNITytCWVFrdnJqNVNTcHVLckhJTk1pZUMrTVUvYjhvdkZJY1lV?=
 =?utf-8?B?YzZWcFlFK0hVMktldVRXRlpsZ2Z1b1B6WW5tWEtSZjlGTjdPZVpaMUY1NnR1?=
 =?utf-8?B?OTNaYi9qNlFHcXR5RUZncWkyWXNKc3NCWnF3UXdDY2trTjg0b0FJRW85ay9H?=
 =?utf-8?B?RVR3VnpZTnNzTzFsUXhEcTBPSTJDdUlUZEJobTJOajBEREd2RysyTk8xZFVp?=
 =?utf-8?B?ZlhDV0FlNlM5c1duMmJrMUIzUHBRTldIeS93V1o4dlB5Wnlicnlzc01SNlNH?=
 =?utf-8?B?M2ZhYkVpTUU4M2IwZW9pZGxONEozTWxaN1VUN0hzZFJJZTNlUmhWZ1BtbGZk?=
 =?utf-8?B?ZTExWCt3YnUyOXBXYk9WMGFLTzVGclk3WUNwN0haRzRTd3NudWEvTVh0ZDZh?=
 =?utf-8?B?eHloekVoSUsxZUx3M1NsMHNPZkZKQ0pEZGhER2liY2gxY0ppNm54UGdHYlcz?=
 =?utf-8?B?M3JJVkN6OFpMZVNRa3F4aTZ6d24yNlhjamNOdndjallkTkhvRXJDMHJDTkxm?=
 =?utf-8?B?SGZWdWxBcVkvYzdZb3Q3Y0JaMHZIUWFFWUU4YU0xVGxCbVBNYTlsam5LNEFj?=
 =?utf-8?B?V052V0FYTDJIY0tad2luZ3NiQkF1YUlQak5WWW5TRUthTC9OSnR6U1ZGZWhU?=
 =?utf-8?B?dFhyZ1BuWmRtVjh6b1o5SXNtWWFEZDFqRVFVVkhVbWx6cmdIVG9GcnN5M2c0?=
 =?utf-8?B?eTJhYUozSEdUMjBFMEZBVklCTzJNTjJMbHJOeHlYSVU5akdPdXEya1kzVEkr?=
 =?utf-8?B?bVVNSnhVM01WcDhZdUZtcGtvVVF0TGw0T0J0aHM3d3ljNU1Kd2hJeWdQenQ0?=
 =?utf-8?B?UWFBdjNBYkcyRTJsZVN3dDgvQkNaM05UR0o1ejVtNXk4SE5Ga2R3M1o3WGs0?=
 =?utf-8?B?UDNzSjl4cXFsSmpORnpjVnhDQ0x0MU1KT2JpUzlMc3pLbytoTkJqeDVXSWtG?=
 =?utf-8?B?UjBNYzl6bHFXdmN0Q081R0c2Y3BuQm9rYUJBYVA1cHRMelNTeUNKREVsYW1y?=
 =?utf-8?B?bGNOMy9NdGszV3ZJNnhXTWo1QXNTQ1R1QUt6K1hZOXFoNU5HdWNERGkrclVo?=
 =?utf-8?B?VDdYL3VRdXRvaUZNYXcyak1aK25ERnk2cHhrQjB4SlZnZzJOSUh6UzErdjBa?=
 =?utf-8?B?MkpNc1VJUEREajhOdyt3Z2JVUnZZU2pCWUdYZDkrYmlzQUhFZVh3QTRNVTNv?=
 =?utf-8?B?V3VvZ0tYMThUVUgzRTR1ODNOYm0xb1Y1VnhEbFR6dFlzTGk4eHpXdTBWeXNz?=
 =?utf-8?B?cmdPUWRqTW1sVUZxY241dzZtQ3lKR2hvVlIvNTdVckpBSmxaQzc1cWtHczlp?=
 =?utf-8?B?eG1QODVJN2JzTE9vcjBMbTlvZUFqNG9YcnFyeVl6UXNSaUNFMXg4R2tubzBZ?=
 =?utf-8?B?TGVHdjVmQkprL1pyOG1LOVRWdnVIMG82UzVTSllla0dGOU5BdThITmQrSkFi?=
 =?utf-8?B?cTltMXlFOXY3dTh2U3RHeWMyTFZWQThaV1Bydm1KVDRzM2RpSXdNenArd0xm?=
 =?utf-8?B?cUlkMlNVZmtRaXp1TndzSFM5ekVBSHU1aFEvcnFZTXU5VithUEIreHJ3R0Uy?=
 =?utf-8?B?ZG5hSmt0M3dFaUQvMlhkczJVcmExSnRGNDNEUm13MDZxMitRY2h4eUJrNlgw?=
 =?utf-8?Q?hL3woe2edtQCoYlUZaxiBRMPk?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82b6f227-cc92-474e-90ca-08dc6b1def9f
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 03:05:49.9691
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yG8ZZtxAviabZeauBkmrw/BPU3yZ5qUYnDqozJFdwdEr8VgFXAa3pKE1upNGSAJXr3l6LZzvxSh6Wlj7ejYTQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7152

On Thu, May 02, 2024 at 08:01:37PM -0300, Fabio Estevam wrote:
> Hi Christian,
> 
> On Thu, May 2, 2024 at 6:58 PM Christian Gmeiner
> <christian.gmeiner@gmail.com> wrote:
> >
> > From: Christian Gmeiner <cgmeiner@igalia.com>
> >
> > Add the DT node for the GPU core found on the i.MX8QM.
> >
> > etnaviv-gpu 53100000.gpu: model: GC7000, revision: 6009
> > [drm] Initialized etnaviv 1.4.0 20151214 for etnaviv on minor 0
> >
> > Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8qm.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > index b3d01677b70c..54879ae1d7d5 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > @@ -467,6 +467,7 @@ drc_crit0: trip1 {
> >         #include "imx8-ss-dma.dtsi"
> >         #include "imx8-ss-conn.dtsi"
> >         #include "imx8-ss-lsio.dtsi"
> > +       #include "imx8-ss-gpu0.dtsi"
> 
> Nit: better put it in alphabetical order.

No, it should be order by subsystem register address. gpu is 53100000.
should be between imx8-ss-vpu and imx8-ss-img. 

Frank

> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>