Received-SPF: pass (google.com: domain of linux-kernel+bounces-167213-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240502185819.788716-1-andreas@kemnade.info> <20240502185819.788716-3-andreas@kemnade.info>
 <CAHp75Vd1A8sy2Oky9TENUTAj0SCCyVQ8Zh49AN3X7t9cK2F+iw@mail.gmail.com> <ZjQdWdpmqoXhJeek@google.com>
In-Reply-To: <ZjQdWdpmqoXhJeek@google.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Fri, 3 May 2024 06:37:22 +0300
Message-ID: <CAHp75VcyRiE3+CnZo4VbXWYFQ8f_N9zhp7gmEqBHEMQ9rEn2Fw@mail.gmail.com>
Subject: Re: [PATCH 2/2] Input: ektf2127 - add ektf2232 support
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Andreas Kemnade <andreas@kemnade.info>, robh@kernel.org, krzk+dt@kernel.org, 
	conor+dt@kernel.org, hdegoede@redhat.com, u.kleine-koenig@pengutronix.de, 
	siebren.vroegindeweij@hotmail.com, linux-input@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, May 3, 2024 at 2:10=E2=80=AFAM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Thu, May 02, 2024 at 10:16:01PM +0300, Andy Shevchenko wrote:
> > On Thu, May 2, 2024 at 9:58=E2=80=AFPM Andreas Kemnade <andreas@kemnade=
info> wrote:

..

> > > +       if (ts->shifted_status) {
>
> Instead of the flag I think it would be better if you had
> ts->status_shift and did
>
>                 status =3D buf[7] >> ts->status_shift;
>                 ektf2127_report2_contact(ts, 0, &buf[1], status & BIT(0))=
;
>                 ektf2127_report2_contact(ts, 1, &buf[4], status & BIT(1))=
;
>
> > > +               ektf2127_report2_contact(ts, 0, &buf[1], !!(buf[7] & =
1));
> > > +               ektf2127_report2_contact(ts, 1, &buf[4], !!(buf[7] & =
2));
> >
> > BIT(0)
> > BIT(1)
> >
> > > +       } else {
> > > +               ektf2127_report2_contact(ts, 0, &buf[1], !!(buf[7] & =
2));
> > > +               ektf2127_report2_contact(ts, 1, &buf[4], !!(buf[7] & =
4));
> >
> > BIT(1)
> > BIT(2)
> >
> > > +       }

..

> > > +       if (dev->of_node &&
> > > +           of_device_is_compatible(dev->of_node, "elan,ektf2232"))
> >
> > if (device_is_compatible(...))
>
> Actually I think this better come from data obtained via
> device_get_match_data().
>
> > > +               ts->shifted_status =3D true;

I agree with your comments. Hopefully the author as well.

--=20
With Best Regards,
Andy Shevchenko