Received-SPF: pass (google.com: domain of linux-kernel+bounces-167290-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 3 May 2024 08:57:40 +0200
From: Jean Delvare <jdelvare@suse.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Next
 Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the dmi tree
Message-ID: <20240503085740.478d564b@endymion.delvare>
In-Reply-To: <20240430165017.4fa14188@canb.auug.org.au>
References: <20240430114613.0cef65fc@canb.auug.org.au>
	<20240430165017.4fa14188@canb.auug.org.au>
Organization: SUSE Linux
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi Stephen,

On Tue, 30 Apr 2024 16:50:17 +1000, Stephen Rothwell wrote:
> On Tue, 30 Apr 2024 11:46:13 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > After merging the dmi tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> > 
> > In file included from include/asm-generic/bug.h:22,
> >                  from arch/arm/include/asm/bug.h:60,
> >                  from include/linux/bug.h:5,
> >                  from include/linux/thread_info.h:13,
> >                  from include/asm-generic/preempt.h:5,
> >                  from ./arch/arm/include/generated/asm/preempt.h:1,
> >                  from include/linux/preempt.h:79,
> >                  from include/linux/spinlock.h:56,
> >                  from include/linux/mmzone.h:8,
> >                  from include/linux/gfp.h:7,
> >                  from include/linux/umh.h:4,
> >                  from include/linux/kmod.h:9,
> >                  from include/linux/module.h:17,
> >                  from drivers/firmware/dmi_scan.c:5:
> > drivers/firmware/dmi_scan.c: In function 'dmi_decode_table':
> > include/linux/kern_levels.h:5:25: warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'int' [-Wformat=]
> >     5 | #define KERN_SOH        "\001"          /* ASCII Start Of Header */
> >       |                         ^~~~~~
> > include/linux/printk.h:429:25: note: in definition of macro 'printk_index_wrap'
> >   429 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
> >       |                         ^~~~
> > include/linux/printk.h:510:9: note: in expansion of macro 'printk'
> >   510 |         printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
> >       |         ^~~~~~
> > include/linux/kern_levels.h:12:25: note: in expansion of macro 'KERN_SOH'
> >    12 | #define KERN_WARNING    KERN_SOH "4"    /* warning conditions */
> >       |                         ^~~~~~~~
> > include/linux/printk.h:510:16: note: in expansion of macro 'KERN_WARNING'
> >   510 |         printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
> >       |                ^~~~~~~~~~~~
> > drivers/firmware/dmi_scan.c:109:25: note: in expansion of macro 'pr_warn'
> >   109 |                         pr_warn(FW_BUG
> >       |                         ^~~~~~~
> > 
> > Introduced by commit
> > 
> >   868577e6bfe1 ("firmware: dmi: Stop decoding on broken entry")
> > 
> > Include printk.h?  
> 
> This caused i386 defconfig build fail, so I have reverted this commit
> for today.

Sorry about that. I have amended the commit to use format %zd instead
of %ld. This passes my local user-space testing so hopefully it will
fix the i386 and armv7 builds as well.

-- 
Jean Delvare
SUSE L3 Support