Received-SPF: pass (google.com: domain of linux-kernel+bounces-167316-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <2286c7cd-6510-407a-817a-8d964b158c4c@gmail.com>
Date: Fri, 3 May 2024 10:25:26 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 1/6] dt-bindings: ROHM BD96801 PMIC regulators
Content-Language: en-US, en-GB
From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Conor Dooley <conor@kernel.org>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
 Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
 Mark Brown <broonie@kernel.org>, Wim Van Sebroeck <wim@linux-watchdog.org>,
 Guenter Roeck <linux@roeck-us.net>, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
References: <cover.1714478142.git.mazziesaccount@gmail.com>
 <c747a3395a52bdb9b9697f814cd781fb0903b894.1714478142.git.mazziesaccount@gmail.com>
 <20240502-vitalize-oat-ecbc14647df8@spud>
 <74655775-a8e2-45f4-8a1b-8046dffa5520@gmail.com>
In-Reply-To: <74655775-a8e2-45f4-8a1b-8046dffa5520@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 5/3/24 07:54, Matti Vaittinen wrote:
> Hi Conor,
> 
> On 5/2/24 19:20, Conor Dooley wrote:
>> On Tue, Apr 30, 2024 at 02:59:50PM +0300, Matti Vaittinen wrote:
>>
>> Krzysztof had some comments on the buck/ldo node names
> 
> I think Krzysztof pointed out that the regulator-name property should 
> not match the data-sheet but the board. If he had something to say about 
> the node names, then I've missed his comment!
> 
>> and on the
>> initial value properties that I'm not sure if have been addressed, so
>> gonna leave this series to him.
> 
> Thanks for pointing out I may have missed addressing some of his 
> concerns. I though I fixed all issues he pointed to me but it may be I 
> missed some - or accidentally dropped some change(s) when merging fixes 
> from the 'experimental' branch to the 'simple'. I'll revise Krzysztof's 
> feedback to the RFC before sending the next version!

You were right Conor. I checked it and yes, I omitted a few of the fixes 
to regulator bindings. Please skip reviewing this version of these 
bindings, I'll handle the rest of the comments in next one!

Yours,
	-- Matti


-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~