Received-SPF: pass (google.com: domain of linux-kernel+bounces-167311-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 3 May 2024 08:20:29 +0100
From: Lee Jones <lee@kernel.org>
To: =?iso-8859-1?Q?Andr=E9?= Apitzsch <git@apitzsch.eu>
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] leds: sy7802: Add support for Silergy SY7802
 flash LED controller
Message-ID: <20240503072029.GE1227636@google.com>
References: <20240401-sy7802-v2-0-1138190a7448@apitzsch.eu>
 <20240401-sy7802-v2-2-1138190a7448@apitzsch.eu>
 <20240411124855.GJ1980182@google.com>
 <c5e5f49295350ada2cdb280a77b1c877058d4d64.camel@apitzsch.eu>
 <20240502091017.GF5338@google.com>
 <9bb6ef63e19bf079fd881a3b78b71d7a00e4a3bb.camel@apitzsch.eu>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9bb6ef63e19bf079fd881a3b78b71d7a00e4a3bb.camel@apitzsch.eu>

On Thu, 02 May 2024, André Apitzsch wrote:

> Am Donnerstag, dem 02.05.2024 um 10:10 +0100 schrieb Lee Jones:
> > On Wed, 01 May 2024, André Apitzsch wrote:
> > 
> > > > > +		ret = -EBUSY;
> > > > > +		goto unlock;
> > > > > +	}
> > > > > +
> > > > > +	if (level)
> > > > > +		curr = chip->fled_torch_used | BIT(led-
> > > > > >led_no);
> > > > > +	else
> > > > > +		curr = chip->fled_torch_used & ~BIT(led-
> > > > > >led_no);
> > > > > +
> > > > > +	if (curr)
> > > > > +		val |= SY7802_MODE_TORCH;
> > > > > +
> > > > > +	/* Torch needs to be disabled first to apply new
> > > > > brightness */
> > > > 
> > > > "Disable touch to apply brightness"
> > > > 
> > > > > +	ret = regmap_update_bits(chip->regmap,
> > > > > SY7802_REG_ENABLE,
> > > > > SY7802_MODE_MASK,
> > > > > +				 SY7802_MODE_OFF);
> > > > > +	if (ret)
> > > > > +		goto unlock;
> > > > > +
> > > > > +	mask = led->led_no == SY7802_LED_JOINT ?
> > > > > SY7802_TORCH_CURRENT_MASK_ALL :
> > > > 
> > > > Why not just use led->led_no in place of mask?
> > > 
> > > I might be missing something, but I don't know how to use led-
> > > >led_no
> > > in place of mask, when
> > > led->led_no is in {0,1,2} and
> > > mask is in {0x07, 0x38, 0x3f}.
> > 
> > This doesn't make much sense.
> > 
> > I guess you mean that led_no is a u8 and mask is a u32.
> > 
> > What happens if you cast led_no to u32 in the call to
> > regmap_update_bits()?
> 
> Sorry, I'm still confused. Could you elaborate your original question?

Replied where there is still context.

-- 
Lee Jones [李琼斯]