Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757365AbYA2Mnd (ORCPT ); Tue, 29 Jan 2008 07:43:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754365AbYA2MnY (ORCPT ); Tue, 29 Jan 2008 07:43:24 -0500 Received: from hp3.statik.tu-cottbus.de ([141.43.120.68]:35543 "EHLO hp3.statik.tu-cottbus.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754278AbYA2MnX (ORCPT ); Tue, 29 Jan 2008 07:43:23 -0500 Message-ID: <479F1F69.5000206@s5r6.in-berlin.de> Date: Tue, 29 Jan 2008 13:43:21 +0100 From: Stefan Richter User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.11) Gecko/20071128 SeaMonkey/1.1.7 MIME-Version: 1.0 To: Willy Tarreau CC: Paolo Ciarrocchi , Ingo Molnar , Linux Kernel Subject: Re: [PATCH 3/7] X86: Fix trailing statements should be on next line References: <20080129000744.698639d3@paolo-desktop> <20080128230746.GL8953@1wt.eu> In-Reply-To: <20080128230746.GL8953@1wt.eu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 921 Lines: 27 Willy Tarreau wrote: > Hi Paolo, > > On Tue, Jan 29, 2008 at 12:07:44AM +0100, Paolo Ciarrocchi wrote: >> Fix trailing statements should be on next line > >> -if ( partial_status & SW_C3 ) printk("SW: condition bit 3\n"); ... >> +if ( partial_status & SW_Backward ) >> +printk("SW: backward compatibility\n"); ... > > Well, IMHO, the code was more readable and checkable in the initial > version. I think this is one example of exceptions where code appearance > is more important than style correctness. Besides, the proposed style "fix" itself violates CodingStyle in at least two obvious ways. -- Stefan Richter -=====-==--- ---= ===-= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/