Received-SPF: pass (google.com: domain of linux-kernel+bounces-167490-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240503-imx95-dts-v3-v4-0-535ddc2bde73@nxp.com> <20240503-imx95-dts-v3-v4-3-535ddc2bde73@nxp.com>
In-Reply-To: <20240503-imx95-dts-v3-v4-3-535ddc2bde73@nxp.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Fri, 3 May 2024 06:53:58 -0300
Message-ID: <CAOMZO5D9i8LG7-4X6D+oHfZrJj+QoKa0DTusMX-H32227_s_4Q@mail.gmail.com>
Subject: Re: [PATCH v4 3/3] arm64: dts: freescale: add i.MX95 19x19 EVK
 minimal board dts
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, 
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, 
	Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, 
	linux-arm-kernel@lists.infradead.org, 
	Alexander Stein <alexander.stein@ew.tq-group.com>, Peng Fan <peng.fan@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Peng,

On Thu, May 2, 2024 at 10:29=E2=80=AFPM Peng Fan (OSS) <peng.fan@oss.nxp.co=
m> wrote:

> +       aliases {
> +               gpio0 =3D &gpio1;
> +               gpio1 =3D &gpio2;
> +               gpio2 =3D &gpio3;
> +               gpio3 =3D &gpio4;
> +               gpio4 =3D &gpio5;
> +               i2c0 =3D &lpi2c1;
> +               i2c1 =3D &lpi2c2;
> +               i2c2 =3D &lpi2c3;
> +               i2c3 =3D &lpi2c4;
> +               i2c4 =3D &lpi2c5;
> +               i2c5 =3D &lpi2c6;
> +               i2c6 =3D &lpi2c7;
> +               i2c7 =3D &lpi2c8;
> +               mmc0 =3D &usdhc1;
> +               mmc1 =3D &usdhc2;
> +               mmc2 =3D &usdhc3;
> +               serial0 =3D &lpuart1;
> +               serial1 =3D &lpuart2;
> +               serial2 =3D &lpuart3;
> +               serial3 =3D &lpuart4;
> +               serial4 =3D &lpuart5;
> +               serial5 =3D &lpuart6;
> +               serial6 =3D &lpuart7;
> +               serial7 =3D &lpuart8;
> +       };

This looks like an excessive aliases list.
Can't you just have serial0, mmc0, and mmc1 instead?

> +       reg_1p8v: regulator-1p8v {
> +               compatible =3D "regulator-fixed";
> +               regulator-max-microvolt =3D <1800000>;
> +               regulator-min-microvolt =3D <1800000>;
> +               regulator-name =3D "+V1.8_SW";
> +       };
> +
> +       reg_3p3v: regulator-3p3v {
> +               compatible =3D "regulator-fixed";
> +               regulator-max-microvolt =3D <3300000>;
> +               regulator-min-microvolt =3D <3300000>;
> +               regulator-name =3D "+V3.3_SW";
> +       };
> +
> +       reg_vref_1v8: regulator-adc-vref {
> +               compatible =3D "regulator-fixed";
> +               regulator-name =3D "vref_1v8";
> +               regulator-min-microvolt =3D <1800000>;
> +               regulator-max-microvolt =3D <1800000>;
> +       };

These regulators are not used anywhere.

Please add them when they have consumers for them.