Received-SPF: pass (google.com: domain of linux-kernel+bounces-167516-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Justin Lai <justinlai0215@realtek.com>
To: Simon Horman <horms@kernel.org>
CC: "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net"
	<davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "jiri@resnulli.us" <jiri@resnulli.us>,
        Ping-Ke Shih <pkshih@realtek.com>, Larry Chiu <larry.chiu@realtek.com>
Subject: RE: [PATCH net-next v17 02/13] rtase: Implement the .ndo_open function
Thread-Topic: [PATCH net-next v17 02/13] rtase: Implement the .ndo_open
 function
Thread-Index: AQHanHHZpNHx0voP+0CDD26jysJVP7GEr5aAgACdBfA=
Date: Fri, 3 May 2024 10:19:05 +0000
Message-ID: <3199bfed19ad4e0bb8ca868b6c46588a@realtek.com>
References: <20240502091847.65181-1-justinlai0215@realtek.com>
 <20240502091847.65181-3-justinlai0215@realtek.com>
 <20240503085257.GM2821784@kernel.org>
In-Reply-To: <20240503085257.GM2821784@kernel.org>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

> On Thu, May 02, 2024 at 05:18:36PM +0800, Justin Lai wrote:
> > Implement the .ndo_open function to set default hardware settings and
> > initialize the descriptor ring and interrupts. Among them, when
> > requesting irq, because the first group of interrupts needs to process
> > more events, the overall structure will be different from other groups
> > of interrupts, so it needs to be processed separately.
> >
> > Signed-off-by: Justin Lai <justinlai0215@realtek.com>
>=20
> Hi Justin,
>=20
> some minor feedback from my side.
>=20
> > +static int rtase_open(struct net_device *dev) {
> > +     struct rtase_private *tp =3D netdev_priv(dev);
> > +     struct rtase_int_vector *ivec =3D &tp->int_vector[0];
> > +     const struct pci_dev *pdev =3D tp->pdev;
> > +     u16 i, j;
> > +     int ret;
>=20
> nit: please use reverse xmas tree order - longest line to shortest -
>      for local variable declarations in new Networking code.
>=20
Hi Simon,
This is partly because ivec needs to use tp for initialization,
so tp is placed in front of ivec, causing this situation.