Received-SPF: pass (google.com: domain of linux-kernel+bounces-167534-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <6ea936b8-b036-467b-8186-f461b7eea5e1@nvidia.com>
Date: Fri, 3 May 2024 18:47:56 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] selftest: rtc: Add support rtc alarm content check
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: shuah@kernel.org, avagin@google.com, amir73il@gmail.com,
 brauner@kernel.org, mochs@nvidia.com, linux-kernel@vger.kernel.org,
 linux-rtc@vger.kernel.org, linux-kselftest@vger.kernel.org,
 sdonthineni@nvidia.com, treding@nvidia.com, linux-tegra@vger.kernel.org
References: <20240503014102.3568130-1-jjang@nvidia.com>
 <20240503014102.3568130-2-jjang@nvidia.com>
 <202405030649157e9de2ac@mail.local>
Content-Language: en-US
From: Joseph Jang <jjang@nvidia.com>
In-Reply-To: <202405030649157e9de2ac@mail.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ajN4aVRhenp0MFJNdGU0NWlPQlpDVVVxTC81d0NqQ24wSGw3cENMdVBTL28x?=
 =?utf-8?B?a09QTlhCdmFBY0FBSmU0b05QUzB5M2NJaTc3bVJ4L21VdXNZUTJ4VURsZ0JX?=
 =?utf-8?B?YVRBZDJySXlLOCt0STh3SUpLdUZKVVZ6eW9uNHVmMDdvL2JacFpDVjNmQkNx?=
 =?utf-8?B?R3ZzK1pEOHl2Z0E1WEUvSnNsZXFyS1ZMRWJqYmIvQlZibFcydnArWVlOL3hC?=
 =?utf-8?B?UDNqZG9BamMzWDh1bmFiUWtrMjFHR2NhbUxVMk9wRk1Oa2V6a0pwZjBnaCti?=
 =?utf-8?B?bVVqaWhMWTZrLzRwSmZSMkpIVjFMaktJczEydWxuSEtpaGUxNHYrL2JyT2dX?=
 =?utf-8?B?VE54bk5ta0xMUkVseU9nWDdtRjk3dUNadEtGYzltQ2lrQmh5bi9IRk1SSTVp?=
 =?utf-8?B?MU1xcm90WXJyaTIyMnNha2o4b1daRmE0dEpLemxHN3RDbnNzUnpWdU9ISUY2?=
 =?utf-8?B?S25qNUZocU1mdHc2cUNCNlErUkdwRktkTnBUTHJnSEViSDdOYkQ4TnBVZWlu?=
 =?utf-8?B?YlFXc212TTNvaHNpWll3T2syNW8wTzZjOStwSWJxZ3NsYVUvN3QzU3NXNVo4?=
 =?utf-8?B?Rm1obzZUdHdEQ3BlcTlWRncyM2IxWGYwdmZKZGJqcCtaWi8vdk9wMmtURmpm?=
 =?utf-8?B?UXJjdU9mTzA5VFM4R1NsOUlid0ZnZDQzNzVtamN2V0cvc2pTbEdPMVMyK00v?=
 =?utf-8?B?VTZ4TlM4a0ZXVjJ3RmJVTGJuZHExMFc4b1hMbk1RZFB4NmY0bTIrNFVxSWx3?=
 =?utf-8?B?alZ0eXdFZzlmZDVIb2x3YVhDRTZpeGV6WWU4M3V0WHhHWGU1RllHMTZhRzRs?=
 =?utf-8?B?d1dUcWFBYUpFVnZKQXRFNUlKUTltcEJuVG1XN1l5dTh4Q2tBeEpFVlpJY2dn?=
 =?utf-8?B?ZlhyUzQwZDRVT0tyc0VKRW9la0dkNG52eXEwWnNUUkpwaVlWTTA0YXVjVDQx?=
 =?utf-8?B?bVVoSGJ6dXExWERkTStlZzZueCtJTzlhejBMa1QrL2dpYTFMcGIwNU9zNlYr?=
 =?utf-8?B?SEJGb2xBTk1Ob20rQkliOGIrc3BVdlhIbVN1NzArb0UvcDFoQy9pbmlnM1lq?=
 =?utf-8?B?cktuR2dUajdjcFJhRmdCSWw5QlZpcUVKZ1dzTHZkVTF6Ky96L1pxRFZjRVVD?=
 =?utf-8?B?RXZEL20va2tBUDFLMHl2L1ZNWHlEWmJkb1RzUGxIbzRyT2RjYmI5T1lTK09W?=
 =?utf-8?B?QWNoTUtwTWxwdDBGQ1dET2hXaVJlN2JJWGN2MVJWQjRFRDd1KzRTWlY0YUpL?=
 =?utf-8?B?ODVxdlV1TDhZa1RURmMvWnAyMXNQajBMeGlDNEdyNTdoU0hYZk00eUFSUnhv?=
 =?utf-8?B?MnZONDBub3k0TUVoMTBzb0pxYm90ZDBvYld2R3BXNkJzaHVnbDJFUnpBWllE?=
 =?utf-8?B?YkdoQkNXd2dIV3RaTERKemMzcUJxWXYxSGIxSm9keE5ieTRsTDlvUitBL3VK?=
 =?utf-8?B?V0tYSnQrRERXZDBkdXFHckw2WGpzVlBrZEIxTTc5ZGJ6UlNuZGxqR0pqZ050?=
 =?utf-8?B?emJDaEZaWG00YjRBWEU2VjFXTkVhZVMyc0gvRmRmN2VGZGYzd2pNcVNpZTJ3?=
 =?utf-8?B?YUc3Nkg2Ry8yMkVHemYyNnErT1ExVS8rUEpoamRtNitnSFFXdHM4ODBkQlQx?=
 =?utf-8?B?V2VkTGlHVkwrZWVRcXZnUW56d0lvOUxsQmNDaFAraTFPLzUzMGxmbDZQcVdv?=
 =?utf-8?B?Tlgwa1ppcmk3dGFaMk12Y3FERlNsQ055dCtoaUVGWmF3OHJ5aVlpeGlCbmgz?=
 =?utf-8?B?L2NldW01dGthS1VvSXduNzJQSTUrRGFGZXFKTmN2eGJVQkZRU1lReGRkMmkw?=
 =?utf-8?B?Qm9FUmdzK3hiZjJCMUxGdDdhSUxhSFlnVnVqMmNOU1JEZEFJcWc0NWlSUVlB?=
 =?utf-8?B?MlRSeHJXL0ovWVhjQWx3QXM2RS9WZC9OZnZOTkZQcEExbStzNlBWa2tobEFE?=
 =?utf-8?B?UVJidkN6eERpdW4vQlpDZHp0b0lMMEJ5d2xKVlZ3Z2JtcWkxa29KL2w2dXRv?=
 =?utf-8?B?YVZOcGlyWlBIWmdORlBVa2ZmdzhPNUpmdXdUMU9sSHFoNnBtYjhuM25MRnhT?=
 =?utf-8?B?ODEwK0dDNU1MaGRtY2NJR3dtUUFSTFBnekFYVTIxR0tla2dGOHNMWDB3Z28y?=
 =?utf-8?Q?Csrhmx+5CrTSt+W19bV7bMbBN?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9dfb0400-fce3-4db6-ffb9-08dc6b5e8294
X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 10:48:04.5165
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fa8FM39F/abSh5+h9IFmFbh7ibGKExq5qaPc48+9qDKEbgBHBslG8ejdsccZO7H0FNzThGCMRzTlYASC/Ak7vA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7506


On 2024/5/3 2:49 PM, Alexandre Belloni wrote:
> On 02/05/2024 18:41:02-0700, Joseph Jang wrote:
>> Some platforms do not support WAKEUP service by default, we use a shell
>> script to check the absence of alarm content in /proc/driver/rtc.
> 
> procfs for the RTC has been deprecated for a while, don't use it.
> 
> Instead, you can use the RTC_PARAM_GET ioctl to get RTC_PARAM_FEATURES
> and then look at RTC_FEATURE_ALARM.
> See https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/rtc-tools.git/tree/rtc.c
>

I found old version kernel doesn't support RTC_PARAM_GET ioctl. In order 
support old version kernel testing, is it possible to use rtc procfs to 
validate wakealarm function for old version kernel ?

Can I move this rtc alarm validation to 
<linux_root>/tools/testing/selftests/rtc/rtctest.c ? So we could try to 
use RTC_PARAM_GET ioctl
first and then roll back to use rtc procfs if RTC_PARAM_GET ioctl was 
not supported.

Thank you,
Joseph.

>>
>> The script will validate /proc/driver/rtc when it is not empty and then
>> check if could find alarm content in it according to the rtc wakealarm
>> is supported or not.
>>
>> Requires commit 101ca8d05913b ("rtc: efi: Enable SET/GET WAKEUP services
>> as optional")
>>
>> Reviewed-by: Matthew R. Ochs <mochs@nvidia.com>
>> Signed-off-by: Joseph Jang <jjang@nvidia.com>
>> ---
>>   tools/testing/selftests/Makefile              |  1 +
>>   tools/testing/selftests/rtc/property/Makefile |  5 ++++
>>   .../selftests/rtc/property/rtc-alarm-test.sh  | 27 +++++++++++++++++++
>>   3 files changed, 33 insertions(+)
>>   create mode 100644 tools/testing/selftests/rtc/property/Makefile
>>   create mode 100755 tools/testing/selftests/rtc/property/rtc-alarm-test.sh
>>
>> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
>> index e1504833654d..f5d43e2132e8 100644
>> --- a/tools/testing/selftests/Makefile
>> +++ b/tools/testing/selftests/Makefile
>> @@ -80,6 +80,7 @@ TARGETS += riscv
>>   TARGETS += rlimits
>>   TARGETS += rseq
>>   TARGETS += rtc
>> +TARGETS += rtc/property
>>   TARGETS += rust
>>   TARGETS += seccomp
>>   TARGETS += sgx
>> diff --git a/tools/testing/selftests/rtc/property/Makefile b/tools/testing/selftests/rtc/property/Makefile
>> new file mode 100644
>> index 000000000000..c6f7aa4f0e29
>> --- /dev/null
>> +++ b/tools/testing/selftests/rtc/property/Makefile
>> @@ -0,0 +1,5 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +TEST_PROGS := rtc-alarm-test.sh
>> +
>> +include ../../lib.mk
>> +
>> diff --git a/tools/testing/selftests/rtc/property/rtc-alarm-test.sh b/tools/testing/selftests/rtc/property/rtc-alarm-test.sh
>> new file mode 100755
>> index 000000000000..3bee1dd5fbd0
>> --- /dev/null
>> +++ b/tools/testing/selftests/rtc/property/rtc-alarm-test.sh
>> @@ -0,0 +1,27 @@
>> +#!/bin/bash
>> +# SPDX-License-Identifier: GPL-2.0
>> +
>> +if [ ! -f /proc/driver/rtc ]; then
>> +	echo "SKIP: the /proc/driver/rtc is empty."
>> +	exit 4
>> +fi
>> +
>> +# Check if could find alarm content in /proc/driver/rtc according to
>> +# the rtc wakealarm is supported or not.
>> +if [ -n "$(ls /sys/class/rtc/rtc* | grep -i wakealarm)" ]; then
>> +	if [ -n "$(grep -i alarm /proc/driver/rtc)" ]; then
>> +		exit 0
>> +	else
>> +		echo "ERROR: The alarm content is not found."
>> +		cat /proc/driver/rtc
>> +		exit 1
>> +	fi
>> +else
>> +	if [ -n "$(grep -i alarm /proc/driver/rtc)" ]; then
>> +		echo "ERROR: The alarm content is found."
>> +		cat /proc/driver/rtc
>> +		exit 1
>> +	else
>> +		exit 0
>> +	fi
>> +fi
>> -- 
>> 2.34.1
>>
>