Received-SPF: pass (google.com: domain of linux-kernel+bounces-167558-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <5f90431c-f27d-4b59-bf5a-32fd66101230@arm.com>
Date: Fri, 3 May 2024 12:00:08 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 1/1] selftest mm/mseal: fix arm build
Content-Language: en-GB
To: jeffxu@chromium.org, Aishwarya TCV <Aishwarya.TCV@arm.com>
Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, corbet@lwn.net,
 dave.hansen@intel.com, deraadt@openbsd.org, gregkh@linuxfoundation.org,
 groeck@chromium.org, jannh@google.com, jeffxu@google.com,
 jorgelo@chromium.org, keescook@chromium.org,
 linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-kselftest@vger.kernel.org, linux-mm@kvack.org, merimus@google.com,
 pedro.falcato@gmail.com, rdunlap@infradead.org, sroettger@google.com,
 surenb@google.com, torvalds@linux-foundation.org, usama.anjum@collabora.com,
 willy@infradead.org
References: <20240502225331.3806279-1-jeffxu@chromium.org>
 <20240502225331.3806279-2-jeffxu@chromium.org>
From: Ryan Roberts <ryan.roberts@arm.com>
In-Reply-To: <20240502225331.3806279-2-jeffxu@chromium.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 02/05/2024 23:53, jeffxu@chromium.org wrote:
> From: Jeff Xu <jeffxu@chromium.org>
> 
> add include linux/mman.h to fix arm build
> fix a typo
> 
> Signed-off-by: Jeff Xu <jeffxu@chromium.org>
> Suggested-by: Ryan Roberts <ryan.roberts@arm.com>

I confirm this has fixed our issue. Thanks!

Tested-by: Ryan Roberts <ryan.roberts@arm.com>
Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>

> ---
>  tools/testing/selftests/mm/mseal_test.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
> index ca8dbee0c612..41998cf1dcf5 100644
> --- a/tools/testing/selftests/mm/mseal_test.c
> +++ b/tools/testing/selftests/mm/mseal_test.c
> @@ -1,5 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  #define _GNU_SOURCE
> +#include <linux/mman.h>
>  #include <sys/mman.h>
>  #include <stdint.h>
>  #include <unistd.h>
> @@ -29,7 +30,7 @@
>  # define PKEY_DISABLE_WRITE     0x2
>  #endif
>  
> -#ifndef PKEY_BITS_PER_KEY
> +#ifndef PKEY_BITS_PER_PKEY
>  #define PKEY_BITS_PER_PKEY      2
>  #endif
>