Received-SPF: pass (google.com: domain of linux-kernel+bounces-167576-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <a8f36d5a-a109-4683-abf1-47f8e7f8a7f0@nvidia.com>
Date: Fri, 3 May 2024 19:21:58 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] selftest: rtc: Add support rtc alarm content check
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: shuah@kernel.org, avagin@google.com, amir73il@gmail.com,
 brauner@kernel.org, mochs@nvidia.com, linux-kernel@vger.kernel.org,
 linux-rtc@vger.kernel.org, linux-kselftest@vger.kernel.org,
 sdonthineni@nvidia.com, treding@nvidia.com, linux-tegra@vger.kernel.org
References: <20240503014102.3568130-1-jjang@nvidia.com>
 <20240503014102.3568130-2-jjang@nvidia.com>
 <202405030649157e9de2ac@mail.local>
Content-Language: en-US
From: Joseph Jang <jjang@nvidia.com>
In-Reply-To: <202405030649157e9de2ac@mail.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UUhUVlJhQ253cUU4eTFYZ3pEY1o0eWVDY3BYZC9jMm1OVWJZYW14V0t2alBV?=
 =?utf-8?B?dFBwenpXVnpoS0kvMjIxVDhyVTh5a00vbzB3TVdTK3hjTG54bEpnTEpZLzJa?=
 =?utf-8?B?OFg2R1BVelU1cXFvbittNFdKWC9uSFJsL2hTSWUzalE3UEJ2MVFjcFR1TjRB?=
 =?utf-8?B?Y0ZWSVpETFBPTXlleVJsUVpMSzBNK1kvYmZXMXcwSFF4Q0JWYVhmUXBzbUd0?=
 =?utf-8?B?LysxK0gwN0orRW5pNjBKQ0I5Sm9XTnpaaml0WU5pR09EeGQ4dWFvV3lXNi8y?=
 =?utf-8?B?NE1nSWlDMkxLK21aYTdhMjJCOS9XalRqTWZvTFpUQkd4RkNQNnFiaC9FUTJW?=
 =?utf-8?B?ZzJreVNSc1RnTDRiYzhaRWVWdlVhVVFHNmFqanVxdmIzVDQrelNOTkhFY1FJ?=
 =?utf-8?B?bUVkZE93SmpGT2VlY2pOamp1UFhoNGxkSE1udEVLK3l3Y1dxNDhleUZod1ho?=
 =?utf-8?B?L2cvdno3S0pjOTFCTktITnpZRTJ1RENHVUhpWUVvaEgwcGs4bGxCNVY5Z0hl?=
 =?utf-8?B?SU5rR1BwODJoc1dFQ1lZY2hjbEtWeGF4bVpkTFFxajhtVmY4ZU52ai9zZ2xV?=
 =?utf-8?B?RmRsckJUOFlpSDA2MGlDMlk2Q3EvM1djZWY5ZGRmR0xncGdkdWhBek5EOEs5?=
 =?utf-8?B?cUlua1FlSDl5SzQxaytKc0hZRjQ2ZWF4ekorSFZXdnFBN3pOU1BFaE1rRWhM?=
 =?utf-8?B?SDU2aUVOOURsRVl6R1c3R21YTEMzT3RMTVcwdUhxZmpLK0hlRGJJNG1LYWdS?=
 =?utf-8?B?TUpuM1NuRXZpR25DUlhYczVZUldxVHpBTkRxbmlRYkRjRHdIb0ExLzNLN0hR?=
 =?utf-8?B?QnFWb0tmMWliaE1vYXpVdVg3SjFuTklMZ1NPbUQwOXVzSExwdEdzYzROUHdj?=
 =?utf-8?B?UnV5UFJxeGRZNFZQZ0tLNlQwQzVFQ0QybU9BK0FiM0pFUzRJcENOcnZITXAy?=
 =?utf-8?B?OHMxUWpwZUFYS2FSMkxFSWtMS2ZDbDJ6YUxuWi9DdWZNcG1hUEJ5ZWp5M0RX?=
 =?utf-8?B?V0tMZ1BHdURxcm1rb1o5N3lHcTZGdzlTWENCOEYxQlhQZmVBbTg0U0szRmJZ?=
 =?utf-8?B?UExnUzRwWXl5L1U3TWtKcjJYcEgwdStKN1NEZVRkRStEcHYwSi9CT1kreVZm?=
 =?utf-8?B?SmN4TnkzbUNPckFtSHZuNU9keVBtcjhoeHRtS2ovTmkvQXZoaTZZbkNnMG9Y?=
 =?utf-8?B?ZUlUbHl6MUNGeTg2c2JOV09jQVdiOVdhVEpaM2VpN084OGQwRDN1aTV0Y0Rp?=
 =?utf-8?B?VUwrblNkRE5td1prVkd3Z0l0UnltM1R4bmN1eFkvTXZ1U2ZjQS9MMGJIMFBV?=
 =?utf-8?B?Nk40Q3lRSlVId2liejhEK1doY0hTMk1rSk5iOXJ1TDVwVkNRTmtNMjlIbmJY?=
 =?utf-8?B?R3I0N3psMzE0OW1PRVhlL2ZWdUp4UXgvdC9jMUJIb1N0MGM0S3R4Vlhabm9M?=
 =?utf-8?B?UWRQU2ZyblJUTCswUE1ja1JTbTZ2Wnl6dDRDZ1dnaHFQWFlIU2NLUUhxOU9l?=
 =?utf-8?B?bC9mQUFCbGhsWFBCYWVnTkFPSWJmbnZiL1UvZk1IN2ZQM0FvUFpVdld5NXZK?=
 =?utf-8?B?cEFpQS8yc2t5empibVNQZWpoemgyZE9aaVlDUm80OWEzS3BDK1pNclEvRDA0?=
 =?utf-8?B?SmM1K25wY21ucm0yeGMwSXN1eUJ6cFl2WDZGekQ0SlZ0dU4zR05ZaVZNZ3Bq?=
 =?utf-8?B?U0tIT2ltQUkxQ3FTVnh5dWxDSEYreWJ5d2E0V2dNc2pxT21IMU44U0txVE9a?=
 =?utf-8?B?SGFHTkc1d1orMFdsZGs0UWl1Q0Q2VXRmK0xFS09sV0VTcmhSSkpzYWtsRjNw?=
 =?utf-8?B?Sy93eVhKeEFkeHlPS1Q4RUswQmpKRFQ2Q2dTU2ZxeHk3MDlpb1c0SWhweVEx?=
 =?utf-8?B?U3I5UHpQRkdSVUpSTWNaZzlBWFhhRHhXRmlaLzBiTWpUUDhxVXNPeFlZd2xn?=
 =?utf-8?B?MG9DekdPbGRmY3BNZWppaXA1TjlhU0JnaUdqM3BPTkNuODFFNytPZVAxaDVr?=
 =?utf-8?B?U0ZvYWhwVmNnRURETjBSNHY1ZlppVEV1djJiWFQ2aHNQK0lwRlV0ZXlBcTZr?=
 =?utf-8?B?NTZDWi9nMFlpOXhJaGgxV01jckc0aEdzb04zYzhGaUkzRTlpOVI3V2ZESFFm?=
 =?utf-8?Q?bxlYCIK51pQ3nbcoRGSiD79Wu?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6f132c0-4a42-4e8a-14da-08dc6b634355
X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 11:22:05.6137
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TbbXcWjmnsooduCLFxKIImQ12a/VUhy4rWB9U1YwI5JEtqSrBq9+DLnntwdy+mWWwgn6m5vLDNqI/vxyRyL/bA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4405

Hi Alexandre,

Thanks for your promptly response, I try to re-send the email again and 
avoid the security scanner to disrupt the external link.


 > procfs for the RTC has been deprecated for a while, don't use it.
 >
 > Instead, you can use the RTC_PARAM_GET ioctl to get RTC_PARAM_FEATURES
 > and then look at RTC_FEATURE_ALARM.

I found old version kernel doesn't support RTC_PARAM_GET ioctl. In order
support old version kernel testing, is it possible to use rtc procfs to
validate wakealarm function for old version kernel ?

Can I move this rtc alarm validation to
<linux_root>/tools/testing/selftests/rtc/rtctest.c ? So we could try to
use RTC_PARAM_GET ioctl first and then roll back to use rtc procfs if 
RTC_PARAM_GET ioctl was not supported.

Thank you,
Joseph.


On 2024/5/3 2:49 PM, Alexandre Belloni wrote:
> On 02/05/2024 18:41:02-0700, Joseph Jang wrote:
>> Some platforms do not support WAKEUP service by default, we use a shell
>> script to check the absence of alarm content in /proc/driver/rtc.
> 
> procfs for the RTC has been deprecated for a while, don't use it.
> 
> Instead, you can use the RTC_PARAM_GET ioctl to get RTC_PARAM_FEATURES
> and then look at RTC_FEATURE_ALARM.
> See https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/rtc-tools.git/tree/rtc.c
> 
>>
>> The script will validate /proc/driver/rtc when it is not empty and then
>> check if could find alarm content in it according to the rtc wakealarm
>> is supported or not.
>>
>> Requires commit 101ca8d05913b ("rtc: efi: Enable SET/GET WAKEUP services
>> as optional")
>>
>> Reviewed-by: Matthew R. Ochs <mochs@nvidia.com>
>> Signed-off-by: Joseph Jang <jjang@nvidia.com>
>> ---
>>   tools/testing/selftests/Makefile              |  1 +
>>   tools/testing/selftests/rtc/property/Makefile |  5 ++++
>>   .../selftests/rtc/property/rtc-alarm-test.sh  | 27 +++++++++++++++++++
>>   3 files changed, 33 insertions(+)
>>   create mode 100644 tools/testing/selftests/rtc/property/Makefile
>>   create mode 100755 tools/testing/selftests/rtc/property/rtc-alarm-test.sh
>>
>> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
>> index e1504833654d..f5d43e2132e8 100644
>> --- a/tools/testing/selftests/Makefile
>> +++ b/tools/testing/selftests/Makefile
>> @@ -80,6 +80,7 @@ TARGETS += riscv
>>   TARGETS += rlimits
>>   TARGETS += rseq
>>   TARGETS += rtc
>> +TARGETS += rtc/property
>>   TARGETS += rust
>>   TARGETS += seccomp
>>   TARGETS += sgx
>> diff --git a/tools/testing/selftests/rtc/property/Makefile b/tools/testing/selftests/rtc/property/Makefile
>> new file mode 100644
>> index 000000000000..c6f7aa4f0e29
>> --- /dev/null
>> +++ b/tools/testing/selftests/rtc/property/Makefile
>> @@ -0,0 +1,5 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +TEST_PROGS := rtc-alarm-test.sh
>> +
>> +include ../../lib.mk
>> +
>> diff --git a/tools/testing/selftests/rtc/property/rtc-alarm-test.sh b/tools/testing/selftests/rtc/property/rtc-alarm-test.sh
>> new file mode 100755
>> index 000000000000..3bee1dd5fbd0
>> --- /dev/null
>> +++ b/tools/testing/selftests/rtc/property/rtc-alarm-test.sh
>> @@ -0,0 +1,27 @@
>> +#!/bin/bash
>> +# SPDX-License-Identifier: GPL-2.0
>> +
>> +if [ ! -f /proc/driver/rtc ]; then
>> +	echo "SKIP: the /proc/driver/rtc is empty."
>> +	exit 4
>> +fi
>> +
>> +# Check if could find alarm content in /proc/driver/rtc according to
>> +# the rtc wakealarm is supported or not.
>> +if [ -n "$(ls /sys/class/rtc/rtc* | grep -i wakealarm)" ]; then
>> +	if [ -n "$(grep -i alarm /proc/driver/rtc)" ]; then
>> +		exit 0
>> +	else
>> +		echo "ERROR: The alarm content is not found."
>> +		cat /proc/driver/rtc
>> +		exit 1
>> +	fi
>> +else
>> +	if [ -n "$(grep -i alarm /proc/driver/rtc)" ]; then
>> +		echo "ERROR: The alarm content is found."
>> +		cat /proc/driver/rtc
>> +		exit 1
>> +	else
>> +		exit 0
>> +	fi
>> +fi
>> -- 
>> 2.34.1
>>
>