Received-SPF: pass (google.com: domain of linux-kernel+bounces-167621-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 03 May 2024 14:07:05 +0200
Message-ID: <87bk5nayl2.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: Mark Brown <broonie@kernel.org>,
	linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"end.to.start" <end.to.start@mail.ru>,
	lgirdwood@gmail.com,
	tiwai@suse.com
Subject: Re: [PATCH 1/1] sound: Support microphone from device Acer 315-24p
In-Reply-To: <9a683d7f-8bde-47f4-9f63-97b65744711b@perex.cz>
References: <20240408152454.45532-1-end.to.start@mail.ru>
	<171268609844.62778.6340689132993321193.b4-ty@kernel.org>
	<9a683d7f-8bde-47f4-9f63-97b65744711b@perex.cz>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Fri, 03 May 2024 13:23:28 +0200,
Jaroslav Kysela wrote:
> 
> On 09. 04. 24 20:08, Mark Brown wrote:
> > On Mon, 08 Apr 2024 18:24:54 +0300, end.to.start wrote:
> >> This patch adds microphone detection for the Acer 315-24p, after which a microphone appears on the device and starts working
> >> 
> >> 
> > 
> > Applied to
> > 
> >     https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> > 
> > Thanks!
> > 
> > [1/1] sound: Support microphone from device Acer 315-24p
> >        commit: 4b9a474c7c820391c0913d64431ae9e1f52a5143
> > 
> > All being well this means that it will be integrated into the linux-next
> > tree (usually sometime in the next 24 hours) and sent to Linus during
> > the next merge window (or sooner if it is a bug fix), however if
> > problems are discovered then the patch may be dropped or reverted.
> 
> Shall we really accept those anonymous contributions?
> 
> From submitting-patches.rst:
> 
> """
> then you just add a line saying::
> 
>         Signed-off-by: Random J Developer <random@developer.example.org>
> 
> using a known identity (sorry, no anonymous contributions.)
> """

Yeah, that's a bad example, and I noticed too late after sending a PR
to Linus, too (I concentrated only on the diffs).

The code change itself looks OK, so this is no big problem.
But let's decline such a submission at the next time.


thanks,

Takashi