Received-SPF: pass (google.com: domain of linux-kernel+bounces-167622-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 3 May 2024 22:08:26 +1000
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Next
 Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the arm tree
Message-ID: <20240503220826.48a59ffd@canb.auug.org.au>
In-Reply-To: <ZjSduO+MI7EA3O9A@shell.armlinux.org.uk>
References: <20240503101516.09f01e44@canb.auug.org.au>
	<ZjSduO+MI7EA3O9A@shell.armlinux.org.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/W2VRBVMfeC3EtYxOTKWPpvr";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/W2VRBVMfeC3EtYxOTKWPpvr
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Russell,

On Fri, 3 May 2024 09:18:00 +0100 "Russell King (Oracle)" <linux@armlinux.o=
rg.uk> wrote:
>
> On Fri, May 03, 2024 at 10:15:16AM +1000, Stephen Rothwell wrote:
> >=20
> > After merging the arm tree, today's linux-next build (x86_64 allmodconf=
ig)
> > failed like this:
> >=20
> > drivers/clk/clkdev.c: In function 'vclkdev_alloc':
> > drivers/clk/clkdev.c:195:16: error: assignment to '__va_list_tag (*)[1]=
' from incompatible pointer type '__va_list_tag **' [-Werror=3Dincompatible=
-pointer-types]
> >   195 |         fmt.va =3D &ap;
> >       |                ^
> > cc1: all warnings being treated as errors =20
>=20
> This builds perfectly fine for me - this is on debian stable with
> arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110:
>=20
> No warnings, no errors.
>=20
> va_format is defined as:
>=20
> struct va_format {
>         const char *fmt;
>         va_list *va;
> };
>=20
> and what we have here is a "va_list ap".
>=20
> Therefore, the assignment:
>=20
>         fmt.va =3D &ap;
>=20
> is correct.
>=20
> What certainly won't work is:
>=20
> 	fmt.va =3D ap;
>=20
> and there aren't any other reasonable alternatives.
>=20
> My conclusion: your compiler is being stupid.

Definitely possible.  My build is an x86_64 allmodconfig cross build
hosted on PowerPC64LE.

$ x86_64-linux-gnu-gcc --version
x86_64-linux-gnu-gcc (Debian 13.2.0-7) 13.2.0

It still fails for me even just building your tree.  :-(

And if I revert commit 5d998425e37b it does not fail (of course).

--=20
Cheers,
Stephen Rothwell

--Sig_/W2VRBVMfeC3EtYxOTKWPpvr
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmY007oACgkQAVBC80lX
0GzvaAgAoSjIVTPnLl2uuWdiBZABK+leKnUuRZ72LlHPzbaSPqL8MSeDMBYmmhVD
baL34AhzTWx8vrmennM+bxb/PyQLpW4w0cKHp92B/moeNF727l0SV9a5KR+G4Mhz
YEwtKgymg00b27D+UVaS3kXcvcvRCClB3/5VA4xCWLtbECuiUgL6BL6OqKuIb2PG
z6x4dnN8RY+84Mlr6HOmeg6jd0Wm+oxeS0/pwPA0xp2lJ3rnASw+OadPRo/7QrlN
6pDI3+DA9/dSwTKiT4jpugZrFHUxxp51d3DY2i5ApHbUYoUlNUhfpO6+9ZWVtUKT
z24IvH3YgrUeuWnMO4L26LNflw00Qg==
=LqO/
-----END PGP SIGNATURE-----

--Sig_/W2VRBVMfeC3EtYxOTKWPpvr--