Received-SPF: pass (google.com: domain of linux-kernel+bounces-167626-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <20798b97-fa19-46fa-abce-54f7931c9210@ghiti.fr>
Date: Fri, 3 May 2024 14:14:34 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] riscv: uaccess: Relax the threshold for fast path
Content-Language: en-US
To: Xiao Wang <xiao.w.wang@intel.com>, paul.walmsley@sifive.com,
 palmer@dabbelt.com, aou@eecs.berkeley.edu
Cc: jerry.shih@sifive.com, nick.knight@sifive.com, ajones@ventanamicro.com,
 bjorn@rivosinc.com, andy.chiu@sifive.com, viro@zeniv.linux.org.uk,
 cleger@rivosinc.com, alexghiti@rivosinc.com, haicheng.li@intel.com,
 linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20240313091929.4029960-1-xiao.w.wang@intel.com>
From: Alexandre Ghiti <alex@ghiti.fr>
In-Reply-To: <20240313091929.4029960-1-xiao.w.wang@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Xiao,

On 13/03/2024 10:19, Xiao Wang wrote:
> The bytes copy for unaligned head would cover at most SZREG-1 bytes, so
> it's better to set the threshold as >= (SZREG-1 + word_copy stride size)
> which equals to 9*SZREG-1.
>
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> ---
>   arch/riscv/lib/uaccess.S | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/lib/uaccess.S b/arch/riscv/lib/uaccess.S
> index bc22c078aba8..2e665f8f8fcc 100644
> --- a/arch/riscv/lib/uaccess.S
> +++ b/arch/riscv/lib/uaccess.S
> @@ -44,7 +44,7 @@ SYM_FUNC_START(fallback_scalar_usercopy)
>   	 * Use byte copy only if too small.
>   	 * SZREG holds 4 for RV32 and 8 for RV64
>   	 */
> -	li	a3, 9*SZREG /* size must be larger than size in word_copy */
> +	li	a3, 9*SZREG-1 /* size must >= (word_copy stride + SZREG-1) */
>   	bltu	a2, a3, .Lbyte_copy_tail
>   
>   	/*


This looks good to me:

Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>

Thanks,

Alex