Received-SPF: pass (google.com: domain of linux-kernel+bounces-167643-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 3 May 2024 08:36:38 -0400
From: Parker Newman <parker@finest.io>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Parker Newman <pnewman@connecttech.com>, linux-kernel@vger.kernel.org,
 linux-serial@vger.kernel.org, Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 00/13] serial: 8250_exar: Clean up the driver
Message-ID: <20240503083638.0f8d9afb@SWDEV2.connecttech.local>
In-Reply-To: <ZjPVEr7D0lEf86kQ@smile.fi.intel.com>
References: <20240502144626.2716994-1-andriy.shevchenko@linux.intel.com>
	<20240502114645.4445b3da@SWDEV2.connecttech.local>
	<ZjO4vYEBzxU3fpzC@smile.fi.intel.com>
	<20240502120840.02c65f30@SWDEV2.connecttech.local>
	<ZjPL5z7ah-Qkct6l@smile.fi.intel.com>
	<20240502134949.5e780635@SWDEV2.connecttech.local>
	<ZjPVEr7D0lEf86kQ@smile.fi.intel.com>
Organization: Connect Tech Inc.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:Y80D4vzoXK8=;wqrCnw9oWycvF2C1VXvSnRUeY2O
 2UQenEnZ5DBZ69bOXzzeM347nuuR+yPYrVZ2rT4V61xVu+tya3C7LO2W9x0WKi9FX5YdnBSS5
 /NEPilaLmPfbZu7h1CE7xOATDIDGSNg5VYaNCRHVEA0Pz1LvINl+CiSOENFqSOhKiO86rUT3g
 LBvPDsooqSRaRuI9DdKpnFs3IkutqtJOcV9MJB95t2736SmPX69go+vBtPJh67KnhudNo/nJb
 SwmiERK5OgAR84PsxFxibxlIwG7JSCCmkl9squG6bBXhpmrDMjLJBLKMu6iDJrRHbhpj0Dwwn
 jbcGVeYu/9jH1rHARsPnb55FLIJM1UlrDcUTbmKVsxs5nfprZHNjAo/Fw0Jo2rppq6+5k1t8S
 uvC+If+31ZpKdjfCes7YRLgvM4k8dPBr8ju1LIElosiM4q5LCt+rffOKFbwWpCFJetGHHDlPh
 3DKAEP4Atz3iRe47gi7yKIk/9+3UNES4eghY5RrRLhGCmajNImaqclpyTv0BBU2MqDL0r5p0x
 0W6erUMd75ARsxkcqQNbhapDLtkNUPAJGeaCyodIGk+3lqngAGVr7dgjycqiVOpDdRXv+ghj2
 8hyUGV1/gdyWjFDwlGndrkc0AziOGGyrNNzpOCtV9e+I/grl2x+HUJHI4D5T5Tw1sJskPldMi
 xUW/oj6NDbP7LWKV4v1b5gfv6mRNo15a+fD8nlsQ5U38lM9jEp7XSgYZnuDbGiLzZFjCCMIYX
 dw1/byrpKxPQmndO60p5Vtd+VLxenL06j6Xo2Wx+R5BwQOm5KkADzk=

On Thu, 2 May 2024 21:01:54 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Thu, May 02, 2024 at 01:49:49PM -0400, Parker Newman wrote:
> > On Thu, 2 May 2024 20:22:47 +0300
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > On Thu, May 02, 2024 at 12:08:40PM -0400, Parker Newman wrote:
> > > > On Thu, 2 May 2024 19:01:01 +0300
> > > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > > > On Thu, May 02, 2024 at 11:46:45AM -0400, Parker Newman wrote:
> > > > > > On Thu,  2 May 2024 17:43:54 +0300
> > > > > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > > > >
> > > > > > > After a rework for CONNTECH was done, the driver may need a =
bit of
> > > > > > > love in order to become less verbose (in terms of indentatio=
n and
> > > > > > > code duplication) and hence easier to read.
> > > > > > >
> > > > > > > This clean up series fixes a couple of (not so critical) iss=
ues and
> > > > > > > cleans up the recently added code. No functional change inde=
nted by
> > > > > > > the cleaning up part.
> > > > > >
> > > > > > Just an FYI I submitted a patch series that fixed several of t=
hese issues but I
> > > > > > think it fell through the cracks (I know everyone is very busy=
!).
> > > > > >
> > > > > > Link: https://lore.kernel.org/linux-serial/cover.1713533298.gi=
t.pnewman@connecttech.com/
> > > > > >
> > > > > > I believe my previous patch series is no longer required. This=
 one fixes
> > > > > > everything.
> > > > >
> > > > > I haven't noticed that, if it contains duplicated patches, I may=
 replace mine
> > > > > with yours if you insist.
> > > > >
> > > > > In any case it's better to reply there that you prefer this seri=
es to be
> > > > > applied, so Greg will not pick it up.
> > > > >
> > > >
> > > > I do not have a preference. I am fine with using yours if it is ea=
sier on
> > > > the maintainers.
> > >
> > > Up to you, there is no issue to take your patches in case they are t=
he same
> > > (or quite similar) as mine. I can pick them up, just tell me if you =
want this
> > > to happen with a list of the patches (as mail Message-Id).
> >
> > Just use yours.
>
> Okay, thanks!
>
> If you are going to test, better to pay attention to the BIT() conversio=
n patch
> as Ilpo noted an issue. I believe it's easy to drop (via local git-rebas=
e run)
> or move and test separately.
>

I am working on testing now but patches 7 and 12 did not apply with git am=
.
Both failed around lines 1095/1096.
I can apply them manually but I may be using the wrong branch (tty-next).
Which branch/commit did you create your patches from? I don't see it in th=
e
patch submission.