Received-SPF: pass (google.com: domain of linux-kernel+bounces-167693-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 3 May 2024 15:18:57 +0200
From: Joel Granados <j.granados@samsung.com>
To: Wen Yang <wen.yang@linux.dev>
CC: "Eric W . Biederman" <ebiederm@xmission.com>, Luis Chamberlain
	<mcgrof@kernel.org>, Kees Cook <keescook@chromium.org>, Christian Brauner
	<brauner@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] sysctl: move the extra1/2 boundary check of u8 to
 sysctl_check_table_array
Message-ID: <20240503131857.7oqxlxckdmd2qzyn@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="u4b4sobnu47ymwhr"
Content-Disposition: inline
In-Reply-To: <20240419033639.259471-1-wen.yang@linux.dev>
CMS-TYPE: 201P
References: <CGME20240419033727eucas1p1c7c7bbd508cf24066b5971c1015bd00c@eucas1p1.samsung.com>
	<20240419033639.259471-1-wen.yang@linux.dev>

--u4b4sobnu47ymwhr
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 19, 2024 at 11:36:39AM +0800, Wen Yang wrote:
> Move boundary checking for proc_dou8ved_minmax into module loading, there=
by
> reporting errors in advance. And add a kunit test case ensuring the
> boundary check is done correctly.
>=20
=2E..
> +	KUNIT_CASE(sysctl_test_register_sysctl_sz_invalid_extra_value),
>  	{}
>  };
> =20
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index e0b917328cf9..c0a1164eaf59 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -977,16 +977,10 @@ int proc_dou8vec_minmax(struct ctl_table *table, in=
t write,
>  	if (table->maxlen !=3D sizeof(u8))
>  		return -EINVAL;
> =20
> -	if (table->extra1) {
> +	if (table->extra1)
>  		min =3D *(unsigned int *) table->extra1;
> -		if (min > 255U)
> -			return -EINVAL;
> -	}
> -	if (table->extra2) {
> +	if (table->extra2)
>  		max =3D *(unsigned int *) table->extra2;
> -		if (max > 255U)
> -			return -EINVAL;
> -	}
> =20
>  	tmp =3D *table;
> =20
> --=20
> 2.25.1
>=20

Queueing this up for 6.11. I'll put it into sysclt-testing.

Reviewed-by: Joel Granados <j.granados@samsung.com>
--=20

Joel Granados

--u4b4sobnu47ymwhr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmY05EEACgkQupfNUreW
QU/uCAv+N3mG6q8G+JDitzIbzSsE8qy8zA2NFeABhlaHgZRkij0LB6zmqhr4a7zK
n2rGDkPvUPDKfpb9tAzaQdsRUsqt1/jh5re6pZTfmP1w3G0bgEdRN2TIUv1hH5Cy
cVqPJKWngxusOQSkSEDqalhgIJvptorO7B18rLVMAyL32r/VLpKiPHCP2v8FIuBv
jTveLrEylGNsnfI/zdSFz1JX83jXWpP4fQF8tBbR597bc0aApPSU2uZetkkFXoTA
PxeSg6THZdiEJNgJ60HkhEMSd/gDgSzkTlIgOEsuWjq2qqq1GANfX5PjW6PL73lb
DuqCySBtk1Mg6D2Y4TZUYDHdZPIra228I0HVrv7uUw1z8A36m80YSwKPPDUnLxdW
73C5rFqHFjlsKdogYPPbB9ktMW6jnbyRjmjfiol9asqfjINJMqQPgN4K+0O/o0um
6oBRwdN2hSPgfW0j3cbcA5ruKrDLFylZjRUoLcHt0ZxAqDLSLSvLsBoET/jpTBQr
J8++X6yL
=L8lR
-----END PGP SIGNATURE-----

--u4b4sobnu47ymwhr--