Received-SPF: pass (google.com: domain of linux-kernel+bounces-167861-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Jens Axboe <axboe@kernel.dk>
To: INAGAKI Hiroshi <musashino.open@gmail.com>
Cc: yang.yang29@zte.com, justinstitt@google.com, xu.panda@zte.com.cn, 
 linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, 
 Naohiro Aota <naota@elisp.net>
In-Reply-To: <20240421074005.565-1-musashino.open@gmail.com>
References: <20240421074005.565-1-musashino.open@gmail.com>
Subject: Re: [PATCH] block: fix and simplify blkdevparts= cmdline parsing
Message-Id: <171475189763.53050.4004560606440063491.b4-ty@kernel.dk>
Date: Fri, 03 May 2024 09:58:17 -0600
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


On Sun, 21 Apr 2024 16:39:52 +0900, INAGAKI Hiroshi wrote:
> Fix the cmdline parsing of the "blkdevparts=" parameter using strsep(),
> which makes the code simpler.
> 
> Before commit 146afeb235cc ("block: use strscpy() to instead of
> strncpy()"), we used a strncpy() to copy a block device name and partition
> names. The commit simply replaced a strncpy() and NULL termination with
> a strscpy(). It did not update calculations of length passed to strscpy().
> While the length passed to strncpy() is just a length of valid characters
> without NULL termination ('\0'), strscpy() takes it as a length of the
> destination buffer, including a NULL termination.
> 
> [...]

Applied, thanks!

[1/1] block: fix and simplify blkdevparts= cmdline parsing
      commit: bc2e07dfd2c49aaa4b52302cf7b55cf94e025f79

Best regards,
-- 
Jens Axboe