Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1881055lqm; Fri, 3 May 2024 09:02:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWNC4/7ZahbBZTFPN4v2DhOhhXunc+BZkRX+hUaAqfg3AYYDWnPHDZhoCMQ1OLrg1B1CT5A0KsXQE0Rv/DE3s0TVXpaCEbaP0KSSeUevg== X-Google-Smtp-Source: AGHT+IG8G3oLhI0KAmy/SoFwbwNm6poSkXyKVUVUEL7fvDbNkd4FfCRTmLbEu729TP8GgCaQHTBS X-Received: by 2002:a05:6830:209a:b0:6ee:50c2:6f7e with SMTP id y26-20020a056830209a00b006ee50c26f7emr3428454otq.0.1714752132223; Fri, 03 May 2024 09:02:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714752132; cv=pass; d=google.com; s=arc-20160816; b=FJW/nzAw65h5fTsil9j+RGSfc5rfI+RLu2u2gVKlDY4iobHgj8sBHUKCUq8+DFwUMZ jx8imlaNdo+6TgfFZqWmYNUS16pQW4PQg2EN4E022eMziT+PLWGKE2saSVhugibCRlEl g1VtIybNqSLxA4JkRmXhY+jSxx7xwX4xGIK5v1aunJ+fviT58URktB6eyOKNwMclSD5D 2pI/zfIm4YWofCqj3dun50KYOpg8goW/o++LLE1tQknkQSVtH+aPCD1G/n0OTOcvqnO3 0ZFLO1Cmo4OEpgV9PZ+CAW8f61vIXfWrw9LlCn4lPKGRC+bHof7IVMAptFk96CjOBwpo Wjmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=jIZkfh+kuEoD1cL28brOME2eW2ZNyLbIQHzDi27Jp9M=; fh=zlbgFqwmx9F+FyEg7b9wwS8kOJhxFA7RytRFgvBlsf8=; b=h4VTSM1zguilL8CB9DlnPyKy/P86bYTfLqXaicS3UFZOBXp2SeBoknvDyzXCbKEKsE PWpsO5kRGEIVYwzZF+B5qUkLSbiDMMihFpOzApWO3nwBxjtRfOPPRPmh03oBkhm7HpLI fB6l0BTgSPH1JyU0HaNJdGFMQ+3dMxVhHNMSWJeSqpWu4xrIyXdEyMh3O4J2pYzpgHhs O1RMxUU1gbSDJAYNrQV1jzrUz8jQXgfNcdYteGpyNmB/0PZ0ckWXkHmElFX9KKCsPUDD UM2ba81oiba8yxp9HuqBu76wHcEJwMHy+NYKNYEZkjVnekt+xYxoYsPdIAXyPnYcgyr4 FZ+w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Aef4gjis; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-167865-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-167865-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id y26-20020a056830109a00b006eb7f0a4e0esi1044786oto.193.2024.05.03.09.02.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 May 2024 09:02:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-167865-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Aef4gjis; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-167865-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-167865-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 63C761C2277E for ; Fri, 3 May 2024 16:01:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C6AC0154C19; Fri, 3 May 2024 16:01:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Aef4gjis" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DB1C155397; Fri, 3 May 2024 16:01:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714752109; cv=none; b=lLvPhr80AxlLJGTIScnhDSt3+BT/io0fKsaSlOCyn+XxzzpWbaW6aWymwXBt6CWWLQOCynEAWJDMuqAfqr8Yi0HFAUOGU2koPtbYGmVG+yJ9NVDDdTkg4Vc43Pws0pQbPPjmHImnABrB2JcjyBvzV/yuhX0lc8qFFC/Hsl/hwP0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714752109; c=relaxed/simple; bh=toj4JNt/0SGplSZYRBmdaHv21iUmacqFjF9Z0TMqpOA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FZMhHZZ6FdsITVSPlfIMa9zVjsejDeC4VjZGbGQsa9T+Ots5UqpX57LWqCVSr2Dxdl9ESA6GRKkQZm8+d/tAr5vzTK2m0mNGDXLiS3JeibxfZxXVq/5uHFNIM9Sap/2yop8++ZdqOjBiwyOzWhArOJWM76fjQ2gqN17CW32otBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Aef4gjis; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714752106; x=1746288106; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=toj4JNt/0SGplSZYRBmdaHv21iUmacqFjF9Z0TMqpOA=; b=Aef4gjis7rRRV46GE/fA1fJr86OSPAwk/+aiwA+B3Ab9n1BJ9+AHkKKv 3Hn7GXpBYwuHgcmjyX5jwl4OEFYCQjCzA4cI1NMmoAqPzdyG038NhriJY 6ns7I8Dca0RY6Cch1Sdx58TR+3TpFJuL/1xpGic0dDFX7/kPoun+G8Slx kH236MaDrWgS0TApe+BL4VMsRe6QczlDWNEseQeFNiFlYJO3q2n5RZ00P jUv5MpceaKkntFykJMzmmua04Yqg6AyLJFm7aZcN9St4rRiH6DweCo0nu DkjKtxxHgYFqwHC/Ah97I3A8j9vWQQ3obB7YbUphMo5ziLfDiogAOqWrF g==; X-CSE-ConnectionGUID: S9IwbmWQQkyLt3owFLwLJw== X-CSE-MsgGUID: z/Nf2RK4RGiM7e8Pn3ejug== X-IronPort-AV: E=McAfee;i="6600,9927,11063"; a="11098772" X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="11098772" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2024 09:01:34 -0700 X-CSE-ConnectionGUID: QMbUy9s0QV2EjF4/eXWwKg== X-CSE-MsgGUID: 8sTeKWiSRAOZATLgO+dLjw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="27891983" Received: from zhangche-mobl.amr.corp.intel.com (HELO [10.209.82.31]) ([10.209.82.31]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2024 09:01:32 -0700 Message-ID: Date: Fri, 3 May 2024 09:01:31 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] x86/virt/tdx: Move TDMR metadata fields map table to local variable To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: x86@kernel.org, kirill.shutemov@linux.intel.com, peterz@infradead.org, tglx@linutronix.de, bp@alien8.de, mingo@redhat.com, hpa@zytor.com, seanjc@google.com, pbonzini@redhat.com, isaku.yamahata@intel.com, jgross@suse.com References: <41cd371d8a9caadf183e3ab464c57f9f715184d3.1709288433.git.kai.huang@intel.com> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <41cd371d8a9caadf183e3ab464c57f9f715184d3.1709288433.git.kai.huang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/1/24 03:20, Kai Huang wrote: > The kernel reads all TDMR related global metadata fields based on a > table which maps the metadata fields to the corresponding members of > 'struct tdx_tdmr_sysinfo'. > > Currently this table is a static variable. But this table is only used > by the function which reads these metadata fields and becomes useless > after reading is done. Is this intended to be a problem statement? _How_ is this a problem? > Change the table to function local variable. This also saves the > storage of the table from the kernel image. I'm confused how this would happen. Could you please explain your logic a bit here?