Received-SPF: pass (google.com: domain of linux-kernel+bounces-167900-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f87bfbb1-b80f-46a5-be85-058a406de99d@gmail.com>
Date: Fri, 3 May 2024 21:53:19 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH linux-next] gpu:ipu-v3:pre: replace of_node_put() with
 __free
To: p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
 skhan@linuxfoundation.org, javier.carrasco.cruz@gmail.com,
 Julia Lawall <julia.lawall@inria.fr>
References: <20240427045024.7083-1-prosunofficial@gmail.com>
Content-Language: en-US
From: R Sundar <prosunofficial@gmail.com>
In-Reply-To: <20240427045024.7083-1-prosunofficial@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 27/04/24 10:20, R Sundar wrote:
> use the new cleanup magic to replace of_node_put() with
> __free(device_node) marking to auto release when they get out of scope.
> 
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Signed-off-by: R Sundar <prosunofficial@gmail.com>
> ---
>   drivers/gpu/ipu-v3/ipu-pre.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/ipu-v3/ipu-pre.c b/drivers/gpu/ipu-v3/ipu-pre.c
> index aef984a43190..95830cf8fa3e 100644
> --- a/drivers/gpu/ipu-v3/ipu-pre.c
> +++ b/drivers/gpu/ipu-v3/ipu-pre.c
> @@ -113,8 +113,8 @@ int ipu_pre_get_available_count(void)
>   struct ipu_pre *
>   ipu_pre_lookup_by_phandle(struct device *dev, const char *name, int index)
>   {
> -	struct device_node *pre_node = of_parse_phandle(dev->of_node,
> -							name, index);
> +	struct device_node *pre_node __free(device_node) =
> +		of_parse_phandle(dev->of_node, name, index);
>   	struct ipu_pre *pre;
>   
>   	mutex_lock(&ipu_pre_list_mutex);
> @@ -123,14 +123,11 @@ ipu_pre_lookup_by_phandle(struct device *dev, const char *name, int index)
>   			mutex_unlock(&ipu_pre_list_mutex);
>   			device_link_add(dev, pre->dev,
>   					DL_FLAG_AUTOREMOVE_CONSUMER);
> -			of_node_put(pre_node);
>   			return pre;
>   		}
>   	}
>   	mutex_unlock(&ipu_pre_list_mutex);
>   
> -	of_node_put(pre_node);
> -
>   	return NULL;
>   }
>   
Hi,

Any feedback on this patch.

Thanks,
Sundar