Received-SPF: pass (google.com: domain of linux-kernel+bounces-168028-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: Ricky Wu <en-wei.wu@canonical.com>, "Brandeburg, Jesse"
	<jesse.brandeburg@intel.com>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
	"intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
	"davem@davemloft.net" <davem@davemloft.net>, "edumazet@google.com"
	<edumazet@google.com>, "kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "rickywu0421@gmail.com"
	<rickywu0421@gmail.com>
Subject: RE: [PATCH v2 1/2] e1000e: let the sleep codes run every time
Thread-Topic: [PATCH v2 1/2] e1000e: let the sleep codes run every time
Thread-Index: AQHanUNg1fw+5ujRE0uu5oPk5mp1YLGF0XzA
Date: Fri, 3 May 2024 18:17:00 +0000
Message-ID: <CO1PR11MB5089D44A4EBA6CA829A23D8AD61F2@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <20240503101824.32717-1-en-wei.wu@canonical.com>
In-Reply-To: <20240503101824.32717-1-en-wei.wu@canonical.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YRs225Ehat+DtDbZEWRKT43aLf8QsJotmmC6s3+bPud9yFu4YGaa2gZH9khK?=
 =?us-ascii?Q?rqqbhcPMD5t9pZGJrml/tK6z+Tngq2YioI9e5JUDzImDC2BSC1FISpzaQIz/?=
 =?us-ascii?Q?g/ul3CeEH5jkoavBkBdIYzx2JXT4cWh6KN7rWXDkpUXN83HGjER6Uo01yGF5?=
 =?us-ascii?Q?p7odTTiRXJQEBcPZuz7kEWD32Vp5BUUv08eq1WuXGqQzXNuFhF99AuXHgss2?=
 =?us-ascii?Q?NCqGSAad7OMolhDxPsujQmhL7FfQvZVAYBM7rRK0Wn85fS27ZCa6eqbeY+z9?=
 =?us-ascii?Q?sgBzB0w/kVG3u95V1OL5auja3gM87UUlS7fJ7AoJMpi9NHqarTVFCXQvJVg5?=
 =?us-ascii?Q?8lIX7Oc5M0EL018ard/DbgS0oWbDvNMVjeTkVE2r+s0beTzfN9HueM5u57Lt?=
 =?us-ascii?Q?tpQXwLt+Uad2SZ7QeX5l4bReuzyvBqp2WCb7NOLHlrNOkSKWeN5KjPiliQDT?=
 =?us-ascii?Q?rIhrQ0qRYUShpWsEfu0H1zt2ygpXXh90Jyn1VVKfPjwgEOatgcXsRLtCngxf?=
 =?us-ascii?Q?jSb7E6EaxDFw9pVaXtaXMG96TiDswBGJGcQVyWM/d0mcndV948ysEGBg/2YD?=
 =?us-ascii?Q?kOE3FSLvkOlbok5oQtGD4biagHQuPI99PsL493X8mvbJQdFErQpOV4gBvfaJ?=
 =?us-ascii?Q?Qhc4EuxeOqmQ6pgRq9frQrdq0dgbPUsJ1dMEsvVy9AO3QIjMxdVIKucFg0nP?=
 =?us-ascii?Q?L8nZO7f54Mx9h9ySUNfwkQ87G8XxM1cPf/ESOqisbGlt2u4YHHpjzQg8vo+T?=
 =?us-ascii?Q?lY1dmZZVr7pYGiaseCYG9iA9ALnuUnZ40aGoJuWaMmOE67AyZHI93fOYKnin?=
 =?us-ascii?Q?s3twK5u09+kaGCd0Z4LZdkaq2EHbOriLLS10Q7XCD2KGwJIj+Yxh4NSQVAth?=
 =?us-ascii?Q?BoyCmlhSnNOpG/K2U51JwTQ9DxiJnC2ivXY44lRwS/sr0B0ldL5wT+rdLZ9J?=
 =?us-ascii?Q?g8bV5dBSaWrbrbrlzu8RCYClW2VjdOIN5+hcbxNJgdSDrnw0BAPwz2DNMBQ0?=
 =?us-ascii?Q?jYoOglXTodmYHM83PqldKjQVyc2wwLFUe/449rxWl7anyx1gXld9z0hcw61T?=
 =?us-ascii?Q?1hvtnqOJ10XeNbTfOxErmCpqoUqgrMEo2iMF+kM4iVB6BOTGUiG+w/ozpR6j?=
 =?us-ascii?Q?SADVsTCCPJ3Xos/u6o/XvQ0VU6QSTwd566glyHYaxWbyMhDL5q6q/0q6l+HL?=
 =?us-ascii?Q?gRDhrdSFTNDKdje4fJ4PuxlA6tzNFB6KIp/UOf3/Ud/WGxjQ7EOXxzd75uqQ?=
 =?us-ascii?Q?6ACBdJONcQBpWtFcL+uL25NMWNg2g51KTD0WTiHUgaWs9p2CWU10/drlRvAC?=
 =?us-ascii?Q?/rkMe+19Oc9Amp9SuvLelFzJYxajTDzuxnBMkzPcpwvnLbU4G7rMAlDcg5Ry?=
 =?us-ascii?Q?/hpOEji70dKybDYqSMT4r8ZAl0gVO2qMBDd+CbtXbCuQ0vrxVNaPXfkpXdTg?=
 =?us-ascii?Q?7j9TIdN5KOoNr/zPHFEJqesBO10QMuuYv2Iz6YBwaaRXqdAmLwOUQ+a6Cj50?=
 =?us-ascii?Q?CkLOa1rMMKPiFrF8BL6Te3n30f2fjfnCufkoYqlqZ8o6oSZzyVQF2R8SCqai?=
 =?us-ascii?Q?A/nDtMxwBPUkfs6jDyhXa+Q+wqPmGD7wRkXIy4GF?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 926b8ff3-3d9c-45fc-fd6b-08dc6b9d3a12
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2024 18:17:00.7797
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 20BTE0f5VCYNLLWrXrN+5oBk/sWUDkfmpfLIgqU4eXNqYztAnfQ3RPm1o5DEVCblpHIGO7Ic9Oy24r0f51VMlAfk412x9QZJAU/nQ64r4Og=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7555
X-OriginatorOrg: intel.com


> -----Original Message-----
> From: Ricky Wu <en-wei.wu@canonical.com>
> Sent: Friday, May 3, 2024 3:18 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>
> Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; intel-wired-
> lan@lists.osuosl.org; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; rickywu0421@gmail.com; en-wei.wu@canonical.com
> Subject: [PATCH v2 1/2] e1000e: let the sleep codes run every time
>=20
> Originally, the sleep codes being moved forward only
> ran if we met some conditions (e.g. BMSR_LSTATUS bit
> not set in phy_status). Moving these sleep codes forward
> makes the usec_interval take effect every time.
>=20
> Signed-off-by: Ricky Wu <en-wei.wu@canonical.com>

What's the goal here? Do we need to sleep before initially checking the sta=
te?=20