Received-SPF: pass (google.com: domain of linux-kernel+bounces-168072-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 3 May 2024 14:33:03 -0400
From: Parker Newman <parker@finest.io>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Parker Newman <pnewman@connecttech.com>, linux-kernel@vger.kernel.org,
 linux-serial@vger.kernel.org, Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v2 00/13] serial: 8250_exar: Clean up the driver
Message-ID: <20240503143303.15bf82bc@SWDEV2.connecttech.local>
In-Reply-To: <20240503171917.2921250-1-andriy.shevchenko@linux.intel.com>
References: <20240503171917.2921250-1-andriy.shevchenko@linux.intel.com>
Organization: Connect Tech Inc.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:z6tPXeVmnlA=;EnWuVFXag5b+89g7vcHid7uBS0j
 cJzBLP0zciG67QYq4nXDKis0mdiLlNZaUC3/vTuH7zqpaw5RWOT/7igoO5UYHavWrzDc1Jfkk
 Ql5I4PDsBM29DCFWNyQKQ2RbHfiLWMoo9p4yMr6xtjJAcOc0X99xO2NKZgEUeIp3HrAuy3zk/
 c+QSzzPN8wnMwlgOaFfYww7qU6QhmYBFAPB+rFzqbAPF/cNKwlPGUERqdjXlr2lJvr5WRm+Y7
 lTLFYFTOI2edV+d71/pg+7YBoNQggs3dxZd/VLD3jzu9+EWW99zUQcIR6l87lwoxLKo/Ecw1r
 oKCSuwVCNu6l9LNlcCH/JsgZfCbAeOTa8j++AzlqwhAj+0XmcIfHrUss3MeyykzLxQV7Rda27
 GrUArWkw4jcDjUfe5B3oCbuI2rIZRTXBXFIz8uCuQZFbm4KYwmp/Hg+2e+Sanr5rq1s721rmK
 rvkaZcVdeX0ShaIFwLQRm2COkO6pUBaik0fKNxtDl8d2w6XaZvsMTVI41aZphFkQJ7qMopCQP
 JLEImCKbYDh6wRc4RU1HVKtEE9q7u9QdqHPbOXtV0SnOnRcAr7N88rEZ9VHlyLg5He8R+dq79
 bDjOJW6YXKslrUOKNdYgItuyL7qcWr/N7br+Vzty+FFSLg0GiHb7GGRM1hVwQGodnMenE2fYS
 PG8rWuidwUpAzW2RvfBZLCMB6Zb0xt/dt8bytnmKcYXWYPd5+TrwI9y3sYDxrQPOiDmMTSoCF
 qIPOubzqyi+7UL+AkouqQodqKoXjvuRw4ivsr+0koqQimsZM66Vm5M=

On Fri,  3 May 2024 20:15:52 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> After a rework for CONNTECH was done, the driver may need a bit of
> love in order to become less verbose (in terms of indentation and
> code duplication) and hence easier to read.
>
> This clean up series fixes a couple of (not so critical) issues and
> cleans up the recently added code. No functional change indented by
> the cleaning up part.
>
> Parker, please test this and give your formal Tested-by tag
> (you may do it by replying to this message if all patches are
>  successfully tested; more details about tags are available in
>  the Submitting Patches documentation).
>

I was able to test the Connect Tech related code and everything is
work as expected. I can't test the non-CTI related changes but they
are pretty minor.

Tested-by: Parker Newman <pnewman@connecttech.com>

> In v2:
> - fixed the EEPROM reading data loop (Ilpo, Parker)
>
> Andy Shevchenko (13):
>   serial: 8250_exar: Don't return positive values as error codes
>   serial: 8250_exar: Describe all parameters in kernel doc
>   serial: 8250_exar: Kill CTI_PCI_DEVICE()
>   serial: 8250_exar: Use PCI_SUBVENDOR_ID_IBM for subvendor ID
>   serial: 8250_exar: Trivia typo fixes
>   serial: 8250_exar: Extract cti_board_init_osc_freq() helper
>   serial: 8250_exar: Kill unneeded ->board_init()
>   serial: 8250_exar: Decrease indentation level
>   serial: 8250_exar: Return directly from switch-cases
>   serial: 8250_exar: Switch to use dev_err_probe()
>   serial: 8250_exar: Use BIT() in exar_ee_read()
>   serial: 8250_exar: Make type of bit the same in exar_ee_*_bit()
>   serial: 8250_exar: Keep the includes sorted
>
>  drivers/tty/serial/8250/8250_exar.c | 459 ++++++++++++----------------
>  1 file changed, 203 insertions(+), 256 deletions(-)
>