Received-SPF: pass (google.com: domain of linux-kernel+bounces-168075-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <26f3effc-6ea1-4670-a301-76df3a710fa9@intel.com>
Date: Fri, 3 May 2024 11:37:04 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] selftests/resctrl: fix clang build warnings related to
 abs(), labs() calls
To: John Hubbard <jhubbard@nvidia.com>, =?UTF-8?Q?Ilpo_J=C3=A4rvinen?=
	<ilpo.jarvinen@linux.intel.com>
CC: Shuah Khan <shuah@kernel.org>, Nathan Chancellor <nathan@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>, Bill Wendling
	<morbo@google.com>, Justin Stitt <justinstitt@google.com>, Fenghua Yu
	<fenghua.yu@intel.com>, Valentin Obst <kernel@valentinobst.de>,
	<linux-kselftest@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	<llvm@lists.linux.dev>
References: <20240503023209.80787-1-jhubbard@nvidia.com>
 <793bd068-c3b4-6330-41a4-bea597b1d820@linux.intel.com>
 <f908ba74-86c0-409c-854d-9da5f3917b05@nvidia.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <f908ba74-86c0-409c-854d-9da5f3917b05@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1ZJK3JFbXVxNGdxaHF5Q0hpWFlCUnQ2QUdqd20vZ0hjNU5QOUV2emQ3Z2xx?=
 =?utf-8?B?cVIwS1RTamI3S2xMbEc4MWtLNFBIZ1R6d1NDSkE1eVo5REsrd29ncXNEOGJy?=
 =?utf-8?B?bFQyMUdMd2lsYVF3dnJmcUtXN3lJbHJjR2tIOEc3YkY5YnE5VDRzMGtpNDFO?=
 =?utf-8?B?ME9QNHNaVklIZ3RoZVMvN2lvVENkdTNGREpRaWRGY1o0SUY2c3BBK3hjYkpj?=
 =?utf-8?B?VWxJcm9jbGJFQ1NMNUhndWpkVmh5OSszcWx6WmpVY0RxaE5WSC9CUlFtMnNh?=
 =?utf-8?B?ZXB3cVFLYjM1eGRsaEUvck9mTkR4UmpqZFNWQWNIWHR3ZE42aHJnd0xRMTNL?=
 =?utf-8?B?OWg5RnZFWFk2TTl2bkhCbWRjQTM3Tm4rSDJiNjQ4czdjNGpLVUIvMWtxWkxq?=
 =?utf-8?B?a2t6U3RCeE9yUjQwSkZiOVQzcjRjZm5DZzZzaHFkZU9yUWxhWWhOV0Vtclow?=
 =?utf-8?B?dG90YWkwNXlKWlIvVjFiNVFMQnhTRTlBVWpBd29QNG9ML0Fyclh2Ym5uTWVT?=
 =?utf-8?B?N2xhYWVjMkljKzhyV3NVNVpqQ05iSGpmQzZVaUlOK1dlZmFLTWhFdFJpMXN1?=
 =?utf-8?B?NEtKV3hDdThRRWJYWEZxVGJUUzFMVnR4SCt4OEtsYmhGQitMd3JrT2oxaG5R?=
 =?utf-8?B?QkRZSVpQdTdpQ1Y4ZVBGblI5K2F3S01waVNyaDAxRHJVVXN0LzR1cENYR3RJ?=
 =?utf-8?B?TTdiS2FzczlsSHlWWk5wUVdzL092RnRldVBvcG9LNXo1ZTVMdDl3a2pWU2w3?=
 =?utf-8?B?VmVxdHh1cUV5RUo3bCtCSXBIdjI3YXdydFNvOWZuS0Zna3Qwdmh0aHZyeUs1?=
 =?utf-8?B?ZllJakU1M2JkSnpmdWFXSk9JZ3A4d0JFRTZRSWU1c0tqMGdGSXoxYVIrQS9k?=
 =?utf-8?B?cnhxWUdlWWlOcVVqWkdNb21Bbm5ldmJQRm1KTUY5bHZPaXNQUjBzUDBTUFdS?=
 =?utf-8?B?OU16TFhaVm5UdzVOUzBsTmZ2MDBFMmVzSkVkTFBjVmpvNWdsaGFvalEzakRy?=
 =?utf-8?B?eDFzNDlGVW9QNEZ4dDErTWNKR1N0YnJTZUZ2SnJGTTZKQTRROVhsaTBhWWdF?=
 =?utf-8?B?SCtoM3BWNCs5WHF4OUJmQ0VCY29JdFVITEFwWGNla3hjbXp2UmtQRWdRWTBO?=
 =?utf-8?B?RnUwb3liS3ZFR1o2WDlSVVl3TE5HNjZPVHVsb2dZcGxUTTd1K1owMElqYWhU?=
 =?utf-8?B?YUR6RTlDaFNQSzFHOTNuYmdjL3hyWTVqdzlUR3JLWU9qNjQ2S056M2JDT0Fn?=
 =?utf-8?B?c0JqdUdtTDZyODIvZXlJYzgwa01ZRDF6d1U2Y3g1aFRYeENKcEZWaHMyMXh4?=
 =?utf-8?B?SHlhQkZCclZFUktrVUZ5bkNEYnNuRXBkQ2I4Vkx3QzN3OHFpZEpOUjAydDlx?=
 =?utf-8?B?M09uUWl4L3krVk5GQytiei80QUpSNFBNOVB2WWU5bGRjenZHWC9NbHFhaFNj?=
 =?utf-8?B?eVNzdlhEUjdJUjRud1BQMjJxWDJhRkZ3N0F6dC9PZHdERzN5blM0bGxSUlVq?=
 =?utf-8?B?WEQyc1B5Y09DSUd5dXBrTkJCSXo4VGo4dVNZblE2RlRwQVZvbDhLZDRueHZY?=
 =?utf-8?B?YkhOcnY2c0trR0EySk5ORDgvUi9hcGFjbXJGV1YyekpSQm9nL2pDb1lGL0hX?=
 =?utf-8?B?REY5UUdTbm51K0FCeUtXTEJVdUE0NGdpUk01dVRqSTRVM0prQUtDTU1YQ0Na?=
 =?utf-8?B?NUdMNUNOZ3FqV09WcWU3YTNWcThubXgycVhqVHIwY0l5dHhvN2tiNllQSVZZ?=
 =?utf-8?B?WFZYbzdpTHlLRzhHRFh1d3AwT3ZBdVdVNHJqaTlOcEdtUk0wRkhmdnhrT3d6?=
 =?utf-8?B?TXZ0V1l3cDBtdi9HamJxL3NheUtFZUNjOURXZk9zbGxkQkJoRFFLRkVvQ0tx?=
 =?utf-8?B?dytiVk83MmpoTXJHVTdwQ213VGNSd1NCSlVWazQ2eWthL0VJMFB3eUppdkF0?=
 =?utf-8?B?K0QxNGxnWTZneFBJRE9mVEVKeHlOdW1jaitUQnZWekgzL2dtUHlRWFM4dFlI?=
 =?utf-8?B?L2hocjBkODRHdlNUcHBINmlzYUYvRUthRldCZ040QVhCL1dKRExOeFlkeFR0?=
 =?utf-8?B?bmcvbnBzaFJvN3k4OG1BY0VrMjhNcndwaVZCOTlDNDRFN01lTFo4anM0RFA0?=
 =?utf-8?B?a2JXUHVuM3ZUdlJ2ZngyUmNoZXBSTGhGQVlMeE1QdDhkZnhPRmN6eDliVzJN?=
 =?utf-8?B?YlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 168e06d0-5a05-4230-9a46-08dc6ba00905
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 18:37:07.1414
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PuUvSU10bEGz/WrzpErr3s5mFppqqXcYSlMxldR8KIy8f8KX33zpHcswFYFzsVzcyrWdKmz8xOvSSCcGz1aVDVHNVn4G/5qwAd0uyh1mEOM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5872
X-OriginatorOrg: intel.com


On 5/3/2024 9:52 AM, John Hubbard wrote:
> On 5/3/24 1:00 AM, Ilpo Järvinen wrote:
>> On Thu, 2 May 2024, John Hubbard wrote:
> ...
>>> diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c
>>> index d67ffa3ec63a..c873793d016d 100644
>>> --- a/tools/testing/selftests/resctrl/mbm_test.c
>>> +++ b/tools/testing/selftests/resctrl/mbm_test.c
>>> @@ -33,7 +33,7 @@ show_bw_info(unsigned long *bw_imc, unsigned long *bw_resc, size_t span)
>>>         avg_bw_imc = sum_bw_imc / 4;
>>>       avg_bw_resc = sum_bw_resc / 4;
>>> -    avg_diff = (float)labs(avg_bw_resc - avg_bw_imc) / avg_bw_imc;
>>> +    avg_diff = (float)(avg_bw_resc - avg_bw_imc) / avg_bw_imc;
>>>       avg_diff_per = (int)(avg_diff * 100);
>>>         ret = avg_diff_per > MAX_DIFF_PERCENT;
>>
>> But how are these two cases same after your change when you ended up
>> removing taking the absolute value entirely?
> 
> All of the arguments are unsigned integers, so all arithmetic results
> are interpreted as unsigned, so taking the absolute value of that is
> always a no-op.

It does not seem as though clang can see when values have been casted.
I tried to do so explicitly with a:
 	avg_diff = labs((long)avg_bw_resc - avg_bw_imc) / (float)avg_bw_imc;

But that still triggers:
warning: taking the absolute value of unsigned type 'unsigned long' has no effect [-Wabsolute-value]

Looks like we may need to be more explicit types and not rely on casting so much
to make the compiler happy.

Reinette