Received-SPF: pass (google.com: domain of linux-kernel+bounces-168076-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <977ebfe0-4c12-4631-8309-a10d92e33fbd@intel.com>
Date: Fri, 3 May 2024 11:39:59 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] selftests/resctrl: fix clang build failure: use
 LOCAL_HDRS
To: John Hubbard <jhubbard@nvidia.com>, Shuah Khan <shuah@kernel.org>
CC: Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers
	<ndesaulniers@google.com>, Bill Wendling <morbo@google.com>, Justin Stitt
	<justinstitt@google.com>, Fenghua Yu <fenghua.yu@intel.com>, Valentin Obst
	<kernel@valentinobst.de>, <linux-kselftest@vger.kernel.org>, LKML
	<linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>,
	=?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
References: <20240503021712.78601-1-jhubbard@nvidia.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240503021712.78601-1-jhubbard@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVR3NlVQM3FndURpRGViUGlaOUJ5YmR2d1JJNmJKdE1kR1htblhjRXJxaHNm?=
 =?utf-8?B?WWxLcjNhQzJyZVBsUGxibXBjTmQ0dTE1Rm5TYlJwWHdVMUJhZXg2UVROQkR2?=
 =?utf-8?B?VE9sNk04SEEyUE9EQStCMmNpS3lPbWdDS3l3SlF6Wm5Kd3dPbjk4ZGRGZ2ow?=
 =?utf-8?B?VmVJN0hGcjU4TGJBMmFpOWc2ZWk0NDRnQTg3OVR2WStLNExCVDZlazBmQmRx?=
 =?utf-8?B?NmJoOENuZ01ySTE3WXU1ZVRqaUhEaFZMRFp3THVjd1AwTlBJckZSdGt3RWFK?=
 =?utf-8?B?V3dZbHVqWnFBUXdkNjFaMGoxQ2h3VVdISHZ6WGREWW1pZXlVQjZDQ0YyRmVE?=
 =?utf-8?B?UmFUZE15Q2xJTnd0SkFZWGNMbitydCszNnk2Q2NGS2trM093cm5ZSVlOaWJW?=
 =?utf-8?B?eXMyVGcxU3k4TXpac0U1ejRDeEFIbHZMcDhISWhkR0Q4aGplbWFvbS9oZVR6?=
 =?utf-8?B?N20rd2kzWklobzBxSDZaMU03ZFFnV2hXVXRzV3g2VlJnRnBBZlowTUVzUnZO?=
 =?utf-8?B?aFVnd1RPT216RWpGVU1uL2xWRm9oeGx2M3ErR1FZL0FUTGk2SEV0NUk4aHVV?=
 =?utf-8?B?MWt3ckdPeEY1NC93Rm9ZY2VpWHBFNzlQNHBRRWlwS2RVRlIrcW9tL0tERjV3?=
 =?utf-8?B?b2ZiSmVsZC8xRjBRaUVnQmZOeG1ncVdzUmxUTVdjcXZFUjlHdXI2RW00Skdy?=
 =?utf-8?B?cnhHVVBlYmErVUduMnd2bWhldmtlZ28zcFl4YjYzNTBObUdIRTI0SHB1VDdx?=
 =?utf-8?B?VVA4dStRVjVxdElWR2RYTTVyRFg5R004MENyUllzM2VXME5Zd3RtSFJoeEls?=
 =?utf-8?B?R20xQTl5R0hiRlQvb1NJSHdMWFdNVkxhMi9zTEUwUllRZ1p0UDVWSmdJdW14?=
 =?utf-8?B?YWVhZkR1WmlWZmhRN2tYZ0FJNEVWUjU3TWhXYkNtMzUxWklUVG5XdkwxWFZQ?=
 =?utf-8?B?YWQ5T0dOUDU4VjRVNmpmUExORFZGQVVabnl0N09nMmpwSHVDOFR1M3JBblc5?=
 =?utf-8?B?Q0ZZdFBQS1FxZ0UvV01vOGFxdzQ0UnFpVkkweEpwN2t5R3U3NjZLaVo5VkhP?=
 =?utf-8?B?ZThoU1BmT2hienNtSE1wMU5CMzVVZjdRVjRQaFRFWFd4azNwcWp4MldFVlBJ?=
 =?utf-8?B?S21LRFQ3TTBDYnQ5Q2VoNjU5NWVjZ3V1cStoS0RDNUdWUUhxODBmWWZuUVdC?=
 =?utf-8?B?N21yZW8yL0w1ZUpSMUZMNExjc1c4VnlmUUtDbEZpNHp0QzlPdEFBS2s5K3lq?=
 =?utf-8?B?ZHQ2ZGhnMEZocWdjWlZpUkNxV3V3eHhiMW8wcjZEUjlvMFdvaUZKQVFGN0hQ?=
 =?utf-8?B?RWdubnZFK3F1VkdzY1FXQ2FQVHVwYjhrUW5kUU5wOWxXQ1htRStGOENJYWFm?=
 =?utf-8?B?dGFmemkrM2JCZVN4UEhsWmJMS2JyeGUyRWo1NTgvWkxPV0ZWV093NHZTVXI0?=
 =?utf-8?B?L0ptWlRySGhkTHRBQ2ZEdVVnNTB1VmQzRk91OXBYQlhQRzlMTGFXTWkyQXR0?=
 =?utf-8?B?YlpPMHpZUklhZzd4cXhXSnUzWTdnWjdURVhSWmxFS2NuMmZTNjhlYmozdWZP?=
 =?utf-8?B?VGxPd2k4eXgrcTlyS2RISTRIYU5XUzY2b0dSVFR0M1hpd1I2WUVMTFpnb3VZ?=
 =?utf-8?B?NjYwMzcvcHJDUXJMTW5wR1drb281aGs0WGpGWGkwR2ZGZWdSUXZNbFpHVFI0?=
 =?utf-8?B?ZW0wSWxpQnZLMEZiWGcwSkhJaUNUZm9OUWtMQUFKSnIzS3diWkdrZEh1YlAz?=
 =?utf-8?B?ajdrS0NYb0RtSUFhMDZwdHNadGVNTk12V3RXZUhpdGtScG13LzErUWFHS2R0?=
 =?utf-8?B?Zjd5SlY1R2VzN0xVTHJFbDh3dk5HaUE5NTRTRTh0cWdqNk8vTHkzRTd5WGZ6?=
 =?utf-8?B?a0JpSVRtRXh5R0RBQmUxa1dQa3hEZHh2THNQdldEMnI1NVRsWjhrMUF1QjNs?=
 =?utf-8?B?MWR5cjlEemg1S2JmWDVLc2lVb1JnYWxqTzVXYStXbzBBT2llM2htMk4xYkFZ?=
 =?utf-8?B?NUdkRE9Uc3JrajdyWDZoRHo3ZHRRUkJSQnNvY2dBbTZYWEIzTmtzMU0zRFU1?=
 =?utf-8?B?cTAwaVdwVHpEVmxnVGtkQ01XMUNvT1BSOGdwa05xKzBhZFNCSWswZndBV1Va?=
 =?utf-8?B?M2dzbWxVQTkwOC9wN0RzLzlGWWlnTzhha3BCOStaM0NqQ3hZU3BEVTEzZkxP?=
 =?utf-8?B?Y2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 649207fe-1304-490c-fd2b-08dc6ba0718a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 18:40:02.4804
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /AIWpivDjjO/RETq31IvuV7Yd8KU74NL8/aIXpkPihsV4+54cUIv3YcuZJawN7I1IGQ2yGlfGU2fr976GF7gz7KIgl/ToV+Qoo7PT/mZh5k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7434
X-OriginatorOrg: intel.com


On 5/2/2024 7:17 PM, John Hubbard wrote:
> First of all, in order to build with clang at all, one must first apply
> Valentin Obst's build fix for LLVM [1]. Once that is done, then when
> building with clang, via:
> 
>     make LLVM=1 -C tools/testing/selftests
> 
> ...the following error occurs:
> 
>    clang: error: cannot specify -o when generating multiple output files
> 
> This is because clang, unlike gcc, won't accept invocations of this
> form:
> 
>     clang file1.c header2.h
> 
> Fix this by using selftests/lib.mk facilities for tracking local header
> file dependencies: add them to LOCAL_HDRS, leaving only the .c files to
> be passed to the compiler.
> 
> [1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/
> 
> Fixes: 8e289f454289 ("selftests/resctrl: Add resctrl.h into build deps")
> Cc: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---

Thank you.

Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette