Received-SPF: pass (google.com: domain of linux-kernel+bounces-168083-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 3 May 2024 20:46:26 +0200
From: Andi Shyti <andi.shyti@kernel.org>
To: Sai Pavan Boddu <sai.pavan.boddu@amd.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Michal Simek <michal.simek@amd.com>, 
	Lars-Peter Clausen <lars@metafoo.de>, Wolfram Sang <wsa@kernel.org>
Subject: Re: [PATCH v2] i2c: cadence: Avoid fifo clear after start
Message-ID: <c6knga4tuouxir67pzisf64oxfhcy53utunvxz53sbfg2zxfva@cj3r26sfudzb>
References: <20240503094208.296834-1-sai.pavan.boddu@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240503094208.296834-1-sai.pavan.boddu@amd.com>

Hi Sai Pavan,

On Fri, May 03, 2024 at 03:12:08PM +0530, Sai Pavan Boddu wrote:
> The Driver unintentionally programs ctrl reg to clear the fifo, which
> happens after the start of transaction. Previously, this was not an issue
> as it involved read-modified-write. However, this issue breaks i2c reads
> on QEMU, as i2c-read is executed before guest starts programming control
> register.
> 
> Fixes: ff0cf7bca630 ("i2c: cadence: Remove unnecessary register reads")
> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@amd.com>
> Acked-by: Michal Simek <michal.simek@amd.com>

pushed to i2c/i2c-host-fixes.

I will send it for pull request next week as this week is already
too late and I want to see a few rounds of tests before asking
Wolfram to take it.

Thanks,
Andi