Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp41527lqh; Fri, 3 May 2024 12:42:18 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVzJeLdESmaaOdwATX56AWb3wLDQ/nTwSIcIrkYbursb9vUuCLEeAww1OcmkUr7EnoRUWLDjCU4sshqs1l5/ZNjqsEJcgzYifFI8oEYLQ== X-Google-Smtp-Source: AGHT+IE49FRK4GipkRhUz8fKkG9fy0y74kme5bc1A4DKOZ4LG6f9/SDLYEq80C6U+kkaPIKiiXqj X-Received: by 2002:a17:902:d510:b0:1eb:76ac:b4e5 with SMTP id b16-20020a170902d51000b001eb76acb4e5mr4404917plg.49.1714765337755; Fri, 03 May 2024 12:42:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714765337; cv=pass; d=google.com; s=arc-20160816; b=Rj1B7UPThsUMg/pEn2sTnvakss/Ohn7q5PZKo3QrY9s8UX336SqHb5+cE9ApsZ+GbG 9SLF1jJpKdrTSvIEmfCVV65CzRnKRItHa16OfBxxU+aTp0mK0p/zyHMPbPgxuwi4vdcV Uk2CAD6IMaLE+Z/dTPkmoLA1E9aJmxwJuIJQIOXeQAMlE6tem7ku/t+MitS5p9epyREh psnjuU24Iq9wmG8q4qs8xrW2TeS4a6Y6OIsjNEIs3ttHCc9vrVi/kuwB5vLj2+yGUaUD 5tmRqEWOb3OideCWLob2yLOc1hx1jyWbTCyzl+N0GfgJJs+rDfLmF69EZ9rDHKWPmcxT qHbQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=isnNwgzpej5QkXxVDz6RxdNZolwJVMQ0OEWi8JJK3c8=; fh=Skv68UH59CZAOPkJs8KmIFbqGt4eLNLktRrRp9uyQkQ=; b=U/TcSj8ozNtjxrT8W8OMy12wsirvWSy29ZbSWMxcolSjcR3iVA+yD4ypRYc4XCSzur 6e4qIqyQ3aztEj0RudLheKxXCOHwdxq2MQYJeHNtjCaGbIKzTrMJ1kIRagSWhG/V858A +40XO/7wnZRR+kP+++O6xjkr3ItljCDa0BpkTJ8wnceyOH0plaGJvfouFwrSAXx/9Uy7 VUFynhFC9Cb3LJz3UW3CwyAR7RxtrvcnZbdsV+G0rPwlTmEarHnQLKnzJk9BRFpPnK23 n2Pn+Ca7igFCnsOqB+c6hdTDDgSfL7ejjLZO2MYTp7eL3LDpIlpLwyEeb17bppb1KidK N/mA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b="IrXHQso/"; arc=pass (i=1 spf=pass spfdomain=linuxfoundation.org dkim=pass dkdomain=linuxfoundation.org dmarc=pass fromdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-168146-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168146-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d3-20020a170902aa8300b001eccc6d3633si3419179plr.412.2024.05.03.12.42.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 May 2024 12:42:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-168146-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b="IrXHQso/"; arc=pass (i=1 spf=pass spfdomain=linuxfoundation.org dkim=pass dkdomain=linuxfoundation.org dmarc=pass fromdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-168146-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168146-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 22C73281C79 for ; Fri, 3 May 2024 19:42:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B5DF6158A21; Fri, 3 May 2024 19:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IrXHQso/" Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63D371586C1 for ; Fri, 3 May 2024 19:42:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714765331; cv=none; b=bL4gKAgzlY46UggRW6xNhd+AF+Dc4/xnJlyLSDxckOLtS/vGclYPBPKY2QqoQvpYzRSx6zu4rwjkVtjCucoI3QzsRqOJWcVokmKOvnN9zuqlbwUi9NMDW14eM42jkB9re4+gIGylB+SNEXIQgUJu+LaCQa4twAGzD+1tSN2dk9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714765331; c=relaxed/simple; bh=lmgSiRO/qeWY2rx3mwtsVmBlqWlnJWkwnyepOJ7YHs4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FuuIVYxP86oy4/4ME6r+qIN13a0DUem258dVTJ7xk842FEpSPUPtPo0ezHZydBmW8MAO/qe735xQfH3oAckP4Onl3/rMnTm8O90ZF9asmuRP/HwtD1Hmyrx5BW1kc6CBYZEFOkV8ZTRrTajQo7BbZ2CBxfyUoucmbpv+01FD+GY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IrXHQso/; arc=none smtp.client-ip=209.85.166.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-7d9c78d7f97so184839f.3 for ; Fri, 03 May 2024 12:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1714765329; x=1715370129; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=isnNwgzpej5QkXxVDz6RxdNZolwJVMQ0OEWi8JJK3c8=; b=IrXHQso/djxTaGVRQVaL6eY7k0DqNt4AQj4iPIdo/DBGq1/waMHcvBjmHfkge53yoA Xm5pkX6X5wjaJNw34/ydyZJkohHgcpUdxtbooDLLi3pOItibFjWOgYQOxI47pYRf4O9e Y0qiAidljMSuNVuSTnhT2+C3qBZJe9VfFn38o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714765329; x=1715370129; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=isnNwgzpej5QkXxVDz6RxdNZolwJVMQ0OEWi8JJK3c8=; b=sY2XJmLPXQzhOSSSpc2zSE/87gQh5+v/4sgMgZqlV9XgYu7//UKnIoRnFv9pgKml+5 k2KpiwnyzmDveK+EZZaCVTvd5r5O+Cn5YsQoxbc63bqAo8lBGo8mDv+AWk4KSWgEBMGt m4jBIoPbFP9gqVDBAvGTEbh8KYmDY099+6W1BsM6S807YXL2jtU5OAQ4HTC99cas8TCf 34PefVvVJgroiRpwVhSDMXgDN3+kIhMzSkcnidYJZd4Fb/BrePsegJj/ykHtLbrKMLTq WHQoXztgbWuZnAI/DJrrgnTiI2zCm59ooxCGN1C3VaShRRMM+0HamkjmTiyS34j+jhoI +knw== X-Gm-Message-State: AOJu0Yy5wtka/YDhuLPIieaVUoHOoFGNh9KkP1wSOrAlQLQxdrw6zsoh i3FdazPjwKyI2mKraJ8D32mwAkK1hhfohHjgOqTWD4ZsZe+7hVWssrjpRymt3xqVHevE/LxZNE1 QfNA= X-Received: by 2002:a05:6e02:219c:b0:36b:15e0:de18 with SMTP id j28-20020a056e02219c00b0036b15e0de18mr4188255ila.0.1714765329490; Fri, 03 May 2024 12:42:09 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id i8-20020a056e021b0800b0036c6ad53d1dsm790397ilv.50.2024.05.03.12.42.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 May 2024 12:42:09 -0700 (PDT) Message-ID: Date: Fri, 3 May 2024 13:42:08 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftest/tty: Use harness framework in tty To: Shengyu Li , shuah@kernel.org Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20240430150508.82467-1-shengyu.li.evgeny@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240430150508.82467-1-shengyu.li.evgeny@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/30/24 09:05, Shengyu Li wrote: > Similarly, this one is based on automated tools and a very > small percentage of manual modifications to automatically refactor > the version that uses kselftest_harness.h, which is logically clearer. > Similar to what? How does refactoring help? Follow the imperative mood to write change logs: https://www.kernel.org/doc/html/latest/process/submitting-patches.html > Signed-off-by: Shengyu Li > --- thanks, -- Shuah