Received-SPF: pass (google.com: domain of linux-kernel+bounces-168174-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 3 May 2024 17:21:08 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	James Clark <james.clark@arm.com>,
	Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
	Colin Ian King <colin.i.king@gmail.com>,
	nabijaczleweli@nabijaczleweli.xyz, Leo Yan <leo.yan@linux.dev>,
	Song Liu <song@kernel.org>,
	Ilkka Koskinen <ilkka@os.amperecomputing.com>,
	Ben Gainey <ben.gainey@arm.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	Yanteng Si <siyanteng@loongson.cn>,
	Sun Haiyong <sunhaiyong@loongson.cn>,
	Changbin Du <changbin.du@huawei.com>,
	Andi Kleen <ak@linux.intel.com>,
	Thomas Richter <tmricht@linux.ibm.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Dima Kogan <dima@secretsauce.net>,
	zhaimingbing <zhaimingbing@cmss.chinamobile.com>,
	Paran Lee <p4ranlee@gmail.com>, Li Dong <lidong@vivo.com>,
	Tiezhu Yang <yangtiezhu@loongson.cn>,
	Yang Jihong <yangjihong1@huawei.com>,
	Chengen Du <chengen.du@canonical.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/7] perf dsos: Switch backing storage to array from
 rbtree/list
Message-ID: <ZjVHNB7pTKKWERFn@x1>
References: <20240429184614.1224041-1-irogers@google.com>
 <20240429184614.1224041-2-irogers@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240429184614.1224041-2-irogers@google.com>

On Mon, Apr 29, 2024 at 11:46:08AM -0700, Ian Rogers wrote:
> DSOs were held on a list for fast iteration and in an rbtree for fast
> finds. Switch to using a lazily sorted array where iteration is just
> iterating through the array and binary searches are the same
> complexity as searching the rbtree. The find may need to sort the
> array first which does increase the complexity, but add operations
> have lower complexity and overall the complexity should remain about
> the same.

With just this first one applied:

⬢[acme@toolbox perf-tools-next]$ git log --oneline -10
325557715f1d8593 (HEAD) perf dsos: Switch backing storage to array from rbtree/list
7b6dd7a923281a7c perf pmu: Assume sysfs events are always the same case
6debc5aa326fa2ee perf test pmu: Test all sysfs PMU event names are the same case
18eb2ca8c18f0612 perf test pmu: Add an eagerly loaded event test
aa1551f299ba414c perf test pmu: Refactor format test and exposed test APIs
785623ee855e893d perf Document: Sysfs event names must be lower or upper case
97c48ea8ff1cd70f perf test pmu-events: Make it clearer that pmu-events tests JSON events
3cdd98b42d212160 (x1/perf-tools-next) perf maps: Remove check_invariants() from maps__lock()
e3123079b906dc2e perf cs-etm: Improve version detection and error reporting
bc5e0e1b93565e37 perf cs-etm: Remove repeated fetches of the ETM PMU
⬢[acme@toolbox perf-tools-next]$

root@number:~# perf -v
perf version 6.9.rc5.g325557715f1d
root@number:~# perf probe -l
DSO [kernel.kallsyms] is still in rbtree when being deleted!
DSO /lib/modules/6.8.7-200.fc39.x86_64/kernel/drivers/hid/hid-sensor-hub.ko.xz is still in rbtree when being deleted!
DSO /lib/modules/6.8.7-200.fc39.x86_64/kernel/drivers/hid/uhid.ko.xz is still in rbtree when being deleted!
DSO /lib/modules/6.8.7-200.fc39.x86_64/kernel/drivers/net/tun.ko.xz is still in rbtree when being deleted!
DSO /lib/modules/6.8.7-200.fc39.x86_64/kernel/fs/overlayfs/overlay.ko.xz is still in rbtree when being deleted!
DSO /lib/modules/6.8.7-200.fc39.x86_64/kernel/net/bluetooth/rfcomm/rfcomm.ko.xz is still in rbtree when being deleted!
DSO /lib/modules/6.8.7-200.fc39.x86_64/kernel/drivers/input/misc/uinput.ko.xz is still in rbtree when being deleted!
DSO /lib/modules/6.8.7-200.fc39.x86_64/kernel/sound/core/seq/snd-seq-dummy.ko.xz is still in rbtree when being deleted!
<SNIP a lot of other modules, probably all of them>

Then with:

65e1e704f37916a0 (HEAD -> perf-tools-next) perf dsos: Switch hand code to bsearch
64377d6b7d5f9a71 perf dsos: Remove __dsos__findnew_link_by_longname_id
8e773b8be95aff66 perf dsos: Remove __dsos__addnew
b1d064fc9b912ece perf dsos: Switch backing storage to array from rbtree/list

applied it continues like that, the next patch in line isn't applying.

I'll push what I have to tmp.perf-tools-next.

- Arnaldo