Received-SPF: pass (google.com: domain of linux-kernel+bounces-168182-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 3 May 2024 13:33:09 -0700
From: Alison Schofield <alison.schofield@intel.com>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>, Fan Ni <fan.ni@samsung.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Navneet Singh <navneet.singh@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Vishal Verma <vishal.l.verma@intel.com>,
	linux-btrfs@vger.kernel.org, linux-cxl@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/26] cxl/core: Simplify cxl_dpa_set_mode()
Message-ID: <ZjVKBYhiCSWA89s0@aschofie-mobl2>
References: <20240324-dcd-type2-upstream-v1-0-b7b00d623625@intel.com>
 <20240324-dcd-type2-upstream-v1-5-b7b00d623625@intel.com>
 <ZhSPHvoTHl28GXt1@aschofie-mobl2>
 <6635366717079_e1f582941d@iweiny-mobl.notmuch>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6635366717079_e1f582941d@iweiny-mobl.notmuch>

On Fri, May 03, 2024 at 12:09:27PM -0700, Ira Weiny wrote:

snip

> 
> > > diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
> > > index 7d97790b893d..66b8419fd0c3 100644
> > > --- a/drivers/cxl/core/hdm.c
> > > +++ b/drivers/cxl/core/hdm.c
> > > @@ -411,44 +411,35 @@ int cxl_dpa_set_mode(struct cxl_endpoint_decoder *cxled,
> > >  	struct cxl_memdev *cxlmd = cxled_to_memdev(cxled);
> > >  	struct cxl_dev_state *cxlds = cxlmd->cxlds;
> > >  	struct device *dev = &cxled->cxld.dev;
> > > -	int rc;
> > >  
> > > +	guard(rwsem_write)(&cxl_dpa_rwsem);
> > > +	if (cxled->cxld.flags & CXL_DECODER_F_ENABLE)
> > > +		return -EBUSY;
> > > +
> > > +	/*
> > > +	 * Check that the mode is supported by the current partition
> > > +	 * configuration
> > > +	 */
> > >  	switch (mode) {
> > >  	case CXL_DECODER_RAM:
> > > +		if (!resource_size(&cxlds->ram_res)) {
> > > +			dev_dbg(dev, "no available ram capacity\n");
> > > +			return -ENXIO;
> > > +		}
> > > +		break;
> > >  	case CXL_DECODER_PMEM:
> > > +		if (!resource_size(&cxlds->pmem_res)) {
> > > +			dev_dbg(dev, "no available pmem capacity\n");
> > > +			return -ENXIO;
> > > +		}
> > >  		break;
> > >  	default:
> > >  		dev_dbg(dev, "unsupported mode: %d\n", mode);
> > >  		return -EINVAL;
> > >  	}
> > >  
> > 
> > delete extra line
> 
> You don't like the space following the switch?
> 
> Ira

Sorry - looks fine. Ignore my comment.