Received-SPF: pass (google.com: domain of linux-kernel+bounces-168221-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 3 May 2024 14:11:17 -0700
From: Shakeel Butt <shakeel.butt@linux.dev>
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>, 
	Muchun Song <muchun.song@linux.dev>, Johannes Weiner <hannes@cmpxchg.org>, 
	Michal Hocko <mhocko@kernel.org>, Frank van der Linden <fvdl@google.com>, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/4] mm: memcg: merge multiple page_counters into a
 single structure
Message-ID: <vpkrdo4tbighfh3o3lrr4kfwxcauxpqzktthacj5chqkdkwiqc@h2dmudmh43d5>
References: <20240503201835.2969707-1-roman.gushchin@linux.dev>
 <20240503201835.2969707-3-roman.gushchin@linux.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240503201835.2969707-3-roman.gushchin@linux.dev>

On Fri, May 03, 2024 at 01:18:33PM -0700, Roman Gushchin wrote:
[...]
>  enum mem_counter_type {
> +#ifdef CONFIG_MEMCG
>  	MCT_MEMORY,		/* cgroup v1 and v2 */
>  	MCT_SWAP,		/* cgroup v2 only */
>  	MCT_MEMSW = MCT_SWAP,	/* cgroup v1 only */
>  	MCT_KMEM,		/* cgroup v1 only */
>  	MCT_TCPMEM,		/* cgroup v1 only */
> +#endif
> +#ifdef CONFIG_CGROUP_HUGETLB
> +	MCT_HUGETLB_MAX = __MCT_HUGETLB_MAX,
> +#endif
> +	__MCT_NR_ITEMS,
>  };
>  

Thanks for the awesome work. I haven't gone through all the patches yet
but wanted to ask a quick question. In the above enum are you trying to
do a union between memcg and hugetlb? It gave me a big pause to
understand what you are trying to do.