Received-SPF: pass (google.com: domain of linux-kernel+bounces-168227-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 3 May 2024 17:14:16 -0400
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Easwar Hariharan <eahariha@linux.microsoft.com>
CC: Jani Nikula <jani.nikula@linux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@linux.intel.com>, Tvrtko Ursulin <tursulin@ursulin.net>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, "Zhenyu
 Wang" <zhenyuw@linux.intel.com>, Zhi Wang <zhi.wang.linux@gmail.com>, "open
 list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS"
	<intel-gfx@lists.freedesktop.org>, "open list:INTEL DRM DISPLAY FOR XE AND
 I915 DRIVERS" <intel-xe@lists.freedesktop.org>, "open list:DRM DRIVERS"
	<dri-devel@lists.freedesktop.org>, open list <linux-kernel@vger.kernel.org>,
	"open list:INTEL GVT-g DRIVERS (Intel GPU Virtualization)"
	<intel-gvt-dev@lists.freedesktop.org>, Wolfram Sang
	<wsa+renesas@sang-engineering.com>, "open list:RADEON and AMDGPU DRM DRIVERS"
	<amd-gfx@lists.freedesktop.org>, "open list:DRM DRIVER FOR NVIDIA
 GEFORCE/QUADRO GPUS" <nouveau@lists.freedesktop.org>, "open list:I2C
 SUBSYSTEM HOST DRIVERS" <linux-i2c@vger.kernel.org>, "open list:BTTV
 VIDEO4LINUX DRIVER" <linux-media@vger.kernel.org>, "open list:FRAMEBUFFER
 LAYER" <linux-fbdev@vger.kernel.org>, Zhi Wang <zhiwang@kernel.org>
Subject: Re: [PATCH v2 03/12] drm/i915: Make I2C terminology more inclusive
Message-ID: <ZjVTqNGjaAjuLdLi@intel.com>
References: <20240503181333.2336999-1-eahariha@linux.microsoft.com>
 <20240503181333.2336999-4-eahariha@linux.microsoft.com>
 <ZjU8NB-71xWI2X73@intel.com>
 <4f1e429c-794b-457c-ab1d-85eb97dc81c3@linux.microsoft.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <4f1e429c-794b-457c-ab1d-85eb97dc81c3@linux.microsoft.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NHgdIf24jEKA2yJx1GhEM6Olo4fhy2u4vavwMFeveHHGwF1Mi8DnkJCTAqn3?=
 =?us-ascii?Q?l2SKvcARmmr5d4vEY9FGfTRm8Y68koLgl2YlkZxhsm0tGVLwlUv553WV98rY?=
 =?us-ascii?Q?rYMlH1hv14Pvk+NXSkjqdUfy9k3eFL58a0b1HS9rUjdtxv8JaavIJLDBiRNS?=
 =?us-ascii?Q?0ybcNkPYFt4HGByLdzbfSJBt1ncRf5ohwEJV7ZlsfH42p/NQVVQJqBtWMMUO?=
 =?us-ascii?Q?yA0XZXAPtNme5XDElOInhH/29iO/tyWo+NvX62T0yYfpdwzB0W8rtco/ndLA?=
 =?us-ascii?Q?fngMjhmhCQQAuQoriEnQ/FWyBfY/PPd/UqZeFobiIQ5FL1KodePSzugaiRbo?=
 =?us-ascii?Q?T4OSiJeWgQwqD1Q0juhjbbJnoBKGHw/njFLzg33fA/rcDs4rGn3fyBMbz2mG?=
 =?us-ascii?Q?/qmipD8dbg+fjFzK6Jgj+Y5IKWLzzZ4EuqkGdJpclSGOVn21ntOTAWwdTDf6?=
 =?us-ascii?Q?p3k+0NTLqI7SLPKWyFhqwZ4JHfzRTLemWQIuqItHRc0/zDnKi7HjzOkXM87x?=
 =?us-ascii?Q?TVAt5TDE0R3FOHOfeEK19Tc5ydmguMjKeLucGBgCvAfsk2DiSACdkKEiBHky?=
 =?us-ascii?Q?f2KPvbFUe4v5orr06QwiSaGAGyIT7Qh5nfINMebp/8ai9ZcNvcOZAHFEoSek?=
 =?us-ascii?Q?WEPi+vXA37dC3ZXeubTlzpHEH0eFWMyqaVPPshCa6oawmwX1Vbs6aPdX6imG?=
 =?us-ascii?Q?r/OamZFrHyKkptDBqEXlG/HVGvV2agQvQgj23eXI9KQiJEQhgENVjhz2VhlI?=
 =?us-ascii?Q?gKJxUY+zKn40X9hAYOXAhRlFZlTmIh55HMDF9yl4bpOEl3MF1OnZyKThuBvH?=
 =?us-ascii?Q?TxMIWbp4Ha0NcYECNWCUgMyxCuhKSnbC6/BNrq7clVrBLUNxRi29oUSvOB0Z?=
 =?us-ascii?Q?7p5bpo1FX8uFJIG49F4cIrWgDt/KPWGBRFoTcP3mQ9ad5lF6O1LUCe1L7bcO?=
 =?us-ascii?Q?sHpl0fei1UgxAv7/ujOlYxkCKnm34jeCb/Z8QYb3cpFoci6Lucc6JmLP8Jys?=
 =?us-ascii?Q?zmYb7dpwb8vNLQ4HIrF+iCEHCFahCAgzmmXAebsc52aoN/MAtZDEsXiRU2H1?=
 =?us-ascii?Q?OphDHwNP7xj7rFVpjQvXHHRvM1P8pr6Ip3/IZ4g03DYmvOb8CkYMvrZofQsF?=
 =?us-ascii?Q?NyjqvKtj/z6GqUiCBVb7z/VYZE+eUdX/5/xfC8NTYzBdsYZiCbNCyidsfmRm?=
 =?us-ascii?Q?IxFk6WTKAKjdLAHAPjIyyIixbZxE9S8LsvjLiZF+ZNX6ktu3HhMvMIKXgf40?=
 =?us-ascii?Q?W2f74cvDB6z/+r72GfxkT2qFW/SS5Jwtt6Zp4mhUtJ9alKIkI1AMn2p9QMDC?=
 =?us-ascii?Q?zH5ldjfs/iDy9FcQeAp2I4GXq1rDhWqFkzHsAz2lSpZKkzmfOViznX30jR43?=
 =?us-ascii?Q?TAMEcPMDpsuTNjlX4H2i9vppxv1YrVzK21OCPMX6kBRySOJvApjQzPG2n7sW?=
 =?us-ascii?Q?dQf76mAEn3fQYXPP/ysbZWE291U28+RbVwfe4kJqYuTpH97EV1kzkRsocyvA?=
 =?us-ascii?Q?oY3hmf2xDUXnJVBP1kyycj9bkfgUdGG9zTNgtFaJnYOGj8aIf608h/LJBCrb?=
 =?us-ascii?Q?hFYSZMqoBbZUpcru8DiWOItoRVpyq72daYGbMD6mgtRsAOgcyxLWJY9TQGZN?=
 =?us-ascii?Q?GA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c409221-61e9-43fe-fa8c-08dc6bb6010c
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 21:14:22.7401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qFtfZwOtDtkOvX1Wxw5BqkoYON222k6SKEZj5+0WQJkrC+Fxadgm8gP0cqgJ7U4OhJTLiSaXRZgTJfav9jVOyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4842
X-OriginatorOrg: intel.com

On Fri, May 03, 2024 at 02:04:15PM -0700, Easwar Hariharan wrote:
> On 5/3/2024 12:34 PM, Rodrigo Vivi wrote:
> > On Fri, May 03, 2024 at 06:13:24PM +0000, Easwar Hariharan wrote:
> >> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave"
> >> with more appropriate terms. Inspired by and following on to Wolfram's
> >> series to fix drivers/i2c/[1], fix the terminology for users of
> >> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists
> >> in the specification.
> >>
> >> Compile tested, no functionality changes intended
> >>
> >> [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/
> >>
> >> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > 
> > It looks like the ack is not needed since we are merging this through
> > drm-intel-next. But I'm planing to merge this only after seeing the
> > main drivers/i2c accepting the new terminology. So we don't have a
> > risk of that getting push back and new names there and we having
> > to rename it once again.
> 
> Just to be explicit, did you want me to remove the Acked-by in v3, or will you when you pull
> the patch into drm-intel-next?
> 
> > 
> > (more below)
> > 
> >> Acked-by: Zhi Wang <zhiwang@kernel.org>
> >> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
> > 
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > 
> > Jani, what bits were you concerned that were not necessarily i2c?
> > I believe although not necessarily/directly i2c, I believe they
> > are related and could benefit from the massive single shot renable.
> > or do you have any better split to suggest here?
> > 
> > (more below)
> > 
> >> ---
> >>  drivers/gpu/drm/i915/display/dvo_ch7017.c     | 14 ++++-----
> >>  drivers/gpu/drm/i915/display/dvo_ch7xxx.c     | 18 +++++------
> >>  drivers/gpu/drm/i915/display/dvo_ivch.c       | 16 +++++-----
> >>  drivers/gpu/drm/i915/display/dvo_ns2501.c     | 18 +++++------
> >>  drivers/gpu/drm/i915/display/dvo_sil164.c     | 18 +++++------
> >>  drivers/gpu/drm/i915/display/dvo_tfp410.c     | 18 +++++------
> >>  drivers/gpu/drm/i915/display/intel_bios.c     | 22 +++++++-------
> >>  drivers/gpu/drm/i915/display/intel_ddi.c      |  2 +-
> >>  .../gpu/drm/i915/display/intel_display_core.h |  2 +-
> >>  drivers/gpu/drm/i915/display/intel_dsi.h      |  2 +-
> >>  drivers/gpu/drm/i915/display/intel_dsi_vbt.c  | 20 ++++++-------
> >>  drivers/gpu/drm/i915/display/intel_dvo.c      | 14 ++++-----
> >>  drivers/gpu/drm/i915/display/intel_dvo_dev.h  |  2 +-
> >>  drivers/gpu/drm/i915/display/intel_gmbus.c    |  4 +--
> >>  drivers/gpu/drm/i915/display/intel_sdvo.c     | 30 +++++++++----------
> >>  drivers/gpu/drm/i915/display/intel_vbt_defs.h |  4 +--
> >>  drivers/gpu/drm/i915/gvt/edid.c               | 28 ++++++++---------
> >>  drivers/gpu/drm/i915/gvt/edid.h               |  4 +--
> >>  drivers/gpu/drm/i915/gvt/opregion.c           |  2 +-
> >>  19 files changed, 119 insertions(+), 119 deletions(-)
> >>
> 
> <snip>
> 
> >> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> >> index c17462b4c2ac..64db211148a8 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> >> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> >> @@ -4332,7 +4332,7 @@ static int intel_ddi_compute_config_late(struct intel_encoder *encoder,
> >>  									connector->tile_group->id);
> >>  
> >>  	/*
> >> -	 * EDP Transcoders cannot be ensalved
> >> +	 * EDP Transcoders cannot be slaves
> > 
> >                                      ^ here
> > perhaps you meant 'targeted' ?
> > 
> >>  	 * make them a master always when present
> 
> <snip>
> 
> This is not actually I2C related as far as I could tell when I was making the change, so this was more of a typo fix.
> 
> If we want to improve this, a quick check with the eDP v1.5a spec suggests using primary/secondary instead,
> though in a global fashion rather than specifically for eDP transcoders. There is also source/sink terminology
> in the spec related to DP encoders.
> 
> Which would be a more acceptable change here?

hmmm probably better to split the patches and align with the spec naming where it applies.
and with i2c name where it applies.

> 
> Thanks,
> Easwar