Received-SPF: pass (google.com: domain of linux-kernel+bounces-168230-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d7f3c5b1-c39d-4c66-92c3-5b096b9e0579@intel.com>
Date: Fri, 3 May 2024 14:15:08 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v3 00/17] x86/resctrl : Support AMD Assignable
 Bandwidth Monitoring Counters (ABMC)
To: Peter Newman <peternewman@google.com>, <babu.moger@amd.com>
CC: <corbet@lwn.net>, <fenghua.yu@intel.com>, <tglx@linutronix.de>,
	<mingo@redhat.com>, <bp@alien8.de>, <dave.hansen@linux.intel.com>,
	<x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<maciej.wieczor-retman@intel.com>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <eranian@google.com>, <james.morse@arm.com>
References: <cover.1711674410.git.babu.moger@amd.com>
 <CALPaoCjZ3oLdKymJjASt0aqtd0GGOme7LavvYOtPYTb_rA-mYQ@mail.gmail.com>
 <b35dc4e9-7e8b-42ed-9a51-ae50d521cf4b@amd.com>
 <CALPaoChxYoJx8eR48EkSKf-hu2p2myQJLZEhj_Pq6O4R15-=5A@mail.gmail.com>
 <6edffe1b-e9a9-4995-8172-353efc189666@amd.com>
 <ab2a6a4b-3740-47c6-9443-e6bb7a0c1adb@intel.com>
 <CALPaoCiYFKeASPMDwzzaHLw4JiMtBB6DTyVPgt0Voe3c3Tav_A@mail.gmail.com>
 <b725e4ca-8602-eb26-9d47-914526621f52@amd.com>
 <CALPaoCiu2_UHyGjsyitz28BL1N93TSn28E1r-6nhXg--bzmU+Q@mail.gmail.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <CALPaoCiu2_UHyGjsyitz28BL1N93TSn28E1r-6nhXg--bzmU+Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1A1VUlTMXREeWVDMmY2a0FTeFR2MmdJTFBLU2lQVlJsd1JGNnpqTDJ4bElv?=
 =?utf-8?B?ckNQOEhwMWdtNGRpaUtuOEtvejlzcXV5U3VkOGdnWWFoWWJVZnlYL2s5dHFl?=
 =?utf-8?B?OUw0NVluTkpYL1d6VVJFYldCRU5Yek9BU0FLUnM2WEhjdlBhSnMrOG1kelBl?=
 =?utf-8?B?Vms1ZDg2RUYzM1F5OFlZNzdCMnZQRE5FTlZFYU92djZLcmxzTHpJa2MzeFJW?=
 =?utf-8?B?MXRKdFhSenduZ0xVQWZVSVNJd1JFZlkrVjkrbGJDNld4MlNIcUZpdXB6V2I5?=
 =?utf-8?B?RFZwckJUTFNPem1vSVhSTFRTS3VOR0ZaVU01MWxJbnV4aElOOURFc2NMT3Vt?=
 =?utf-8?B?cFhCcGwzZ094R0NnRUlmNjNVTFU5VzN2bFVXdGNRYVA4a0pLOU1aVDlHcm4w?=
 =?utf-8?B?SU53MGNUMWo5ZStGSVVTY0tGdHB5OWxHLytCUE9QWnpCOStmZm94ZmtqY1pj?=
 =?utf-8?B?NlhNQjM3WFRyQ0tkT04ra1doSjY4OENkVURWQXA0SlBxMmlpc3FxZkppL1h6?=
 =?utf-8?B?UVZPdjVFako4MnEzMzhDWkMwK1NsbmlpWlhLenAyMjVyc3NubUtqUHN6UmNI?=
 =?utf-8?B?OGJ2S2JXVm9yRUthcG9ReksydGVKMHZVN2JMRFl6eWFEdEpVbDF1Rlk2RWJs?=
 =?utf-8?B?N3orem9UaUY1TlVBMDlBdmF0U0R2Wkp1U0poQy9Va3B2SHZpdDIvNHREZzJ6?=
 =?utf-8?B?d3ZOSCtPM0EvR2ZjMy9GT2NkMlQ2NGU0UlIyK1dvRTUrWUs4MEV1Ykt0UEpt?=
 =?utf-8?B?a3U5TnBQQzE5R2pXZUJFL1UzS0hoemhqa2dBT2FDMGpIZEdYQ0lTNEVibWNI?=
 =?utf-8?B?bmRpZENUUUpSR2RYRkI5ZlRvNGswMmF0VFgyMWlraVIxM3lDbXk1S09RQkgy?=
 =?utf-8?B?cjdSR012YTh6U1Vpd3B1RStVWFNraDZqc1Z2bXdqUVNqbW9PUnVyb0lTbm1K?=
 =?utf-8?B?ejNyd1ArU3lhQmJrdEN0V0ZDTU5oV2lnUXBMc0hUNklLaXhPUzBmUzY5emJJ?=
 =?utf-8?B?cUlqdmlEVVdDSGczcXdPaEFVYzljTS9tT0NSRHZWS0pNM244MmVIUlFNbGJR?=
 =?utf-8?B?Wkx3dHZabDBSYnRUdnZPT0laQ3dvNlMyL1RjdE16dDRNSm9EaVMxRnI1UURm?=
 =?utf-8?B?VWZ3S1RDOXZ6bWlaRUpITEpxNjNrdnBpblplYkVZTGRQRXZES3h4WnljcldP?=
 =?utf-8?B?a3Z3YjRkNDZpV282QTR0cjFqNzFRMFNSampBTXU4MDRKWDVCc3lmNWVTVTBX?=
 =?utf-8?B?TnlmelpjSTIvazFOTkJhSjQxY1ZmYmFma25pNjc3SWdHREpuOXlHNnIxMTk0?=
 =?utf-8?B?SFBhanFJWFh0VmFsVkx2eXkzWHlpa1U0MEFiRERZaEphaWZaelJCZWIwTXZP?=
 =?utf-8?B?d0dUQXBvbzVuWTFscGxxRHBBQlU5OE52ZjNYNTIwa2tIRWdxY01HWDlJK251?=
 =?utf-8?B?MUQrQUZaanhJWWRhTzZyK2xoM3NDbHVvMzNnRE94cXZZMWcyb0pia2Nwak8v?=
 =?utf-8?B?WExCTFEzc3Y0MFRGYXNScS9UVE44Z01PWkMrV29Hdk9Qak1NcW1PcGN3b2ow?=
 =?utf-8?B?OFlhS0dzQ2k3QkJuUGx6WDJyK01TV0drWFRnaDg2YUIvRlUxVU5Uc2YyR3hW?=
 =?utf-8?B?dkxqcUFGaG5iQVBzSnVraDk0Q2lMemZiNGU1WFBtdUlRcklhODZma2hxZzlr?=
 =?utf-8?B?b0V1T0x5NE5nZ1RpUlpQVHc1VW1XUDVhUVdBUlgyQnVVWnQrOG4wV0p2N2g5?=
 =?utf-8?B?ZzE4bmNhcHlJOEZkY2kxK3R1QWFGa0pEZ0tYdThZSWdXcGRPVldibmNCMlVG?=
 =?utf-8?B?V2ZoZEVLUVVZM0VVa2QyUDhmeVRVeGlkVDZaclVSeVRmcVNCVVpiRU1qanJB?=
 =?utf-8?B?eGJBczRSaDdIZkdRaE1RNlM1OGtGVnFmSkh6Sm0zVFJnOUgxRldJWnpSMDlu?=
 =?utf-8?B?YnE3REluUzhGSjlGbzg4eHRRSVpYaG9XUU9HT1V2d04yUjRNQlErbEp6b2cy?=
 =?utf-8?B?Zjc3T25FMmgvNnZwdDRMMVlWaWU1VFYzTzVaOEIzMG85bU9BU3kxTVByblBW?=
 =?utf-8?B?RE5QY1ZYdUdPd21EaVNJVGQyZVJnYTFNM0NJUVhDVVlJVEZUZHEwaXhzSkMx?=
 =?utf-8?B?R0RHSE8vOWt2MktNWmVZSkphUDR2V210U2ZnaTdjQ3JLZlFkS1AzcjRNVVBl?=
 =?utf-8?B?QVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bfbcc23d-d50d-441c-5a9f-08dc6bb61e79
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 21:15:12.0383
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hnu0gvBkwhyo3jCewQ8i41XSmopnV52+IIDgjCfWi3Din8jN9fKHWVyyNSDjvnRjkteCPriV+1vNF6n9ixLqoBdAPOXghCWopTZ7yiFAZ18=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6218
X-OriginatorOrg: intel.com

Hi Peter,

On 5/3/2024 2:00 PM, Peter Newman wrote:
> Hi Babu,
> 
> On Fri, May 3, 2024 at 1:44 PM Moger, Babu <bmoger@amd.com> wrote:
>>
>> Hi Peter,
>>
>> On 5/2/2024 7:57 PM, Peter Newman wrote:
>>> Hi Reinette,
>>>
>>> On Thu, May 2, 2024 at 4:21 PM Reinette Chatre
>>>> I do think ABMC should be enabled by default when available and it looks
>>>> to be what this series aims to do [1]. The way I reason about this is
>>>> that legacy user space gets more reliable monitoring behavior without
>>>> needing to change behavior.
>>>
>>> I don't like that for a monitor assignment-aware user, following the
>>> creation of new monitoring groups, there will be less monitors
>>> available for assignment. If the user wants precise control over where
>>> monitors are allocated, they would need to manually unassign the
>>> automatically-assigned monitor after creating new groups.
>>>
>>> It's an annoyance, but I'm not sure if it would break any realistic
>>> usage model. Maybe if the monitoring agent operates independently of
>>
>> Yes. Its annoyance.
>>
>> But if you think about it, normal users don't create too many groups.
>> They wont have to worry about assign/unassign headache if we enable
>> monitor assignment automatically. Also there is pqos tool which uses
>> this interface. It does not have to know about assign/unassign stuff.
> 
> Thinking about this again, I don't think it's much of a concern
> because the automatic assignment on mongroup creation behavior can be
> trivially disabled using a boolean flag.

This could be a config option.

Reinette