Received-SPF: pass (google.com: domain of linux-kernel+bounces-168276-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 3 May 2024 14:36:54 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Heng Qi <hengqi@linux.alibaba.com>, netdev@vger.kernel.org,
 jgg@nvidia.com, leonro@nvidia.com, Andrew Morton
 <akpm@linux-foundation.org>, Tal Gilboa <talgi@nvidia.com>, "open
 list:LIBRARY CODE" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] lib: Allow for the DIM library to be modular
Message-ID: <20240503143654.6843f43e@kernel.org>
In-Reply-To: <60ac51d1-da8a-4108-97c0-2d1ca8dc997e@broadcom.com>
References: <20240503002540.7154-1-florian.fainelli@broadcom.com>
	<20240502175815.4f1619c6@kernel.org>
	<60ac51d1-da8a-4108-97c0-2d1ca8dc997e@broadcom.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 2 May 2024 20:19:27 -0700 Florian Fainelli wrote:
> Looking at "[PATCH net-next v11 0/4] ethtool: provide the dim profile 
> fine-tuning channel" it seems like Heng took care of making all of the 
> newly added functions EXPORT_SYMBOL(). The only thing I see missing is a 
> "select DIMLIB" from config ETHTOOL_NETLINK, do you see something else?

I think we refer to the default DIM tables from net/core/ to clone
them at init time. But we can move the init function into DIM itself.
That's probably for the better.