Received-SPF: pass (google.com: domain of linux-kernel+bounces-168409-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <9fd1c700-fa24-4290-aa77-a6eda9758ace@intel.com>
Date: Fri, 3 May 2024 16:28:24 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v3 05/17] x86/resctrl: Introduce the interface to
 display the assignment state
To: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>, <james.morse@arm.com>
References: <cover.1711674410.git.babu.moger@amd.com>
 <e50e1e55c2ef4f5e1609960e573b30a125a59e5c.1711674410.git.babu.moger@amd.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <e50e1e55c2ef4f5e1609960e573b30a125a59e5c.1711674410.git.babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUpjTVRhbURrVDRNQXoxZHdNcUJydFVoUG4ybUZkdE9Udk1vT3RJZ2hoVVJD?=
 =?utf-8?B?RVhySmdIa0pJaDMyaDFmOHhveVBzOCtOdzNvNWlXMDFaMXJBcGhMaXRYUG5K?=
 =?utf-8?B?LzlGazgwRHE0ZFZRM0c4UWtORHhnT21zUS9JSEJ4aVc5TkgvcTgrSmJnVVg4?=
 =?utf-8?B?RGtqQ0U1TXBuUGRxY1FGQmtKRGxrMmV3d1hwV2ZITG5uekNRTGlST0Y2bjQ4?=
 =?utf-8?B?R0h3c01jWSthUVhxdkdzbC9NNUczKzNONC9ZTU4vWlZuMTNpTCt2WEFITTJ1?=
 =?utf-8?B?OUV6ZXRzb0p0c0xwZkEwb1pOV0dGZWcyMDdQZGZxcU9FeDFWdFEzMzJyVjBw?=
 =?utf-8?B?S3pCQldwaEdwcUg3YUlkWTNjWERtWVkzbFJsczU4SzBWWElsS1BUMzgrNmxL?=
 =?utf-8?B?eW1rZTh2MTM3a0JXYWFNMHNRSWduTHF0L3VKVG12Z2NoTzlkQXZXcTk1T1pU?=
 =?utf-8?B?S0xYQVVIcFhZU2NMQkswT3NWcHZNdlMyRERzekY0TExBK0I3WExHNXlZZi8y?=
 =?utf-8?B?TzgxeUxIc0pGUmRpazNabHpkdUEwVDYzRlA5U0sxaThIZlRyTXVZUzA0amJp?=
 =?utf-8?B?RTVPRk9qaXBDMVh1NlNNaVdZdTdIeUcxbzFhWGxMSDlXck1hYm9yMDlwWE1y?=
 =?utf-8?B?Z05FZ3hMeEp4OUlQL1EyVFNIZXBWRnZlM0Mwa2lDNUQwVGJYQWdPbEE5Qm8v?=
 =?utf-8?B?cW43dWhUK3ZPVmEySjgzL21ockNTT0xYc0tndDFJdXVvWFQ2S01OL052NXYz?=
 =?utf-8?B?MGdqVjdaY2tIeWJVdG1kaitaWGpYWW5jR3BJUitWOS8xQ21EdXJDa1UxTnkz?=
 =?utf-8?B?M2g2Yk5QS0VHbU95Zm1HaUtvcXpYbU0vaFpzSmxZTG8vMUdSMHpPZkxaVTg5?=
 =?utf-8?B?b2VuQkFQYzZGSkZHVDNDZ1VWZDdhd0ZpUnYxakZmMGZUbWV6cS8wSWNlYlFT?=
 =?utf-8?B?Z3UxZUhtSHBKMjdBVitYSU9DeTZ0blV1VDdueXpTYW1VSCtZalppc09hWFU1?=
 =?utf-8?B?L2hsNEV4SGhCSkJNaHExeHZXREgwKzloL3B0NG44NzlpMzluUWZkd3lzOTRC?=
 =?utf-8?B?dVNrWGtCOFZSYlBCcWVhQjE2RU9wbm96eXJBSG8rUXJyZzJKbjRWenp3VFdk?=
 =?utf-8?B?MW51amRvRlhUUVJ1Y1ZzSjQ5MU9IeUVEeFY2NXRqKzlWaWg5WnlvVGdJUHo1?=
 =?utf-8?B?NE1PNSs2L002OGpqc2ZPY29rRlNtS3diV2xuYy8xYXRGZFovakhQS0ZJOVFY?=
 =?utf-8?B?ZGcvbHY4YXBlZGN0RmdzYjY3UnZobTdZeVo5aytzSVIxYzZWTVc3U1BpR1ZJ?=
 =?utf-8?B?OGp6L2UzNVlvNHVPcTBLWGxhL0djTUZiMUttVWhBTU5QOEpHeUlTTUtzd2ZD?=
 =?utf-8?B?V0cydTdKMVBNQW1DSWRjSGVpajArdENIVHMvOERBbjJhY2MyYWhuYUhBdml4?=
 =?utf-8?B?ZjQxVDByQWpIbmw1eTA3WTRBdFBmZ2tyL2c0UTI4aUQ2TnA4UEVVcjh1d1Jn?=
 =?utf-8?B?MmZnN1JpaUN6UEV2dVBhNk4raHNYM1NDdkJDQUUwNmVBeHZhdktSMzVJOFFM?=
 =?utf-8?B?WjlxV1ZEdW9UajBXN3hqMmxQS0lLSWlNYWsxQkw1T2lTbnpDajRwVnVvdisv?=
 =?utf-8?B?d3dUakxmOVl1enJEMGJFTXhNdGl4dnZKVWhKUkduVWhkekxWd0tQV3BqMDF1?=
 =?utf-8?B?cXV4UzdGcGhyWm53bWlsSHFhTDVLOGFGRDd3ZU1TbVNybmUxeStIUmw1ZHpH?=
 =?utf-8?B?NkVyVW5QTnN3TnpOTkFBdmZKT3VRcmhINy9WcW80azI5Q1pOa09aWDNLUXRC?=
 =?utf-8?B?WGE4K2I4ejc1NDAzdzdtejc5SGhuWHVIdnNvaUN0elI5VEdmSDU5b0Ixc0hx?=
 =?utf-8?B?eFMrcng1bHdHTFRZbEpydTQ5ODRsaGNBbDBkM2J1dmxlM3VmRFpNejh5QTlI?=
 =?utf-8?B?ZzZPTXFUcGEyVzcvejlrRUdIUFNybjBPbVJ5UE00QitCTitKbTVybTRZWXVr?=
 =?utf-8?B?UXlGaWlteWtlMzNCc012OGFlZFdDRkF0b2pHYVpIdktQMHRWdHJqWXhCcXg0?=
 =?utf-8?B?ZHlhOHU2RjZSYU9GUExjQyszVGJXemxjNE5lTXRrSzVBZFE2Rno3YjdadEFw?=
 =?utf-8?B?eDBUZVJDYU5YTWhscDUzQyt6dUdJL2E1UjMydFd3K3MyTy9zbXg2SEdHUjR5?=
 =?utf-8?B?U1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a6e0528-45b0-41d5-933e-08dc6bc8bc5a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 23:28:27.8571
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HKm9DhSIeo7nGDRQDIKlsgexZo9udGbqZ8WpGxCUbRYbdeI/aPpmstJjAFBsqSln/Si6XuJWj0o43hSlQ9Lpqg3TK3BBjQRU2bJXSmY3Rg0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6618
X-OriginatorOrg: intel.com

Hi Babu,

On 3/28/2024 6:06 PM, Babu Moger wrote:
> The ABMC feature provides an option to the user to assign an RMID
> to the hardware counter and monitor the bandwidth for a longer duration.
> System can be in only one mode at a time (Legacy Monitor mode or ABMC
> mode). By default, ABMC mode is disabled.

"By default, ABMC mode is disabled." seems to contradict later work.

> 
> Provide an interface to display the monitor mode on the system.
>     $cat /sys/fs/resctrl/info/L3_MON/mbm_assign
>     abmc

This example seems to contradict earlier statements in two ways:
(a) it only shows one mode vs. there are two modes (legacy or ABMC)
(b) there is no active mode vs. one mode is always active.

> 
> When the feature is enabled
>     $cat /sys/fs/resctrl/info/L3_MON/mbm_assign
>     [abmc]
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
> v3: New patch to display ABMC capability.
> ---
>  Documentation/arch/x86/resctrl.rst     |  5 +++++
>  arch/x86/kernel/cpu/resctrl/monitor.c  |  4 +++-
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c | 17 +++++++++++++++++
>  3 files changed, 25 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/arch/x86/resctrl.rst b/Documentation/arch/x86/resctrl.rst
> index 68df7751d1f5..cd973a013525 100644
> --- a/Documentation/arch/x86/resctrl.rst
> +++ b/Documentation/arch/x86/resctrl.rst
> @@ -257,6 +257,11 @@ with the following files:
>  	    # cat /sys/fs/resctrl/info/L3_MON/mbm_local_bytes_config
>  	    0=0x30;1=0x30;3=0x15;4=0x15
>  
> +"mbm_assign":
> +	Available when assignable monitoring features are supported.
> +	Reports the list of assignable features supported and the enclosed brackets
> +	indicate the feature is enabled.

"indicate the feature is enabled" -> "indicate which feature is enabled" or
"indicates the currently enabled feature" or ...?

> +
>  "max_threshold_occupancy":
>  		Read/write file provides the largest value (in
>  		bytes) at which a previously used LLC_occupancy
> diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
> index 735b449039c1..48d1957ea5a3 100644
> --- a/arch/x86/kernel/cpu/resctrl/monitor.c
> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
> @@ -1058,8 +1058,10 @@ int __init rdt_get_mon_l3_config(struct rdt_resource *r)
>  						 RFTYPE_MON_INFO | RFTYPE_RES_CACHE);
>  		}
>  
> -		if (resctrl_arch_has_abmc(r))
> +		if (resctrl_arch_has_abmc(r)) {
>  			r->mbm_assign_capable = ABMC_ASSIGN;
> +			resctrl_file_fflags_init("mbm_assign", RFTYPE_MON_INFO);

I think this will need some more thought when considering the fs/arch split.
The architecture can be expected to set r->mbm_assign_capable as above but
having the architecture meddle with the fs flags does not seem like the right
thing to do. I think that RFTYPE_MON_INFO may not be accessible to arch code
anyway.

> +		}
>  	}
>  
>  	l3_mon_evt_init(r);
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index dda71fb6c10e..5ec807e8dd38 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -846,6 +846,17 @@ static int rdtgroup_rmid_show(struct kernfs_open_file *of,
>  	return ret;
>  }
>  
> +static int rdtgroup_mbm_assign_show(struct kernfs_open_file *of,
> +				    struct seq_file *s, void *v)
> +{
> +	struct rdt_resource *r = of->kn->parent->priv;
> +
> +	if (r->mbm_assign_capable)
> +		seq_puts(s, "abmc\n");
> +
> +	return 0;
> +}

Should it print "legacy" if not mbm_assign_capable? Or actually, I think
the expectation is that this file will only be accessible if 
r->mbm_assign_capable is true ... so having that if (r->mbm_assign_capable)
check is not clear to me ... if that is false then it would be a kernel
bug, no?

> +
>  #ifdef CONFIG_PROC_CPU_RESCTRL
>  
>  /*
> @@ -1903,6 +1914,12 @@ static struct rftype res_common_files[] = {
>  		.seq_show	= mbm_local_bytes_config_show,
>  		.write		= mbm_local_bytes_config_write,
>  	},
> +	{
> +		.name		= "mbm_assign",
> +		.mode		= 0444,
> +		.kf_ops		= &rdtgroup_kf_single_ops,
> +		.seq_show	= rdtgroup_mbm_assign_show,
> +	},
>  	{
>  		.name		= "cpus",
>  		.mode		= 0644,

Reinette