Received-SPF: pass (google.com: domain of linux-kernel+bounces-168406-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <55fa3189-b5da-494f-8ec2-7f0ab4b8d33e@intel.com>
Date: Fri, 3 May 2024 16:26:28 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v3 04/17] x86/resctrl: Introduce
 resctrl_file_fflags_init
To: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>, <james.morse@arm.com>
References: <cover.1711674410.git.babu.moger@amd.com>
 <363c14eeeac99eb0453ac3429f9e7bd446b2acdb.1711674410.git.babu.moger@amd.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <363c14eeeac99eb0453ac3429f9e7bd446b2acdb.1711674410.git.babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFVuV2xDUzFxNGVFSlFxMi8zSXF4ZEVRSXkvcTZtcmdWdW9Jc2hEWmk5c2ht?=
 =?utf-8?B?VDZLaVErOWVmeE9rMUVtOWdzVXBseXFhU0hpbGFNSTRtbS9pMFhFdUFtME51?=
 =?utf-8?B?YTFkbndLUmdOV20yWE9oOGIxUDljVTE1YXhvTVBGSFRZZU1WZ0ZWY3E2UFZ6?=
 =?utf-8?B?ZzQ0ejcrSU9BdmdxNis5UG5pT085Zi9CYW9URDJnRndxYk5OdG1uV2h0bHlI?=
 =?utf-8?B?dGR6bTEwK0YzR1lVZnR2YTJTS3VRcS9kTEVXSEtJaGNGQlVnS0Qzdm91M2Yw?=
 =?utf-8?B?dlpmcy9QdFQvTGxXME92QXo1NjB4NDZKTjdJYlFORGdQdTdMZDdPUnJSbFlL?=
 =?utf-8?B?U3c4K3dTYTlkT0liazJHMGlQUmJwckZJeGt1T2hhVGhhV3IxU0w0NmZva3lP?=
 =?utf-8?B?S3N4d09rTTBQaHh5czc3VUgrRGxNbTFhTTl4b3hCaG9LNHJILzhqQmtFbGpi?=
 =?utf-8?B?YlZRWlk5OXkzM0lhM20rTEFVV1o4OWJna0o4UHJuT0Y5SVFualZ4YlQ4RlQ1?=
 =?utf-8?B?alFvbHZNMG5SSnQzL2JkTHJjNm5RYlRqWmtIMWtxcGhCR2FjTnBhamxmWHRm?=
 =?utf-8?B?ZmN3NkhTcHBKTVY1QUpsaFZVeWtEbENmMEViNHA3c3BQWlVhQ29zcWoyS0NP?=
 =?utf-8?B?Skh3SDVTa00yeFNPNEJyTmdaMjZRdlpuRjFUQ3VtSmdTZ0Y2b3oxRmowKzlo?=
 =?utf-8?B?emtPQTM4VjJRMDdvMHNYT0tkaCtRRTY2SEZMMzNsWlFUeXVKWStHeEMzSElZ?=
 =?utf-8?B?SzRWdm5tbDlCMlQ5NnNvWDltVHNJV053UW9haWlZVTZFVWJtM0E1aUZvUjMy?=
 =?utf-8?B?V0xLLzZ2SnBxZFo4U3lSdFlnMHpQUDJHVzlCYzI3OXFnY21RMTBjcEU1Wkwv?=
 =?utf-8?B?UVVkSTd5NjZrckNNTVhKYzVBSG9qRmpuRWdGbS9SRnlrWnhJaTZ6TWJqZkdI?=
 =?utf-8?B?L2tteTlMeGVPTVV5b0hzS0JOMW4rVUxRT3lSdWRWTTlpbmZkWS92aTQ4T0lX?=
 =?utf-8?B?bDF4clJGQUNtMi9mVXNETkdXQmJtclk2ZXlYOEQ5RmtwVnU4VUFDalVWNUhS?=
 =?utf-8?B?UXVyWFFxVDdjU2FJVGV2dC9wVkxuUUlLdUkvZ2lIYzU2bjNRZ1ZZbHJMQ01t?=
 =?utf-8?B?VkVRMUdtQUZveEJGaDhJdmduM3NESTFnQ3JwWGRuamZNKzVRczhQTyt6L3hh?=
 =?utf-8?B?LzZZbXUyRVlycWEyV1g5Ym42am9NbGxkblFUK3c0aTczZmFWcWlpMDZiT1Nx?=
 =?utf-8?B?OVpFS1JFbGgrei9zVkdkTnphdDU0ZjNmcXYvSk1wY3BVT0w5Slg0U2l0czQr?=
 =?utf-8?B?OVZqM2p3OUx3ekpwMnNSL0xpUkdZMkNXMEdXSGRZc0dtdWhNdE8rbTZzcTZa?=
 =?utf-8?B?a3pqVlZTTHBxNHRJTUxTdVhPZFVHRzRJZ3F3MVJnZHp0RWZPcnpndXZKTE9W?=
 =?utf-8?B?dEorREZMNFh2d3RUOC9GcEhoQnBNbWQzTS9kYy96dTNjc3hNUjVDVk9iRVp0?=
 =?utf-8?B?UkdqeGxjVlpSdUdqREduWXkxT1VZNkZLeHpZMDRkUnRPNjQrTmg4SlRNVnll?=
 =?utf-8?B?Z3d4dGFmdnlhQlZKU05vTStGTVhWVGR2OTludEN4QUJEcW5sNXphOEdpUDA5?=
 =?utf-8?B?SVBkOWNSVnpnTXd0YkVBSHIvVTVNZ011YkVBeEtFT3Z5TnpqTGpZczQ1cXV5?=
 =?utf-8?B?NDB2d0VCSW9QaENPdHJUWWFqT2pNbnlieHB4cmc0LzRlc0hqdUVnaGFKRy9N?=
 =?utf-8?B?UjRoN3hXcVZWdFB2a3pjRG4wQmNSb2ZaWDI3SUVwTEUxZURvWTV0bDBlc2kx?=
 =?utf-8?B?bmRHWmw4M1RxdlB1UG1CZ0VvZTlmeU1KQS9Yd2t4S2pWc3ozK3RMUFArak1a?=
 =?utf-8?B?K0hKYmlrKzlwTXpGcFI0NmRGQU56dUhUMVZQcHFLRUYvZFVUL2J6TmFJeE5Y?=
 =?utf-8?B?ZHpGbnhIL1lOcDdCR0RqVG9hclJnUkRmZDRsWVhBK0lVSTdQQlNIbzMxc2Yv?=
 =?utf-8?B?Y0VLMWJHdnl2Y2NXV3RyOXliYWRUNktkN2FNbThrOXRUakw2RTVrMjBMdG9h?=
 =?utf-8?B?MG82ckROZzZhbnJnSHFzcy9TTkhDUHFLb29Rcms1L1RScnI5WGJOcDUvMTI1?=
 =?utf-8?B?YWtYdzdPYWRobENrRHNRTUpEaVpacG9yK3p5SjhKNlNyWmNtbkNRVm5tMmZp?=
 =?utf-8?B?U1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 718ce420-857f-48ea-7025-08dc6bc87718
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 23:26:31.6958
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NsESkfu/hAxOTIsrGE/Vf+VsNdw/gcXAXpt6ZpFCRsGugoHjEj0uL8kZxIQNIzOpcWG75+cO7pn+sgQi6St9f5rdwYzaiZENNQX2/sBuIk0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8607
X-OriginatorOrg: intel.com

Hi Babu,

In shortlog, please use () to indicate function:
resctrl_file_fflags_init().

On 3/28/2024 6:06 PM, Babu Moger wrote:
> Consolidate multiple fflags initialization into one function.
> 
> Remove thread_throttle_mode_init, mbm_config_rftype_init and
> consolidate them into resctrl_file_fflags_init.

This changelog has no context and only describes what the code does,
which can be learned from reading the patch. Could you please
update changelog with context and motivation for this change?

Reinette