Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp165440lqh; Fri, 3 May 2024 18:00:18 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXboS7wd+ylfJeoVEqIADStBujvwfzsXT7+PYTihwWt64ZoccmFGv+apaMSTiGLeMCO7xXNMFRHCPW2IiVAjwJuM00juARl9oOeecAPsg== X-Google-Smtp-Source: AGHT+IH0pQBYsnihuVEVezWqkNg/vXGvn3LpMCdKW9qzTCENQRcNdDUIVJzTaqBq0dF9+ylBCZas X-Received: by 2002:a05:6a00:4b08:b0:6ed:caf6:6e54 with SMTP id kq8-20020a056a004b0800b006edcaf66e54mr4381562pfb.28.1714784418145; Fri, 03 May 2024 18:00:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714784418; cv=pass; d=google.com; s=arc-20160816; b=dSMuAwsDeRchbI6vqijRIgeA+FLurjSgcRVB1EOUO8KK7gFKU77YbBBkx8y/nfJaLq PzNaUzJb4xTp1GZPSPzlk6LOgDVxNfaA7gUOPZyxcq2zGoJjE8KZBXDm7wdSuKRLvg1Y e4jKHBkymRLASX6/Eo1p9Jx6KSThow1Z4+z2lhPNSVZ5kVKspfccUBu0ksGheq9lXIox ab12XpW050OPasSD/n3lvww1LB7erwGk7samwI5WbG6Mynj1i69H2PAqkKsRPPioG2XP JHDqaUY6mXxLf3LnbvNC50XnZEKXeQAtjJGHPN7Zah7mUG/ipddgSldQqKAImWDicy4g Nu+A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:in-reply-to:message-id:cc:to:subject:from:date :feedback-id:dkim-signature:dkim-signature; bh=ZW3WeXNrA3Tgdn8rt+jXpKLBS86K+0HL1UjmI70+lcg=; fh=kR5P0rLZYd5kjZUpkiaIYlK18tNweJ1zoVqYXSeUgG4=; b=cGtsm5DpJPwoB3N7oFrDcU+KvVTQZo7LEwWaO9XUOj/x20Ts+VE14xVIfwj7IaJBSs zWi8giOSpnVgPeWqN3+6rCkq1svKzp6wK7emRk03cwWbPgZzxI9QkfV/P1eaqeCldFwN h0VXDOxVyYondHFKVKI0uQsAXPMk3W0OLa+FWm+IoI/h/CZMPpbyXAdYXsLiMwQHXfXs cjGvX/fjUPez3n5Vtzs1gvOx3K+nrs/HXnF1L3EDg/JTNhqEcp2Cj/HKlx4O924oV1oc HZ7KjFz2aw1yTK/GJJXALZ63FbI1bYx4M/TLiBTI6tz+owb6RfdOfVw1JVQThR13PGhL 5D3g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lyndeno.ca header.s=fm2 header.b=auHFa091; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=OlubhLYk; arc=pass (i=1 spf=pass spfdomain=lyndeno.ca dkim=pass dkdomain=lyndeno.ca dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=lyndeno.ca); spf=pass (google.com: domain of linux-kernel+bounces-168480-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168480-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lyndeno.ca Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id m15-20020a62f20f000000b006f454a5e4dbsi1037351pfh.90.2024.05.03.18.00.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 May 2024 18:00:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-168480-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@lyndeno.ca header.s=fm2 header.b=auHFa091; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=OlubhLYk; arc=pass (i=1 spf=pass spfdomain=lyndeno.ca dkim=pass dkdomain=lyndeno.ca dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=lyndeno.ca); spf=pass (google.com: domain of linux-kernel+bounces-168480-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168480-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lyndeno.ca Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7C36328496A for ; Sat, 4 May 2024 01:00:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 38D1E17FE; Sat, 4 May 2024 01:00:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lyndeno.ca header.i=@lyndeno.ca header.b="auHFa091"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="OlubhLYk" Received: from wfhigh2-smtp.messagingengine.com (wfhigh2-smtp.messagingengine.com [64.147.123.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD62AA38; Sat, 4 May 2024 01:00:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.123.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714784410; cv=none; b=XkupvgOMaklWw9temrv7AApC9KYfaV+FDR+ujwZn8FWcCvKgCUo1KAHrI+pONZtEh7xH9eWe+tLPXAe9gUdRunXqhhG8XTMmQan60Ihxhz92Sv/i+udzXh3RsIpJyoORiHf8cRBWzSF+08c8ZzAL6vIOkq4Xn9EH8EcW7IYWxlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714784410; c=relaxed/simple; bh=e55VjuJ/jgCJygCBnWw0Cl8E5balwJmlAUVFvWW1wo0=; h=Date:From:Subject:To:Cc:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=d+5Cujmnpl2llrW/YqgHkAko3I33cC8maBxKLsAWku329IQYC/eE0yF6z9jXjmEyUhEKYwGZW7NnuofwzRcdg8ypu+AGI1DUWw8x29bV3uQ0lNvmYlAtAUBRx4L6/HIMLuBp0KizYynKdmhsdDXEV6COfR74/QBhGEO+qOgGIUs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lyndeno.ca; spf=pass smtp.mailfrom=lyndeno.ca; dkim=pass (2048-bit key) header.d=lyndeno.ca header.i=@lyndeno.ca header.b=auHFa091; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=OlubhLYk; arc=none smtp.client-ip=64.147.123.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lyndeno.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lyndeno.ca Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfhigh.west.internal (Postfix) with ESMTP id E0ADF1800114; Fri, 3 May 2024 21:00:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 03 May 2024 21:00:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lyndeno.ca; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1714784406; x=1714870806; bh=ZW3WeXNrA3 Tgdn8rt+jXpKLBS86K+0HL1UjmI70+lcg=; b=auHFa091g2UNTX2EYm6ypvmbU3 yWM6mip3Bwp+BnahqAZAuDfoIrdLCaw2caP9ExsYfIuUDc1CDDwroQBJnWasttl7 pg2DiLv8I4MsaIxnYXwF3FuUOMfCfVFpCxHyeSjrsJYVgGrBOvw1SVGA0CNvfQUL hVZ6Dl+VQB7Ylg/lWiEtJuFpWTdfpHD57osEFSLgI2OmHPAktYhyGeVdQFa29t9Y SUiRtlFJJThGJIzfMc8RlqXiVMDpz7A5Mr1vOgFw29KSHgQqz8allNex0CZYitCa So9gOh02tBzvczgw8s84WBUo454dmtfl+18ljY+E0lq4IZbj8ZogbtkS6AiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1714784406; x=1714870806; bh=ZW3WeXNrA3Tgdn8rt+jXpKLBS86K +0HL1UjmI70+lcg=; b=OlubhLYkSvdSZLRn/gKwUf19Njqy6zywJmHfiYkk9eqX fgHw1TV/fEuf/lT5jg5CuFTvDTrRkbc2roNSLFOkUyD3uWTWahdBfqjWZlnO4Zng nyl/pNLCN+XnoKgmyE5ITNZ+bNJwhvt1hZWVUqH4R3e/LbFRv5CiUeiTDnfjht2Y qNSvLOAhjZvjSiG/65U9mJiNg7K0BBF7HOLgDmI2vI8662U4egt2E3vGVmO1QsE1 GgbkTWnS5cQgBphAexyfM2l8IskqeMVlwbfhyC4ctmK9SfP/XW2hRVu14H+j5J66 OkKnRxuQRCBA7ShszC3GQevfelAlWbasscGTQz2I+w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvuddggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhuffvvefkjghfofggtgesthdtredtredtvdenucfhrhhomhepnfihnhgu ohhnucfurghntghhvgcuoehlshgrnhgthhgvsehlhihnuggvnhhordgtrgeqnecuggftrf grthhtvghrnhepjeffueekgeeijefhvddugedtkeefveevtefghfevfeeufffgvdevleei udfhtddvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eplhhsrghntghhvgeslhihnhguvghnohdrtggr X-ME-Proxy: Feedback-ID: i1719461a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 May 2024 21:00:00 -0400 (EDT) Date: Fri, 03 May 2024 18:59:52 -0600 From: Lyndon Sanche Subject: Re: [PATCH v5] platform/x86: dell-laptop: Implement platform_profile To: Armin Wolf Cc: mario.limonciello@amd.com, pali@kernel.org, srinivas.pandruvada@linux.intel.com, ilpo.jarvinen@linux.intel.com, lkp@intel.com, Hans de Goede , Matthew Garrett , Jonathan Corbet , Heiner Kallweit , Vegard Nossum , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com Message-Id: In-Reply-To: <91e3282c-8271-4c95-a57f-88cca4ba88b5@gmx.de> References: <20240425172758.67831-1-lsanche@lyndeno.ca> <20240501215829.4991-2-lsanche@lyndeno.ca> <91e3282c-8271-4c95-a57f-88cca4ba88b5@gmx.de> X-Mailer: geary/44.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed On Fri, May 3 2024 at 11:19:07 PM +02:00:00, Armin Wolf wrote: > Am 01.05.24 um 23:58 schrieb Lyndon Sanche: >> +static int thermal_init(void) >> +{ >> + int ret; >> + int supported_modes; >> + >> + /* If thermal modes not supported, exit without error */ >> + ret = thermal_get_supported_modes(&supported_modes); >> + if (ret < 0) >> + return ret; > > Hi, > > some older models might not support the USTT commands, which would > prevent dell-laptop > from loading on such machines. > Since dell-smbios-base already knows which commands are supported > (stored in da_supported_commands), > maybe you can add a function for checking if a certain class of > commands is supported and > skip thermal_init() if the USTT commands are not supported. > > Thanks, > Armin Wolf This is a good idea, I will have a look at dell-smbios-base to see exactly how I can check for support. If support is not available, thermal_init will skip or return 0 (depending on where I put the check). Thanks, Lyndon