Received-SPF: pass (google.com: domain of linux-kernel+bounces-168480-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: i1719461a:Fastmail
Date: Fri, 03 May 2024 18:59:52 -0600
From: Lyndon Sanche <lsanche@lyndeno.ca>
Subject: Re: [PATCH v5] platform/x86: dell-laptop: Implement platform_profile
To: Armin Wolf <W_Armin@gmx.de>
Cc: mario.limonciello@amd.com, pali@kernel.org,
	srinivas.pandruvada@linux.intel.com, ilpo.jarvinen@linux.intel.com,
	lkp@intel.com, Hans de Goede <hdegoede@redhat.com>, Matthew Garrett
	<mjg59@srcf.ucam.org>, Jonathan Corbet <corbet@lwn.net>, Heiner Kallweit
	<hkallweit1@gmail.com>, Vegard Nossum <vegard.nossum@oracle.com>,
	platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dell.Client.Kernel@dell.com
Message-Id: <S3SXCS.2L4SMU4H4WJF2@lyndeno.ca>
In-Reply-To: <91e3282c-8271-4c95-a57f-88cca4ba88b5@gmx.de>
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
	<20240501215829.4991-2-lsanche@lyndeno.ca>
	<91e3282c-8271-4c95-a57f-88cca4ba88b5@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed


On Fri, May 3 2024 at 11:19:07 PM +02:00:00, Armin Wolf 
<W_Armin@gmx.de> wrote:
> Am 01.05.24 um 23:58 schrieb Lyndon Sanche:
>> +static int thermal_init(void)
>> +{
>> +	int ret;
>> +	int supported_modes;
>> +
>> +	/* If thermal modes not supported, exit without error */
>> +	ret = thermal_get_supported_modes(&supported_modes);
>> +	if (ret < 0)
>> +		return ret;
> 
> Hi,
> 
> some older models might not support the USTT commands, which would 
> prevent dell-laptop
> from loading on such machines.
> Since dell-smbios-base already knows which commands are supported 
> (stored in da_supported_commands),
> maybe you can add a function for checking if a certain class of 
> commands is supported and
> skip thermal_init() if the USTT commands are not supported.
> 
> Thanks,
> Armin Wolf

This is a good idea, I will have a look at dell-smbios-base to see 
exactly how I can check for support. If support is not available, 
thermal_init will skip or return 0 (depending on where I put the check).

Thanks,

Lyndon