Received-SPF: pass (google.com: domain of linux-kernel+bounces-168485-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 3 May 2024 21:22:34 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Masami Hiramatsu
 <mhiramat@kernel.org>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 Beau Belgrave <beaub@linux.microsoft.com>
Subject: Re: [GIT PULL] tracing/tracefs: Fixes for v6.9
Message-ID: <20240503212234.71c1cad2@rorschach.local.home>
In-Reply-To: <CAHk-=wgMSaivGRNk55fd8F3yODqOYUtY=d+vnXmY2buUKewd8Q@mail.gmail.com>
References: <20240503190728.7510af9a@gandalf.local.home>
	<CAHk-=wgMSaivGRNk55fd8F3yODqOYUtY=d+vnXmY2buUKewd8Q@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Fri, 3 May 2024 17:01:08 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Fri, 3 May 2024 at 16:07, Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > - Minor fix for user_events interface
> >   The ABI of creating a user event states that the fields
> >   are separated by semicolons, and spaces should be ignored.
> >   But the parsing expected at least one space to be there (which was in=
correct).
> >   Fix the reading of the string to handle fields separated by
> >   semicolons but no space between them. =20
>=20
> This is the opposite of a fix.
>=20
> A fix would have fixed the documentation to match reality.
>=20
> Instead, this relaxes our existing parsing. Are there any old kernels
> that had that relaxed parsing? Is there any actual reason to not just
> fix documentation to match reality?
>=20
> Because when reality and documentation do not match, it is not
> *REALITY* that is buggy.

=46rom what Beau and his team told me was that they had tests that were
failing, and when they looked into it, it was because the tests didn't
include a space after the semicolon.

=46rom what I understand (Beau can correct me) but the semicolon was
supposed to be the delimiter and not a "semicolon followed by one or more
spaces".

-- Steve