Received-SPF: pass (google.com: domain of linux-kernel+bounces-168492-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Ivan Orlov <ivan.orlov0322@gmail.com>,
	linux-sound@vger.kernel.org,
	Valentin Obst <kernel@valentinobst.de>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	llvm@lists.linux.dev,
	John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH] selftests/alsa: fix a build warning: return a value in all cases
Date: Fri,  3 May 2024 19:13:30 -0700
Message-ID: <20240504021330.33429-1-jhubbard@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?JuAP99HG7XkCccMGahz+87uYOeeIhsH0fo6zfexOrWzsnyOBPe4iY50xU9QR?=
 =?us-ascii?Q?fECa4wB2908LLDxLKzytqpGBp9K48FrWYr9sRZGybwzDu4CLozenz7SGaTTt?=
 =?us-ascii?Q?AzMEuk9+tw+HiX9lvAux3XeTqw+Inh/tzqhNUZI/F5dRfHWyDCQgUv0yJed0?=
 =?us-ascii?Q?sNNMDYY8sFqjZdRxl2fjFitJCppYz7uPTjieiiawTtFwO0dmuLyNLSfGWWZ1?=
 =?us-ascii?Q?S5KOGRkG9p0vIGgyjeGgYSm6T+99kY4T/RxZuAu2q8b6uBccNJCzVaJJXiwD?=
 =?us-ascii?Q?8MH8E/FYdCrq0H+mddHsHrlrMJNnhyxqN5vp6o829gsgIA9m+dfqNa8JGM3D?=
 =?us-ascii?Q?lOnUcubxP1Ehe7QTrNVN04RHn5t87LWVNQvEKWa0fsh3OWslZuDOuT+U46rW?=
 =?us-ascii?Q?BuIT5I9YTFx38Ilqj7jhDHvO2B9Pyu9IAV57VDAECpvGCS42tAZPx5VQE6IZ?=
 =?us-ascii?Q?ad8guxkWKDETYRN+Q6uJY6yXH2PGQU6hKT8eOraCTnhi7zHsmtkVQV3NNl3A?=
 =?us-ascii?Q?2ddVNnC7S7W956jzbf5eLsEgPcU39Pzr9tOG4LqZRPOQc1wLpYzGE/F45IeH?=
 =?us-ascii?Q?LegsyY66+8eMLE7O2RbeXHOpmYPy8FcHSAljXymH5FL9OSxxHov/0JLXylPa?=
 =?us-ascii?Q?mfjQhxwKhbDnsFqoLh8CrKewoRCHGtBiOQJYU7JOzU7b6FFuG5MvAdM5gNzO?=
 =?us-ascii?Q?VMCVUJgDv1LN3D/C4S8wxN7TJTnfvq4+il+/zwJM9V+PeIIbb6MaLTbEWD0U?=
 =?us-ascii?Q?/q5leW1rA5emEWqrUH7nJBg2jqkbM1hmvWSK6sciGcQBbTtERCtAw7tGXSUw?=
 =?us-ascii?Q?ABYfgj8pxgDiTsRsvYrqziDkmZnVhaJ5/UNFGY7eseDYgDXgdjwtyCSX5z5Z?=
 =?us-ascii?Q?VVR3SN0eBGk036xATo+e2AW/TmE80j2ImLPphcK/XqCbq870iPTQYEJBMBgm?=
 =?us-ascii?Q?nkQN2Q2DKOC9SCo9HuTgGDo6NbSTXxmvtf8ZJ5YUTD5bbOSMmlOQfJD+qWMP?=
 =?us-ascii?Q?yOANq/1EqnxdlkwiYs1tTu8sPyg2+6a4ulzojUrG+VBxVajtp0fL4kvSCEjp?=
 =?us-ascii?Q?SbGWR08MVa+fOW3uLWl136qEpiP+cUB3mIkGFl3itjXJiHtLeM3Lfb0B8EPr?=
 =?us-ascii?Q?udwXI2TbvMTH1Od13F56qWJXbcRHyIA2ZU/iyN1/TUWRM6+a075KsXuxXb92?=
 =?us-ascii?Q?tUca0UzhvP3ORibyreP303yBM5ZdWZcxgojV7DwNgFX10ECDKEEnaVaS0uxL?=
 =?us-ascii?Q?1Qn+GoVVkUe2+pGyoJcr6bBI/zT0qcFAHSer3tH7Nd8bVrOzHE76JdCafjr5?=
 =?us-ascii?Q?YW5XeMKBY35NGAbae0O5EVSr42HN63Bx1Wf8VIC8xfBJuizdkwQYJLh9GAEX?=
 =?us-ascii?Q?y839UtXPFHSSgRZzoYFuTHRK9ayL7FUYR6OxZC3kMJosVPg6FVfJRhQnUv/U?=
 =?us-ascii?Q?6lCLVjktfCFupR+oOZ2tGTk/h3fygm2hdyzykOpcmA161GstNNcsrXBVNUP7?=
 =?us-ascii?Q?869zfsndsmL2qmW1CDU5w/zucFD6IhqAfPvWd/ThdycIhiZKFQsDRw7UQRG4?=
 =?us-ascii?Q?f9y3J9DTHBBi+/oEbG/pHmF40T4TApb6g1mWg8Sx?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c30daede-0714-4b04-de27-08dc6bdfcbdc
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 02:13:32.2806
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0AiRmrEw6VfzHZDkDcunST584lN/OZvmrIsrGxmIpOQTmVBdwdav8PxTFYi8U1jCgsuXYB0Z5TM7pq//fTVSvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6070

dump_config_tree() is declared to return an int, but the compiler cannot
prove that it always returns any value at all. This leads to a clang
warning, when building via:

    make LLVM=1 -C tools/testing/selftests

Fix this by unconditionally returning the "err" variable if the code
reaches the end of the function.

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 tools/testing/selftests/alsa/conf.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/alsa/conf.c b/tools/testing/selftests/alsa/conf.c
index 89e3656a042d..0109fde53e6f 100644
--- a/tools/testing/selftests/alsa/conf.c
+++ b/tools/testing/selftests/alsa/conf.c
@@ -116,6 +116,8 @@ static int dump_config_tree(snd_config_t *top)
 	if (snd_config_save(top, out))
 		ksft_exit_fail_msg("config save\n");
 	snd_output_close(out);
+
+	return err;
 }
 
 snd_config_t *conf_load_from_file(const char *filename)

base-commit: ddb4c3f25b7b95df3d6932db0b379d768a6ebdf7
prerequisite-patch-id: b901ece2a5b78503e2fb5480f20e304d36a0ea27
-- 
2.45.0