Received-SPF: pass (google.com: domain of linux-kernel+bounces-168498-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: Eric Biederman <ebiederm@xmission.com>,
	Kees Cook <keescook@chromium.org>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Mark Brown <broonie@kernel.org>,
	linux-mm@kvack.org,
	Valentin Obst <kernel@valentinobst.de>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	llvm@lists.linux.dev,
	John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH] selftests/exec: build with -fPIE instead of -pie, to make clang happy
Date: Fri,  3 May 2024 19:23:01 -0700
Message-ID: <20240504022301.35250-1-jhubbard@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?t52vRHxscE+4WQVnDvACikPq7AEMp3oDAvLnTT4hgaJMr7GRLGSHFxKd3hx5?=
 =?us-ascii?Q?YC/A5mZW+CEjljiMm3nM61x76LSVX3VVV9SznGs0J1Tle8HSo8SJSMoQmg46?=
 =?us-ascii?Q?9sRPuKr5mutvz2AoqJfbVEVhHrvWsMKGEZhyjiaLvKQif7jspGPrbOYLPI4W?=
 =?us-ascii?Q?gupyBbA19K+ibpECS2xf2DugZjhXBZCI7tDayFaT7ivwERs+Ohn1jWb7z86Y?=
 =?us-ascii?Q?mR1br/Tb+NikMiLLvBmHbgOJFmiIlohKkttXl0qzJ8s+Yy18lgJNDsVeG0mj?=
 =?us-ascii?Q?rS5PRBJE80HNxstdmcqwmNEc/fN833TFqnI36jypad3ra7lGSl9wej8XlyX0?=
 =?us-ascii?Q?7cqx5pyESLEkz3DYfBnHBEO9/iitPlbVzjG7RiAe1lmGMeifd+rChB5ajIKa?=
 =?us-ascii?Q?so4b5JE8SREsg80cGxcCaCz9Kh8Qw0OaC22tybJqffrXWljLdeUHuEGiRxuf?=
 =?us-ascii?Q?sl7yCtHPvukxJBRGkuk+xBf4KoJA4tfaG9IbjIgqy5M4CYN52zm5ot37/FXS?=
 =?us-ascii?Q?PIcMH5IWOW1lHDIv/+2iD9dP/YIlUJ2hABN+stCt7wIX7kKmyx/86pV/glhO?=
 =?us-ascii?Q?AUcBjjKlOtcuHOq7iSj74SPquXm7CNqsA7RuqqqkLwnge30pJMAjEZmJ9vvR?=
 =?us-ascii?Q?oovT9e4ZNSEPT5mals/40ulvKksB60pw2xMrHqMtyHYG94gCSR80uzYahn2F?=
 =?us-ascii?Q?9sJR0efujZfdC/UC1uwNclaUF4hiUpJvNRWGhLFziasAh7t8B5z+79JIfZQ1?=
 =?us-ascii?Q?tRExegY+CTR+TIySUq6zSVD8k1dIbh1WOtcKqMsd+kszFOsCPNbco+ab3iUO?=
 =?us-ascii?Q?JTDx9atvS7mVzM7Q0w1namUNs5RnMYnzxrQFp+7NN8QhdMRIfB1mCAYLhIcr?=
 =?us-ascii?Q?LV0nRPi1BYxu/LbT9wMtCWwpFKARFt31ujjzJfdCK4wtGqKAQuEQV2aFp1fS?=
 =?us-ascii?Q?eXEw+6A/fYWZDgK1xKJtCLGgrPpB0sVHjj2rrXHA63RDmXkjAMkGXA5DQzCM?=
 =?us-ascii?Q?xr6eq9OrldfqGrYxhc/adJ046pEhc1yGUsoLChiUAGa5E0uy/QIkj+MGmjWZ?=
 =?us-ascii?Q?/1HaPVNo1nJggHN90/rrTzpeIHzfPZ1wtVjTNATIk0oJW1w9NZgZFPGpYV43?=
 =?us-ascii?Q?LpT0UB92jHX83fcPtDQ6cBIXruJYIsTAa63jx7RLcZq/1lrVSFizTEgD3DsC?=
 =?us-ascii?Q?ycRPqSdjinZi3PxJeqGluDGngrYGuP3iIkS2RBdt4F8PbTLgmIOAmHV7RxEd?=
 =?us-ascii?Q?XCe238F7Ij7s6yXVJihqZHhpFK7zyvL+vZMJNxX/I4nMo5MfPpVX+41+GE6s?=
 =?us-ascii?Q?txIS3psLCnj/AHvyraf9MB0cvNZKi79r+mN9K+1EFiP/ZNqAMc/lMMB6bvPp?=
 =?us-ascii?Q?zXbU8935i066L7yfmMt7g5R5QyF1iTBlYNQdnyfeMyAgK2hUjXApwuvlW2vc?=
 =?us-ascii?Q?Ep9zMMUt1ygWuZfFDVUmYrfp14ZO9a8mCtEEdXShHufQnHOyaxXZROnAS/00?=
 =?us-ascii?Q?5pOqlukBEJCUo8EhLhCFjT01J0eVCCn7AzNnHq+6ZBpOg/4m8TKbOYGXXo5P?=
 =?us-ascii?Q?bu9qRSYkUJyjdO1uyASOoXuPrtoAOGr4ceUmySN3?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1aaaf012-af93-429b-11db-08dc6be1209c
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 02:23:04.0061
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FfRnOZYuMavkwowwLcAa56ciMstkf4scAZ9FeEgdGVmHpRop3AYljvZaF+ya+S1mpxSJ3BjkMMm9mbJ5isXxVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9394

clang doesn't deal well with "-pie -static": it warns that -pie is an
unused option here. Changing to "-fPIE -static" solves this problem for
clang, while keeping the gcc results identical.

The problem is visible when building via:

    make LLVM=1 -C tools/testing/selftests

Again: gcc 13 produces identical binaries for all of these programs,
both before and after this commit (using "-pie"), and after (using
"-fPIE").

Also, the runtime results are the same for both clang and gcc builds.

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 tools/testing/selftests/exec/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile
index fb4472ddffd8..b7b54d442378 100644
--- a/tools/testing/selftests/exec/Makefile
+++ b/tools/testing/selftests/exec/Makefile
@@ -29,8 +29,8 @@ $(OUTPUT)/execveat.denatured: $(OUTPUT)/execveat
 	cp $< $@
 	chmod -x $@
 $(OUTPUT)/load_address_4096: load_address.c
-	$(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x1000 -pie -static $< -o $@
+	$(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x1000 -fPIE -static $< -o $@
 $(OUTPUT)/load_address_2097152: load_address.c
-	$(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x200000 -pie -static $< -o $@
+	$(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x200000 -fPIE -static $< -o $@
 $(OUTPUT)/load_address_16777216: load_address.c
-	$(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x1000000 -pie -static $< -o $@
+	$(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x1000000 -fPIE -static $< -o $@

base-commit: ddb4c3f25b7b95df3d6932db0b379d768a6ebdf7
prerequisite-patch-id: b901ece2a5b78503e2fb5480f20e304d36a0ea27
-- 
2.45.0