Received-SPF: pass (google.com: domain of linux-kernel+bounces-168511-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 3 May 2024 21:13:20 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Ira Weiny <ira.weiny@intel.com>, Alison Schofield
	<alison.schofield@intel.com>
CC: Dave Jiang <dave.jiang@intel.com>, Fan Ni <fan.ni@samsung.com>, "Jonathan
 Cameron" <Jonathan.Cameron@huawei.com>, Navneet Singh
	<navneet.singh@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	"Davidlohr Bueso" <dave@stgolabs.net>, Vishal Verma
	<vishal.l.verma@intel.com>, <linux-btrfs@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/26] cxl/core: Simplify cxl_dpa_set_mode()
Message-ID: <6635b5e0e3954_1aefb294bf@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240324-dcd-type2-upstream-v1-0-b7b00d623625@intel.com>
 <20240324-dcd-type2-upstream-v1-5-b7b00d623625@intel.com>
 <ZhSPHvoTHl28GXt1@aschofie-mobl2>
 <6635366717079_e1f582941d@iweiny-mobl.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6635366717079_e1f582941d@iweiny-mobl.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ivWEjws37MfdFDWU7stab4M8jg9dDA48w+YUaZAEO0FhFLQ3fD7BuCkYm5Z4?=
 =?us-ascii?Q?veIXxFpaYJSMz7PedwyZaLhIqP0AwI3VyrR8txjpvGbUUwGGsNTg7qh1pQYZ?=
 =?us-ascii?Q?RQLwhFBq/ih/nn8u9LNiEG6lav0rixd7ufDjUWHFoG6P6K6onq5G0YR8N8d0?=
 =?us-ascii?Q?zRVRHyKqhWzr0BQNRwQLvsiCoqMx8RN+cOuv9gISL4JaNnLICXHOpnXOKM/+?=
 =?us-ascii?Q?ij1AzeZ1+xuS0QBdEikXInfvG9a4sclkgppoDwtdO7zMr1c+P7edvMYEJlhZ?=
 =?us-ascii?Q?fMVYntyt7/bqGOSmy6yaPRW39j3VYo6EckukBqzqjWSkv/utveQvgwR9MQgX?=
 =?us-ascii?Q?ZR1RQ713BmtBT6WTpVE/gtBkvZkmF6vd8GgXzd69I+ZQFnt0KUXPxe2zK7c5?=
 =?us-ascii?Q?NqLs/oWgearJDMWwJfYQOZ4SCwUV/JFb/d+by5zlezyiIljOSRvc5HR0kQOk?=
 =?us-ascii?Q?DSAIhb9/ZVwTzz3Jxunzdqq8Q9tG51nqQpmk7yEAAtLUxDDxFYp4+IMMhWpV?=
 =?us-ascii?Q?uJkxWi1fZIBgzQC4WhuuMSORRXo5JSGftjPPEoVPJb2yoQT52c/stLngBOxN?=
 =?us-ascii?Q?kby2AU2hPG9Of6TVAq0+fsO+zCjHCA7cFb86OjCVXNAKO0SxtOAMGmGyb8Px?=
 =?us-ascii?Q?kKOJA82V1b5Apw9Ko9FZEEyFF/MPSffrKi+TEwro7OTRHBZHQVsYNzGGRb4C?=
 =?us-ascii?Q?jbcpSkgfJNhpwVQOD8Abv1WE8URyUS9NCQvDsioIK8L1vkV52eRdg/950AZD?=
 =?us-ascii?Q?gpQCbPE5du5yFiCnyJk9Drh/j+bZD9TZ7/NCn8OYwWMLGDeaPjWfD7pbMP6b?=
 =?us-ascii?Q?iAe5gS7IPbvhtjQ/HXEK1PqeZiZRDO3U40GOeVe9j+zF3gYSC32d8lwnoYy1?=
 =?us-ascii?Q?9cXuMjt/ZBb1FchXoNZFSDQvgxSDN0b2/oE0dvZxJXj3/bPJrFPq/ETG/EGE?=
 =?us-ascii?Q?zyyOEdOGeU94gTgcePFBHbNY9oN1lS/Zkhz99AannyLp05MetDEEDyGTF9yZ?=
 =?us-ascii?Q?mQf+jCJdfDxfajR4atKKekSsuk0wN5g2j9EMrt4IWKuiSDFFpOjkyJTC6bFC?=
 =?us-ascii?Q?zdYAPaopJ+5nTb402P+Al4m26GVuM2OSs/RzFqttwYKMItOIHOyf1Ds65vBv?=
 =?us-ascii?Q?UjN7g4auUCCe2fuY8RzkgISeQQxuso6WWmwoVCqO+30zzZmL6668PAWv5Dtl?=
 =?us-ascii?Q?D9yWgsNprAbU5r15r/GLGrEeo/blABQ0pmBGGEi9pZH5AYZhGyij9DFsfrzc?=
 =?us-ascii?Q?g/dhnt6vy+PVyZFPwBztiPQ6Tju2J2lsWOuX1agopHfz3eqqMgukIY5UfiLG?=
 =?us-ascii?Q?lqOOUStSjxkVfS423nRHQgx+7bulntZy2Aka/OQoFZkJJYlNkWUHy9nb71o5?=
 =?us-ascii?Q?boajAXD1ABWNEhgm8H6oRhkH2TwdCkdZwb0u6vMpDRnQtwSpR5WZ3uXCwxYB?=
 =?us-ascii?Q?9f3QDz657NrxnZhepPr6Kzx64Cnqo+0/j8thuu9uLfo5Mrv3c1w34f3l3w7q?=
 =?us-ascii?Q?ndLxajkOUfheeXaurKaw2zYS4IGpz6tcQl832NUX4DsT9PyaSdemxRvwsmLz?=
 =?us-ascii?Q?T7p/4XZHFV+oCFoMbgd+ibZQhN9M/QOPDl/v/3EWtPB1P7ROByRUrPj4Bo8L?=
 =?us-ascii?Q?6g=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 60fefef5-0180-4e21-4dad-08dc6bf089fe
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 04:13:23.3358
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WzIpjE+oawmgfL/lnWsvAF/jItQ+6CiKfar3tv7upWDiXwC36G9vJ7vZbdYa8UGg3sQ++jkHeshKwjoLUNXK0lAYREZ0JV1amM6XOT7dixM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4765
X-OriginatorOrg: intel.com

Ira Weiny wrote:
> Alison Schofield wrote:
> > On Sun, Mar 24, 2024 at 04:18:08PM -0700, Ira Weiny wrote:
> > > cxl_dpa_set_mode() checks the mode for validity two times, once outside
> > > of the DPA RW semaphore and again within.
> > 
> > Not true.
> 
> Sorry for not being clear.  It does check the mode 2x but not for
> validity.  I'll clarify.
> 
> > It only checks mode once before the lock. It checks for
> > capacity after the lock. If it didn't check mode before the lock,
> > then unsupported modes would fall through.
> 
> But we can check the mode 1 time and either check the size or fail.
> 
> > 
> > > The function is not in a critical path.
> > 
> > Implying what here?  OK to check twice (even though it wasn't)
> > or OK to expand scope of locking.
> 
> Implying that checking the mode outside the lock is not required.
> 
> > 
> > > Prior to Dynamic Capacity the extra check was not much
> > > of an issue.  The addition of DC modes increases the complexity of
> > > the check.
> > > 
> > > Simplify the mode check before adding the more complex DC modes.
> > > 
> > 
> > The addition of the DC mode check doesn't seem complex.
> 
> It is if you have to check it 2 times.
> 
> > 
> > Pardon my picking at the words, but if you'd like to refactor the
> > function, just say so. The final result is a bit more readable, but
> > also adding the DC mode checks without refactoring would read fine
> > also.
> 
> When I added the DC mode to this function without this refactoring it was
> quite a bit more code and ugly IMO.  So this cleanup helped.  If I were
> not adding the DC code there would be much less reason to change this
> function.

Where did the "quite a bit more code" come from? A change that moves
unnecessary code under a lock and is larger than just incrementally
extending the status quo does not feel like a cleanup.

diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
index 7d97790b893d..0dc886bc22c6 100644
--- a/drivers/cxl/core/hdm.c
+++ b/drivers/cxl/core/hdm.c
@@ -411,11 +411,12 @@ int cxl_dpa_set_mode(struct cxl_endpoint_decoder *cxled,
        struct cxl_memdev *cxlmd = cxled_to_memdev(cxled);
        struct cxl_dev_state *cxlds = cxlmd->cxlds;
        struct device *dev = &cxled->cxld.dev;
-       int rc;
+       int rc, dcd;
 
        switch (mode) {
        case CXL_DECODER_RAM:
        case CXL_DECODER_PMEM:
+       case CXL_DECODER_DC0 ... CXL_DECODER_DC7:
                break;
        default:
                dev_dbg(dev, "unsupported mode: %d\n", mode);
@@ -442,6 +443,11 @@ int cxl_dpa_set_mode(struct cxl_endpoint_decoder *cxled,
                rc = -ENXIO;
                goto out;
        }
+       dcd = dc_mode_to_region_index(mode);
+       if (resource_size(&cxlds->dc_res[dcd]) == 0) {
+               dev_dbg(dev, "no available dynamic capacity\n");
+               goto out;
+       }
 
        cxled->mode = mode;
        rc = 0;