Received-SPF: pass (google.com: domain of linux-kernel+bounces-168515-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	=?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	Ryan Roberts <ryan.roberts@arm.com>,
	Christian Brauner <brauner@kernel.org>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Alexey Gladkov <legion@kernel.org>,
	Valentin Obst <kernel@valentinobst.de>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	llvm@lists.linux.dev,
	John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH 1/2] selftests/openat2: fix clang build failures: -static-libasan, LOCAL_HDRS
Date: Fri,  3 May 2024 21:43:35 -0700
Message-ID: <20240504044336.14411-1-jhubbard@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?wYEBryD2c6DCZPEkH1RsIOqTq/wdNSaFLKCKkMo9AJOWjsWN6YRhErCOM/Mn?=
 =?us-ascii?Q?oPXW0ZoA87MujrGNUp8hxXRBxZSNGg7vWJL+IkFqMdPfx4VOBFaV32uH3NxL?=
 =?us-ascii?Q?kXxCJ54BTk+Cul9fKNls5eiebkxkIRLzVczjKt0yGy94M+PFTgQ7DH60Knfl?=
 =?us-ascii?Q?dlissZ9s4vdV1xmcjcfQvzJVzKbIWKyZxi4TGGFIFJthdI5QpUDU5RaZ64nV?=
 =?us-ascii?Q?p23r3En/6wHNEZ6nQWzUKH2d69C+LOviJ/QPyJ98MJWaKhffUhDsT3GxmiqW?=
 =?us-ascii?Q?qpK6VoNaS6aOkHQEFmmlGhi/NttThSDeHd7XE93HEhVqlA9y2Y2AeQgXvQek?=
 =?us-ascii?Q?vZ4F8O5QSEP/K3A+zATgNkZ+2B9C9kgDttbfFNWEUc2qtBFWk70yCKWdTyIM?=
 =?us-ascii?Q?fzZ3KSOG3wyZ+ZOVvTeOq2PnY+6wKQWlUZAOYmjZc1hhdkykGQRJAnOJCecz?=
 =?us-ascii?Q?Hu1wOsWvz3UKwvqTm12mwlgmk6u7rljSzC+ZTRkkgQS8mhs7pOtzUdlZ8vZg?=
 =?us-ascii?Q?R1h4WddbLCgxHM/A3AUbxVdE6V3AZqahgyODgCe0vn86d9VCy4EPQCojm0+N?=
 =?us-ascii?Q?IjIzQMohpAf2UQoVuGVzdFmfEkomsdf2c/D2DzqlpTXeFHsSHUMMNSvF40mf?=
 =?us-ascii?Q?H9v+YXNFn3FyFZS+j01tPCi0F40X2XZQQylJj6yPdqefChblpePUu2hO/loq?=
 =?us-ascii?Q?LfATNf6qdhQfHmsk6ZjUtjw7AKRxcvofBgDOZcNTirnN6mGhVBVcU1w89j9E?=
 =?us-ascii?Q?Jh95IqFG3/05z/SmQdYGq0R8kdP8nrYop4axO6DDI0M0TwtucTndq3V8oofz?=
 =?us-ascii?Q?EPbQdsp9RtdMRzLjWQBjsyv3VeSkwCXqh0KBaBlak6ZJA0u6fKte7gWyRNNO?=
 =?us-ascii?Q?wPhSYP0tyFLZjw3xGnvPRg5sIzCItl8zVP1xHvasQXypFjcje4rzGwVJNJdy?=
 =?us-ascii?Q?3LwcwOynwn0MPTHjOkLRNsXnqNoH+hep9rZaGpKiSytbVtYmS39LxIzpwZBc?=
 =?us-ascii?Q?AzjvsnCHFN+jImyA6+q4n7dwNzkV/XaZkGfsIQkUF4l4ho0QrDyyHQCp8/K1?=
 =?us-ascii?Q?8ZbwqQDXkgOB3bRE289pZhXKW8qSWnKIE3gp8Hb8M5rzetJTBOj13n/5IuiP?=
 =?us-ascii?Q?kLr0innOmjGdIRh/0CXZje9w7TsYMjQwpYtuJ4xONlN5BfE/orcp/+c9IjSj?=
 =?us-ascii?Q?T9IOp59ty2qFOE8TaGnd42XU5PZwCRzKShuHOEknKBIHyAnr0TSdo+bJnEC5?=
 =?us-ascii?Q?EIYwahw4fJ7pHKwdzhk/B0mtsvvCydYDg+Isf4UHuZhbHoI4NJH/S3TNnLeh?=
 =?us-ascii?Q?kyvMQzaYWC41bc6Be2lpof2r/vczInfwb6b5YFDuNcdERRLVrICAw8LA2bXh?=
 =?us-ascii?Q?vDceSf00GPQ7FsougGX00JkX9IDuTcjue4STjQJzcsovJyjwLwr37JpPTeZT?=
 =?us-ascii?Q?9ZKV9FSFfAJXKjR4LGgc7wTTlTr3sfJh2/dCJL7HpdqsqcOOX390vjKV0g4f?=
 =?us-ascii?Q?FmPkxZtws+qyVZBoH+dBYtITdTs3u8BZBlIWv+WIdO+ddDyfvXyVZrWZyQpf?=
 =?us-ascii?Q?t6qNIOBK8+xBRRSsCf76XcSJwmN53aYdTtFagO1Z?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7321d832-0a75-40ff-78f4-08dc6bf4c626
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 04:43:42.1419
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5bnqx9cqp81JFHKtmt9CUHOe/nDO8cjYFLVnLAHWq0Vkh9sPZ/L6UkC24c+RxjCWMsF9uzWctLeS8cu0GvnBzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7174

When building with clang via:

    make LLVM=1 -C tools/testing/selftests

two distinct failures occur:

1) gcc requires -static-libasan in order to ensure that Address
Sanitizer's library is the first one loaded. However, this leads to
build failures on clang, when building via:

       make LLVM=1 -C tools/testing/selftests

However, clang already does the right thing by default: it statically
links the Address Sanitizer if -fsanitize is specified. Therefore, fix
this by simply omitting -static-libasan for clang builds. And leave
behind a comment, because the whole reason for static linking might not
be obvious.

2) clang won't accept invocations of this form, but gcc will:

    $(CC) file1.c header2.h

Fix this by using selftests/lib.mk facilities for tracking local header
file dependencies: add them to LOCAL_HDRS, leaving only the .c files to
be passed to the compiler.

Cc: Ryan Roberts <ryan.roberts@arm.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 tools/testing/selftests/openat2/Makefile | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/openat2/Makefile b/tools/testing/selftests/openat2/Makefile
index 254d676a2689..185dc76ebb5f 100644
--- a/tools/testing/selftests/openat2/Makefile
+++ b/tools/testing/selftests/openat2/Makefile
@@ -1,8 +1,18 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
-CFLAGS += -Wall -O2 -g -fsanitize=address -fsanitize=undefined -static-libasan
+CFLAGS += -Wall -O2 -g -fsanitize=address -fsanitize=undefined
 TEST_GEN_PROGS := openat2_test resolve_test rename_attack_test
 
+# gcc requires -static-libasan in order to ensure that Address Sanitizer's
+# library is the first one loaded. However, clang already statically links the
+# Address Sanitizer if -fsanitize is specified. Therefore, simply omit
+# -static-libasan for clang builds.
+ifeq ($(LLVM),)
+    CFLAGS += -static-libasan
+endif
+
+LOCAL_HDRS += helpers.h
+
 include ../lib.mk
 
-$(TEST_GEN_PROGS): helpers.c helpers.h
+$(TEST_GEN_PROGS): helpers.c

base-commit: ddb4c3f25b7b95df3d6932db0b379d768a6ebdf7
prerequisite-patch-id: b901ece2a5b78503e2fb5480f20e304d36a0ea27
-- 
2.45.0