Received-SPF: pass (google.com: domain of linux-kernel+bounces-168517-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	=?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	Ryan Roberts <ryan.roberts@arm.com>,
	Christian Brauner <brauner@kernel.org>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Alexey Gladkov <legion@kernel.org>,
	Valentin Obst <kernel@valentinobst.de>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	llvm@lists.linux.dev,
	John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH 2/2] selftests/fchmodat2: fix clang build failure due to -static-libasan
Date: Fri,  3 May 2024 21:43:36 -0700
Message-ID: <20240504044336.14411-2-jhubbard@nvidia.com>
In-Reply-To: <20240504044336.14411-1-jhubbard@nvidia.com>
References: <20240504044336.14411-1-jhubbard@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?FZ5LBJMztS/m9wBDuEPzOsPTLoyS8whH+pqSa9B8V7nd/U35HVw/zVy+omlk?=
 =?us-ascii?Q?CtV5ak5+TsKMOANhj5u0oafq94xYJGV0OlKFqTtvSa3YKFipDsFtpA9kXPmg?=
 =?us-ascii?Q?mj+778JMGhIQ5saIIbpkPL8pRI9lgZast0R92qB8DAskyUUSA6QFesHHOkoN?=
 =?us-ascii?Q?ermmH+PIPB15zLqhnUVpip4QUM8O20MeQheqr8Wry5R7YS1VMnNiVJY3bYW9?=
 =?us-ascii?Q?A/BNGUtHrheMFL8b6RgF9kaIyyBtYhq1mHs6yuT9mV/RA2LOPrhKTIddgcmg?=
 =?us-ascii?Q?K2jvgmxmrkVhy1afHkLB7B+AOnHsYbTE4TWJfSNmX3zbQWfdHVqVSC5GQ/uo?=
 =?us-ascii?Q?l4G7ACiFmww6gPMlOoNEF653wr0xYXiiQARbfs4s9Ne18k/inwpizB92Laes?=
 =?us-ascii?Q?DrIedpv3qUxH/VK10mb8aM8gCbcW6vbPuGunNQjM90xErxPDUprtM4h6UD/4?=
 =?us-ascii?Q?EMDd4k8aZaNTsC/Yl/5xgB2R5DG01behZnAc+ew1KiKiG3rl1ZhLcgNOhcZn?=
 =?us-ascii?Q?1d8bnEA/X/TSH13jlCU4K8vipFTp3Ms/1+nFl9grCSuT23OEBsJ4e8LN1zVI?=
 =?us-ascii?Q?o+uZCNkjmDxN/8EpLwAwqlgFjSE8y7ng0qf4K8V0Iy9Kzmp+Um3ZxV0UtUvx?=
 =?us-ascii?Q?bQL8kUorWXxMgZAC5fBtrc3pAr9Y29MTBUhA3jSjUZ4RnUNTHKg9EvOc5ais?=
 =?us-ascii?Q?YpKcfFOXPDSd3lpwksEiU9wos5tZUaDUOOnyyTp22OBWxGDZYHnB8hijczYs?=
 =?us-ascii?Q?Ycki10VcWrrrawSK2HwyZZDVpU8wV8uYQsfcpv7ugqquJm+yVoSnaswqLWQG?=
 =?us-ascii?Q?jD0od+EkCaWiGsYyBt2EiGO/M5eF8uoUh1dRKwFp6okSSTPE2VMr3Mt/EGxS?=
 =?us-ascii?Q?A/6bjSH8hzR0rb+i5hwOc2pZb1KpRSQ3D1i4hZBElxKHN0HRbNQrG0Seh5v1?=
 =?us-ascii?Q?UKMMY8G3H7DQp0wMzDEMx+vHyP3wJOhzNG3OwtjWhE0LziQUU5km+ANTOQ//?=
 =?us-ascii?Q?C9RU8JW8nDKOlMTKREZSRRWsLrxLxx27Ov+n8ce5iFVFT9UTXV/2nPq2ePJm?=
 =?us-ascii?Q?C7yKm9bugQN2u5dllSlqap1XYAHROD3BFlJe1lEl5uMy5ajGAb91HpwT9VK5?=
 =?us-ascii?Q?NG+dZ6SJnlj/Dg2jeZ/GP4GCrjX07T4SuIFnt4TsOjlH3LEVFIMiri9UB9un?=
 =?us-ascii?Q?6gy7FLew2qniRfwZiUFthVG1Ki7fr01p0indaNLi+83h3H8xnj58tACi22fh?=
 =?us-ascii?Q?vhgZ614pTixlk4Qy6ejd35Q/FJmAEkJ6z79rbBqR1TgOX6nxVl2GNKDBnIhc?=
 =?us-ascii?Q?ls39EBAKkM4Wrf93F8kxRZ1PXV4dOf4QEt/MAxIEleBj1lE5svIJm54z2FSd?=
 =?us-ascii?Q?WQfSFp+HYMepJVZojPbMP/6T/iQfSztEt0sRaEJ2F3VmBClLwXw+cwlZsDlL?=
 =?us-ascii?Q?6psAnB6l2giwVlRl7hu+BQb/jfO5R939NtqxkUY9kool/qbwlNTn33MPqiEH?=
 =?us-ascii?Q?EtxDa8hpJfIjlHOsH/+7VCoV4eb/lV/K4bJbPRjoPpoRoRiQdCLDRHPy7KH6?=
 =?us-ascii?Q?PhQ3uAqTpBvNA90xOtDfUsf6KNev8eu0q5z1p4H2?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d37e3e15-e43b-4cde-d60f-08dc6bf4c694
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 04:43:42.8512
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GpFuGi1ghOS0c9rE/2E7wX6NkZQkpx/ViWpl+3JsNLDDzf/QUhWVQ/AOw9pmH1dVS0SBnZJ73ol9PZ6AxoZnDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7174

gcc requires -static-libasan in order to ensure that Address Sanitizer's
library is the first one loaded. However, this leads to build failures
on clang, when building via:

    make LLVM=1 -C tools/testing/selftests

However, clang already does the right thing by default: it statically
links the Address Sanitizer if -fsanitize is specified. Therefore,
simply omit -static-libasan for clang builds. And leave behind a
comment, because the whole reason for static linking might not be
obvious.

Cc: Ryan Roberts <ryan.roberts@arm.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 tools/testing/selftests/fchmodat2/Makefile | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/fchmodat2/Makefile b/tools/testing/selftests/fchmodat2/Makefile
index 71ec34bf1501..4373cea79b79 100644
--- a/tools/testing/selftests/fchmodat2/Makefile
+++ b/tools/testing/selftests/fchmodat2/Makefile
@@ -1,6 +1,15 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
-CFLAGS += -Wall -O2 -g -fsanitize=address -fsanitize=undefined -static-libasan $(KHDR_INCLUDES)
+CFLAGS += -Wall -O2 -g -fsanitize=address -fsanitize=undefined $(KHDR_INCLUDES)
+
+# gcc requires -static-libasan in order to ensure that Address Sanitizer's
+# library is the first one loaded. However, clang already statically links the
+# Address Sanitizer if -fsanitize is specified. Therefore, simply omit
+# -static-libasan for clang builds.
+ifeq ($(LLVM),)
+    CFLAGS += -static-libasan
+endif
+
 TEST_GEN_PROGS := fchmodat2_test
 
 include ../lib.mk
-- 
2.45.0