Received-SPF: pass (google.com: domain of linux-kernel+bounces-168519-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240501195116.62669-1-ppbuk5246@gmail.com>
In-Reply-To: <20240501195116.62669-1-ppbuk5246@gmail.com>
From: Yun Levi <ppbuk5246@gmail.com>
Date: Sat, 4 May 2024 05:47:11 +0100
Message-ID: <CAM7-yPQMDZ9SZPVQExCd2bqTRTzoBVwQUSgrXp=1WSDDOCajag@mail.gmail.com>
Subject: Re: [PATCH] time/timgr: Fix wrong reference when level 0 group
 allocation failed
To: anna-maria@linutronix.de, frederic@kernel.org, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Gentle ping

On Wed, May 1, 2024 at 8:51=E2=80=AFPM Levi Yun <ppbuk5246@gmail.com> wrote=
:
>
> When tmigr_setup_groups() failed level 0 group allocation,
> next do while loop refers wrong local stack array location.
>
> Changing group init do while loop with while loop to fix this problem.
>
> Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
> ---
>  kernel/time/timer_migration.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.=
c
> index ccba875d2234..84413114db5c 100644
> --- a/kernel/time/timer_migration.c
> +++ b/kernel/time/timer_migration.c
> @@ -1596,7 +1596,7 @@ static int tmigr_setup_groups(unsigned int cpu, uns=
igned int node)
>
>         } while (i < tmigr_hierarchy_levels);
>
> -       do {
> +       while (i > 0) {
>                 group =3D stack[--i];
>
>                 if (err < 0) {
> @@ -1645,7 +1645,7 @@ static int tmigr_setup_groups(unsigned int cpu, uns=
igned int node)
>                                 tmigr_connect_child_parent(child, group);
>                         }
>                 }
> -       } while (i > 0);
> +       }
>
>         kfree(stack);
>
> --
> 2.41.0
>